Bug 1633193 - Specyfing undercloud_ntp_servers results in corrupted hieradata
Summary: Specyfing undercloud_ntp_servers results in corrupted hieradata
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: instack-undercloud
Version: 10.0 (Newton)
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: z4
: 13.0 (Queens)
Assignee: James Slagle
QA Contact: Arik Chernetsky
URL:
Whiteboard:
Depends On:
Blocks: 1651692
TreeView+ depends on / blocked
 
Reported: 2018-09-26 11:56 UTC by Michal Pryc
Modified: 2019-01-16 17:55 UTC (History)
4 users (show)

Fixed In Version: instack-undercloud-8.4.6-4.el7ost
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1651692 (view as bug list)
Environment:
Last Closed: 2019-01-16 17:55:03 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1794501 0 None None None 2018-09-26 11:56:13 UTC
OpenStack gerrit 618845 0 None MERGED Fix curly brackets for ntp::servers: to prevent HTML escaping 2020-06-29 17:16:23 UTC
Red Hat Product Errata RHBA-2019:0068 0 None None None 2019-01-16 17:55:17 UTC

Description Michal Pryc 2018-09-26 11:56:14 UTC
Description of problem:

This was observed on OSP10 (Newton) together with RHEL 7.4.

Running "openstack undercloud install" with the following values in undercloud.conf:

 undercloud_ntp_servers = clock.redhat.com

Results hieradata to contain improper value for ntp::servers: as follows:

   ntp::servers: ['clock.test.com']


It's because this value is in double curly brackets {{ }}, however according to MUSTACHE(5):

"
All variables are HTML escaped by default. If you want to return unescaped HTML, use the triple curling brackets: {{{name}}}.
"

Correcting puppet-stack-config.yaml.template to include triple curly brackets fixes the problem:

ntp::servers: ['clock.test.com']

Passing list of undercloud_ntp_servers in the undercloud.conf with corrected template results in:

ntp::servers: ['clock.test.com','secondclock.test.com']

Comment 15 errata-xmlrpc 2019-01-16 17:55:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0068


Note You need to log in before you can comment on or make changes to this bug.