Description of problem: Trying to build libvirt.git, which runs 'pdwtags --verbose remote/.libs/libvirt_driver_remote_la-remote_protocol.o' to check for any accidental regressions in struct layout. Version-Release number of selected component: dwarves-1.12-1.fc28 Additional info: reporter: libreport-2.9.5 backtrace_rating: 4 cmdline: pdwtags --verbose remote/.libs/libvirt_driver_remote_la-remote_protocol.o crash_function: union__fprintf executable: /usr/bin/pdwtags journald_cursor: s=f53fef45168047f5a4af5ab700c34aed;i=166c4a;b=cd03dd71896b45d38feb4cb2a0b14017;m=8f791c42bd;t=576ca46538b0f;x=b2a7a65b4c5b4efc kernel: 4.18.7-200.fc28.x86_64 rootdir: / runlevel: N 5 type: CCpp uid: 14986 Truncated backtrace: Thread no. 1 (9 frames) #0 union__fprintf at /usr/src/debug/dwarves-1.12-1.fc28.x86_64/dwarves_fprintf.c:847 #1 tag__fprintf at /usr/src/debug/dwarves-1.12-1.fc28.x86_64/dwarves.h:968 #2 emit_tag at /usr/src/debug/dwarves-1.12-1.fc28.x86_64/pdwtags.c:37 #3 cu__emit_tags at /usr/src/debug/dwarves-1.12-1.fc28.x86_64/pdwtags.c:49 #4 pdwtags_stealer at /usr/src/debug/dwarves-1.12-1.fc28.x86_64/pdwtags.c:77 #5 finalize_cu_immediately at /usr/src/debug/dwarves-1.12-1.fc28.x86_64/dwarf_loader.c:2310 #6 cus__load_module at /usr/src/debug/dwarves-1.12-1.fc28.x86_64/dwarf_loader.c:2310 #7 cus__process_dwflmod at /usr/src/debug/dwarves-1.12-1.fc28.x86_64/dwarf_loader.c:2355 #8 ??
Created attachment 1487408 [details] File: backtrace
Created attachment 1487409 [details] File: cgroup
Created attachment 1487410 [details] File: core_backtrace
Created attachment 1487411 [details] File: cpuinfo
Created attachment 1487412 [details] File: dso_list
Created attachment 1487413 [details] File: environ
Created attachment 1487414 [details] File: exploitable
Created attachment 1487415 [details] File: limits
Created attachment 1487416 [details] File: maps
Created attachment 1487417 [details] File: mountinfo
Created attachment 1487418 [details] File: open_fds
Created attachment 1487419 [details] File: proc_pid_status
The following diff was sufficient for me to avoid the core dump, but I have no idea if it is actually the correct thing to do. diff --git i/dwarves_fprintf.c w/dwarves_fprintf.c index 2164c9e..40600c7 100644 --- i/dwarves_fprintf.c +++ w/dwarves_fprintf.c @@ -844,7 +844,8 @@ static size_t union__fprintf(struct type *type, const struct cu *cu, * back to it. Else we'll end up showing cacheline boundaries in * just the first of a multi struct union, for instance. */ - initial_union_cacheline = *uconf.cachelinep; + if (uconf.cachelinep) + initial_union_cacheline = *uconf.cachelinep; type__for_each_member(type, pos) { struct tag *type = cu__type(cu, pos->tag.type); @@ -858,7 +859,8 @@ static size_t union__fprintf(struct type *type, const struct cu *cu, printed += union_member__fprintf(pos, type, cu, &uconf, fp); fputc('\n', fp); ++printed; - *uconf.cachelinep = initial_union_cacheline; + if (uconf.cachelinep) + *uconf.cachelinep = initial_union_cacheline; } return printed + fprintf(fp, "%.*s}%s%s", indent, tabs, @@ -1128,7 +1130,7 @@ static size_t class__fprintf_cacheline_boundary(struct conf_fprintf *conf, uint32_t cacheline = offset / cacheline_size; size_t printed = 0; - if (cacheline > *conf->cachelinep) { + if (conf->cachelinep && cacheline > *conf->cachelinep) { const uint32_t cacheline_pos = offset % cacheline_size; const uint32_t cacheline_in_bytes = offset - cacheline_pos;
Reproduced the problem fixed it, please try the attached patch. Can I add a: Reported-by: Eric Blake <eblake> To the upstream cset fixing this issue? thanks for reporting!
Created attachment 1487468 [details] Make sure we keep track the cacheline we're in while processing unions
(In reply to Arnaldo Carvalho de Melo from comment #14) > Reproduced the problem fixed it, please try the attached patch. > > Can I add a: > > Reported-by: Eric Blake <eblake> > > To the upstream cset fixing this issue? > > thanks for reporting! Sure.
(In reply to Arnaldo Carvalho de Melo from comment #15) > Created attachment 1487468 [details] > Make sure we keep track the cacheline we're in while processing unions Confirmed that this patch works for libvirt.
This message is a reminder that Fedora 28 is nearing its end of life. On 2019-May-28 Fedora will stop maintaining and issuing updates for Fedora 28. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '28'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 28 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 28 changed to end-of-life (EOL) status on 2019-05-28. Fedora 28 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.