Bug 1633571

Description of problem:

There is a typo (an additional blank space) in openshift-ansible/playbooks/openstack/openshift-cluster/uninstall.yml playbook,
which makes the playbook fail when executed.

- name: Unsubscribe RHEL instances                                              
  hosts: oo_all_hosts                                                           
  become: yes                                                                   
  gather_facts: yes                                                             
  tasks:                                                                        
  - name: Unsubscribe RHEL instances                                            
    import_role:                                                                
      name: rhel_unsubscribe                                                    
    when:                                                                       
    - ansible_distribution == "RedHat"                                                                                                                                                                             
     - (rhsub_user is defined and rhsub_pass is defined) or (rhsub_ak is defined and rhsub_orgid is defined)    <---

   /\
   |

Version-Release number of the following components:

$ rpm -q openshift-ansible
openshift-ansible-3.10.51-1.git.0.44a646c.el7.noarch

$ rpm -q ansible
ansible-2.4.6.0-1.el7ae.noarch

$ ansible --version
ansible 2.4.6.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/cloud-user/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Feb 20 2018, 09:19:12) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]

How reproducible: always

Steps to Reproduce:
1. Install OSP 13
2. Install OCP 3.10.51-1 with openshift-ansible playbooks
3. Uninstall OCP:
     ansible-playbook --user openshift -i "/usr/share/ansible/openshift-ansible/playbooks/openstack/inventory.py" -i inventory "/usr/share/ansible/openshift-ansible/playbooks/openstack/openshift-cluster/uninstall.yml"

Actual results:

TASK [rhel_unsubscribe : Remove RedHat subscriptions] *************************************************************************************************************************************************************
fatal: [master-0.openshift.example.com]: FAILED! => {"failed": true, "msg": "The conditional check 'ansible_distribution == \"RedHat\" - (rhsub_user is defined and rhsub_pass is defined) or (rhsub_ak is defined
and rhsub_orgid is defined)' failed. The error was: Unexpected templating type error occurred on ({% if ansible_distribution == \"RedHat\" - (rhsub_user is defined and rhsub_pass is defined) or (rhsub_ak is defi
ned and rhsub_orgid is defined) %} True {% else %} False {% endif %}): unsupported operand type(s) for -: 'str' and 'bool'\n\nThe error appears to have been in '/usr/share/ansible/openshift-ansible/roles/rhel_un
subscribe/tasks/main.yml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n---\n- name: Remove RedHat subscriptions\n  ^ here\n"
}
fatal: [app-node-0.openshift.example.com]: FAILED! => {"failed": true, "msg": "The conditional check 'ansible_distribution == \"RedHat\" - (rhsub_user is defined and rhsub_pass is defined) or (rhsub_ak is define
d and rhsub_orgid is defined)' failed. The error was: Unexpected templating type error occurred on ({% if ansible_distribution == \"RedHat\" - (rhsub_user is defined and rhsub_pass is defined) or (rhsub_ak is de
fined and rhsub_orgid is defined) %} True {% else %} False {% endif %}): unsupported operand type(s) for -: 'str' and 'bool'\n\nThe error appears to have been in '/usr/share/ansible/openshift-ansible/roles/rhel_
unsubscribe/tasks/main.yml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n---\n- name: Remove RedHat subscriptions\n  ^ here\
n"}
fatal: [app-node-1.openshift.example.com]: FAILED! => {"failed": true, "msg": "The conditional check 'ansible_distribution == \"RedHat\" - (rhsub_user is defined and rhsub_pass is defined) or (rhsub_ak is define
d and rhsub_orgid is defined)' failed. The error was: Unexpected templating type error occurred on ({% if ansible_distribution == \"RedHat\" - (rhsub_user is defined and rhsub_pass is defined) or (rhsub_ak is de
fined and rhsub_orgid is defined) %} True {% else %} False {% endif %}): unsupported operand type(s) for -: 'str' and 'bool'\n\nThe error appears to have been in '/usr/share/ansible/openshift-ansible/roles/rhel_
unsubscribe/tasks/main.yml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n---\n- name: Remove RedHat subscriptions\n  ^ here\
n"}
fatal: [infra-node-0.openshift.example.com]: FAILED! => {"failed": true, "msg": "The conditional check 'ansible_distribution == \"RedHat\" - (rhsub_user is defined and rhsub_pass is defined) or (rhsub_ak is defi
ned and rhsub_orgid is defined)' failed. The error was: Unexpected templating type error occurred on ({% if ansible_distribution == \"RedHat\" - (rhsub_user is defined and rhsub_pass is defined) or (rhsub_ak is
defined and rhsub_orgid is defined) %} True {% else %} False {% endif %}): unsupported operand type(s) for -: 'str' and 'bool'\n\nThe error appears to have been in '/usr/share/ansible/openshift-ansible/roles/rhe
l_unsubscribe/tasks/main.yml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n---\n- name: Remove RedHat subscriptions\n  ^ her
e\n"}

PLAY RECAP ********************************************************************************************************************************************************************************************************
app-node-0.openshift.example.com : ok=1    changed=0    unreachable=0    failed=1
app-node-1.openshift.example.com : ok=1    changed=0    unreachable=0    failed=1
infra-node-0.openshift.example.com : ok=1    changed=0    unreachable=0    failed=1
localhost                  : ok=11   changed=0    unreachable=0    failed=0
master-0.openshift.example.com : ok=1    changed=0    unreachable=0    failed=1


Expected results: Successful uninstall