Bug 1633586 - hooks/before_device_create/50_openstacknet fails
Summary: hooks/before_device_create/50_openstacknet fails
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: Core
Version: 4.20.31
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ovirt-4.2.7
: ---
Assignee: Dominik Holler
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On:
Blocks: 1598391
TreeView+ depends on / blocked
 
Reported: 2018-09-27 10:29 UTC by Dominik Holler
Modified: 2018-11-09 12:05 UTC (History)
4 users (show)

Fixed In Version: vdsm-4.20.41
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-11-09 12:05:49 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.2+
mburman: testing_plan_complete-
dholler: devel_ack+
mburman: testing_ack+


Attachments (Terms of Use)
relevant part of vdsm.log (2.90 KB, text/plain)
2018-09-27 10:29 UTC, Dominik Holler
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 94560 0 master MERGED vm: fix custom dict on calling before_device_create 2018-09-27 14:29:14 UTC
oVirt gerrit 94606 0 ovirt-4.2 MERGED vm: fix custom dict on calling before_device_create 2018-10-02 07:50:38 UTC

Description Dominik Holler 2018-09-27 10:29:52 UTC
Created attachment 1487722 [details]
relevant part of vdsm.log

Description of problem:
Booting a VM connected to an OpenStack network fails with:
VM fedora0 is down with error. Exit message: Hook Error: ('openstacknet hook: [unexpected error]: Traceback (most recent call last):\n  File "/usr/libexec/vdsm/hooks/before_device_create/50_openstacknet", line 168, in <module>\n    main()\n  File "/usr/libexec/vdsm/hooks/before_device_create/50_openstacknet", line 113, in main\n    sys.stderr.write(\'Adding vNIC %s to VM %s \' % (vNicId, os.environ.get(VM_ID_KEY,\'Missing\')))\nUnboundLocalError: local variable \'vNicId\' referenced before assignment\n\n\n',).

Version-Release number of selected component (if applicable):
vdsm-4.20.39

How reproducible:


Steps to Reproduce:
1. Boot VM connected to OpenStack network
2.
3.

Actual results:
Fails with error message above

Expected results:
VM boots and vNIC is working

Additional info:

Comment 1 Raz Tamir 2018-10-13 09:58:55 UTC
Hi Dominik,

Please add 'priority' to the bug.

Comment 2 Dominik Holler 2018-10-13 18:07:39 UTC
priority inherited from 1598391

Comment 3 Michael Burman 2018-10-24 13:26:05 UTC
We can't test this for 4.2.7, we are blocked on HW issues.
Moving to 4.2.8 as this is not a blocker.

Comment 4 Michael Burman 2018-11-08 11:10:56 UTC
Verified on - 4.2.7.4-0.1.el7ev and vdsm-4.20.43-1.el7ev.x86_64
vdsm-hook-openstacknet-4.20.43-1.el7ev.noarch
Red Hat OpenStack Platform release 13.0 (Queens)

Comment 5 Dominik Holler 2018-11-09 12:05:49 UTC
This bugzilla is included in oVirt 4.2.7 release, published on November 2nd
2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.7 release, it has been closed with a resolution of
CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.