Bug 1633979 - error: 'AUDIO_GET_PTS' was not declared in this scope
Summary: error: 'AUDIO_GET_PTS' was not declared in this scope
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: kernel-headers
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Justin M. Forbes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-09-28 09:21 UTC by MartinKG
Modified: 2018-10-11 06:13 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-10-11 06:13:45 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description MartinKG 2018-09-28 09:21:58 UTC
i am trying to compile vdr-2.4.0 for Fedora 30 on the Fedora rpm build server, but this fails with the following error message [1]:

g++ -O3 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fPIC -Werror=overloaded-virtual -Wno-parentheses -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -I/builddir/build/BUILD/vdr-2.4.0/include -c -DPLUGIN_NAME_I18N='"dvbhddevice"'  -o dvbhdffdevice.o dvbhdffdevice.c
make: Leaving directory '/builddir/build/BUILD/vdr-2.4.0/PLUGINS/src/dvbhddevice'
dvbhdffdevice.c: In member function 'virtual int64_t cDvbHdFfDevice::GetSTC()':
dvbhdffdevice.c:569:33: error: 'AUDIO_GET_PTS' was not declared in this scope
             if (ioctl(fd_audio, AUDIO_GET_PTS, &pts) == -1) {
                                 ^~~~~~~~~~~~~
dvbhdffdevice.c:569:33: note: suggested alternative: 'VIDEO_GET_PTS'
             if (ioctl(fd_audio, AUDIO_GET_PTS, &pts) == -1) {
                                 ^~~~~~~~~~~~~
                                 VIDEO_GET_PTS
make: *** [Makefile:64: dvbhdffdevice.o] Error 1



the package [1] kernel-headers-4.19.0-0.rc5.git2.1.fc30.x86_64.rpm contains the file /usr/include/linux/dvb/audio.h,
but the definition

#define AUDIO_GET_PTS              _IOR('o', 19, __u64)

is missing, fedora29 contain it.

[1] https://kojipkgs.fedoraproject.org//packages/kernel-headers/4.19.0/0.rc5.git2.1.fc30/x86_64/kernel-headers-4.19.0-0.rc5.git2.1.fc30.x86_64.rpm

Comment 1 MartinKG 2018-09-28 10:53:21 UTC
why is this a unused API [1] if it's used by vdr ?

[1] https://github.com/torvalds/linux/commit/d21c249b26311dd193b100e65fc9e7ae96233d40#diff-56193b27b16cac28881a16f295c6ff3cL133

Comment 2 MartinKG 2018-09-28 14:34:17 UTC
caused by a patch by
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung>
[2/3] media: dvb/audio.h: get rid of unused APIs
https://patchwork.kernel.org/patch/10439203/

Comment 3 MartinKG 2018-10-04 12:43:10 UTC
There is a discussion on the VDR user forum:
https://www.linuxtv.org/pipermail/vdr/2018-September/029428.html

Comment 4 MartinKG 2018-10-11 06:13:45 UTC
issue of vdr-plugin-dvbhddevice and not core VDR.


Note You need to log in before you can comment on or make changes to this bug.