Bug 1634461 - livecd-creator fails because it doesn't like repo defs anymore
Summary: livecd-creator fails because it doesn't like repo defs anymore
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: livecd-tools
Version: 29
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-10-01 01:11 UTC by Scott Dowdle
Modified: 2018-10-02 19:33 UTC (History)
9 users (show)

Fixed In Version: livecd-tools-25.0-11.fc29
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-10-02 19:33:37 UTC
Type: Bug


Attachments (Terms of Use)

Description Scott Dowdle 2018-10-01 01:11:48 UTC
I've been remixing Fedora for a while... and just noticed in Fedora 29 pre-release (after remixing it for weeks now) that it gives me the following error:

- - - - -
Traceback (most recent call last):
  File "/usr/bin/livecd-creator", line 246, in <module>
    sys.exit(main())
  File "/usr/bin/livecd-creator", line 222, in main
    creator.install()
  File "/usr/lib/python3.7/site-packages/imgcreate/creator.py", line 702, in install
    yr = dbo.addRepository(name, baseurl, mirrorlist)
  File "/usr/lib/python3.7/site-packages/imgcreate/dnfinst.py", line 185, in addRepository
    repo.baseurl = repo.baseurl + [_varSubstitute(url)]
TypeError: can only concatenate tuple (not "list") to tuple
- - - - -

Here's what my repo def looks like in my kickstart:
repo --name=fedora --baseurl=http://192.168.1.4/fedora/development/29/Everything/x86_64/os/
repo --name=updates-testing --baseurl=http://192.168.1.4/fedora/updates/testing/29/x86_64/

The URLs are functional and nothing has changed there.  I'm guessing something in imgcreate or some other related python library has changed?!?

Comment 1 Neal Gompa 2018-10-01 04:09:42 UTC
Arrgh! I thought this was fixed already by Adam Williamson...?

Looks like there was a further fix for this that was built for F30, but not F29: https://src.fedoraproject.org/rpms/livecd-tools/c/97d11f5bb9287fdf24a9671d7af5f4f304735224

😩

Comment 2 Fedora Update System 2018-10-01 04:23:28 UTC
livecd-tools-25.0-11.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-adef81d948

Comment 3 Adam Williamson 2018-10-01 05:54:42 UTC
Oh, god, this is a mess. Someone submitted an update for dnf, which they absolutely should not have done, and now we have two separate updates with the dnf that breaks this and the livecd-tools that adapts to it, and no updates at all for the other things that need updating in order for the new dnf not to break composes.

I do not know why pwalter thought it'd be a great idea to send out an incomplete update without apparently checking with dmach or me or bcl or the anaconda team or...anyone...

I was waiting for a Rawhide compose to actually complete and run through testing before we should decide whether we should send this to F29 yet, and if so, we would have created a *complete* update with the dnf builds *and* the builds for other packages to adapt to changes in the dnf builds. But now it's all messed up.

It's very late on a Sunday evening here, I will try and get some people together to unpick this mess tomorrow. For now I have unpushed the incomplete DNF update.

Comment 4 Fedora Update System 2018-10-01 21:59:11 UTC
livecd-tools-25.0-11.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-adef81d948

Comment 5 Fedora Update System 2018-10-02 19:33:37 UTC
livecd-tools-25.0-11.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.