Bug 1634602 - cryptlib: Remove (sub)packages from Fedora 30+: cryptlib-python2
Summary: cryptlib: Remove (sub)packages from Fedora 30+: cryptlib-python2
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: cryptlib
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ralf Senderek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PY2REMOVAL
TreeView+ depends on / blocked
 
Reported: 2018-10-01 08:59 UTC by Miro Hrončok
Modified: 2018-10-04 15:42 UTC (History)
7 users (show)

Fixed In Version: cryptlib-3.4.4-11.fc30
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-10-04 05:06:34 UTC
Type: ---


Attachments (Terms of Use)

Description Miro Hrončok 2018-10-01 08:59:12 UTC
In line with the Mass Python 2 Package Removal [0], the following (sub)packages of cryptlib were marked for removal:

 * cryptlib-python2

According to our query, those (sub)packages only provide a Python 2 importable module. If this is not true, please tell us why, so we can fix our query.

Please remove them from your package.

As said in the change document, if there is no objection in a week, we will remove the package(s) as soon as we get to it. This change might not match your packaging style, so we'd prefer if you did the change. If you need more time, please let us know here.

We hope this doesn't come to you as a surprise. If you want to know our motivation for this, please read the change document [0].

[0] https://fedoraproject.org/wiki/Changes/Mass_Python_2_Package_Removal

Comment 1 Ralf Senderek 2018-10-04 05:06:34 UTC
The python2 module is now removed.
Python2 is still required to build the package.

Comment 2 Miro Hrončok 2018-10-04 08:20:05 UTC
Thanks for the update.

Please, stop adding the spec file to the lookaside cache. It is very confusing when the specfile immediately replaces itself with the older version.

Also, you don't need python2-devel anymore.

I wanted to send you a pull request, but pagure just says "waiting" all the time, so here are two commits on github:

https://github.com/hroncok/cryptlib-spec/commit/d44b74ae55d77ef439c4a1250b2f1c679b19a458

https://github.com/hroncok/cryptlib-spec/commit/c53213e4ca3f2d77a238ca53eb7f92beb0891f66

Comment 3 Ralf Senderek 2018-10-04 13:48:28 UTC
(In reply to Miro Hrončok from comment #2)

> Also, you don't need python2-devel anymore.

Actually I do need python2-devel. Have a look at the source code.
If I didn't I'd had it removed by now.

Comment 4 Miro Hrončok 2018-10-04 14:31:14 UTC
I've looked at the source code and I don't understand why python2-devel is needed (I understand why python2 is needed).

Comment 5 Miro Hrončok 2018-10-04 14:50:17 UTC
Here's the PR: https://src.fedoraproject.org/rpms/cryptlib/pull-request/2

Comment 6 Ralf Senderek 2018-10-04 15:36:21 UTC
(In reply to Miro Hrončok from comment #4)
> I've looked at the source code and I don't understand why python2-devel is
> needed (I understand why python2 is needed).

OK, I will test it with python2-devel removed on rawhide and if it is
obsolete, I'll remove that too, BUT porting the python2 scripts will take 
some time, it's on the to-do list.  I always go for minimal changes to 
the original source code. And if I change anything, I'd seek approval
from Peter Gutmann before heading to build something new.

Comment 7 Miro Hrončok 2018-10-04 15:42:01 UTC
The code in the above pull request builds fine.

Porting the script upstream to python3 would indeed be great.


Note You need to log in before you can comment on or make changes to this bug.