RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1634775 - libvirt creating qemu channels with the wrong permissions
Summary: libvirt creating qemu channels with the wrong permissions
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: libvirt
Version: 8.0
Hardware: All
OS: Linux
high
high
Target Milestone: rc
: 8.0
Assignee: Ján Tomko
QA Contact: jiyan
URL:
Whiteboard:
Depends On: 1633389
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-10-01 15:17 UTC by Ján Tomko
Modified: 2022-12-22 22:45 UTC (History)
3 users (show)

Fixed In Version: libvirt-4.5.0-10.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1633389
Environment:
Last Closed: 2019-06-14 01:31:35 UTC
Type: Bug
Target Upstream Version:
Embargoed:
pm-rhel: mirror+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-21095 0 None None None 2022-12-22 22:45:44 UTC

Description Ján Tomko 2018-10-01 15:17:34 UTC 
+++ This bug was initially created as a clone of Bug #1633389 +++

Description of problem:

The latest versions of qemu-kvm-rhev and libvirt create channels in /var/lib/libvirt/qemu/channel which are owned by root:root instead of qemu:qemu, and these are not readable by guests.

How reproducible:
100%

Steps to Reproduce:
1. Install libvirt-4.5.0-10.el7 and qemu-kvm-rhev-2.12.0-18.
2. Start a guest
3. Create a channel, such as:
    <channel type='unix'>
      <source mode='bind'
path='/var/lib/libvirt/qemu/channels/14182ea9-c01f-428d-ac67-5a7e2639c931.com.redhat.rhevm.vdsm'/>
      <target type='virtio' name='com.redhat.rhevm.vdsm'
state='disconnected'/>
      <alias name='channel0'/>
      <address type='virtio-serial' controller='0' bus='0' port='1'/>
    </channel>

Actual results:
permissions are incorrect

Expected results:
Permissions are qemu:qemu

Additional info:

--- Additional comment from Ján Tomko on 2018-09-27 17:03:12 CEST ---

Proposed upstream patch:
https://www.redhat.com/archives/libvir-list/2018-September/msg01400.html
Comment 1 Ján Tomko 2018-10-02 11:05:19 UTC 
Fixed upstream by:
commit d6b8838dd83697f721fe0706068df765148154de
Author:     Ján Tomko <jtomko>
CommitDate: 2018-10-02 12:44:44 +0200

    security: dac: also label listen UNIX sockets
    
    We switched to opening mode='bind' sockets ourselves:
    commit 30fb2276d88b275dc2aad6ddd28c100d944b59a5
        qemu: support passing pre-opened UNIX socket listen FD
    in v4.5.0-rc1~251
    
    Then fixed qemuBuildChrChardevStr to change libvirtd's label
    while creating the socket:
    commit b0c6300fc42bbc3e5eb0b236392f7344581c5810
        qemu: ensure FDs passed to QEMU for chardevs have correct SELinux labels
    v4.5.0-rc1~52
    
    Also add labeling of these sockets to the DAC driver.
    Instead of duplicating the logic which decides whether libvirt should
    pre-create the socket, assume an existing path meaning that it was created
    by libvirt.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1633389
    
    Signed-off-by: Ján Tomko <jtomko>
    Reviewed-by: Erik Skultety <eskultet>

git describe: v4.8.0-19-gd6b8838dd8
Comment 5 jiyan 2018-10-12 06:12:25 UTC 
# rpm -qa libvirt qemu-kvm-rhev kernel
libvirt-4.5.0-10.el8+1962+60f3e94c.x86_64
qemu-kvm-2.12.0-33.el8+1962+60f3e94c.x86_64
kernel-4.18.0-23.el8.x86_64

Steps:
1. Prepare a shutdown VM with the following configuration and then start the VM
# virsh domstate test1
shut off

# virsh dumpxml test1 |grep "<serial" -A5
    <serial type='unix'>
      <source mode='bind' path='/tmp/foo'/>
      <target type='isa-serial' port='1'>
        <model name='isa-serial'/>
      </target>
    </serial>

# virsh dumpxml test1 |grep "<channel" -A5
    <channel type='unix'>
      <target type='virtio' name='com.redhat.rhevm.vdsm'/>
      <address type='virtio-serial' controller='0' bus='0' port='1'/>
    </channel>

# virsh start test1
Domain test1 started

# virsh dumpxml test1 |grep "<serial" -A7
    <serial type='unix'>
      <source mode='bind' path='/tmp/foo'/>
      <target type='isa-serial' port='1'>
        <model name='isa-serial'/>
      </target>
      <alias name='serial0'/>
    </serial>

# virsh dumpxml test1 |grep "<channel" -A5
    <channel type='unix'>
      <source mode='bind' path='/var/lib/libvirt/qemu/channel/target/domain-6-test1/com.redhat.rhevm.vdsm'/>
      <target type='virtio' name='com.redhat.rhevm.vdsm' state='disconnected'/>
      <alias name='channel0'/>
      <address type='virtio-serial' controller='0' bus='0' port='1'/>
    </channel>

2. Check the qemu cmd line
# ps -ef |grep "test1" |sed 's/-device/\n-device/g'
-chardev socket,id=charserial0,fd=33,server,nowait 
-device isa-serial,chardev=charserial0,id=serial0 
-chardev socket,id=charchannel0,fd=34,server,nowait 
-device virtserialport,bus=virtio-serial0.0,nr=1,chardev=charchannel0,id=channel0,name=com.redhat.rhevm.vdsm

3. Check the "uid:gid" of the related files
# ll -alZ /tmp/foo
srwxrwxr-x. 1 qemu qemu system_u:object_r:tmp_t:s0 0 Oct 12 02:08 /tmp/foo

# ll -alZ /var/lib/libvirt/qemu/channel/target/domain-6-test1/com.redhat.rhevm.vdsm
srwxrwxr-x. 1 qemu qemu system_u:object_r:svirt_image_t:s0:c144,c1018 0 Oct 12 02:08 /var/lib/libvirt/qemu/channel/target/domain-6-test1/com.redhat.rhevm.vdsm
Note You need to log in before you can comment on or make changes to this bug.