Created attachment 1489102 [details] video sample Description of problem: When 2 or more hosts are selected and edited, Alert 'Abandon changes' is displayed even when no changes are made by the user. Version-Release number of selected component (if applicable): Version 5.10.0.17.20180927011235_1b5cf54 How reproducible: 100% Steps to Reproduce: 1. Have CFME appliance with added provider with some hosts 2. Go to Compute -> Infrastructure -> Hosts 3. Select 2 or more hosts and click Configuration -> Edit selected items 4. Leave the page without making any changes Actual results: Alert asking whether to abandon changes is displayed Expected results: If no changes are made, no 'Abandon changes' alert should be displayed Additional info: video sample attached
https://github.com/ManageIQ/manageiq-ui-classic/pull/5289
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/6e66bc5dd5ea2f2c1d06847cef2549f1af8a9fb8 commit 6e66bc5dd5ea2f2c1d06847cef2549f1af8a9fb8 Author: Richard Vsiansky <r.vsia> AuthorDate: Thu Feb 28 06:27:32 2019 -0500 Commit: Richard Vsiansky <r.vsia> CommitDate: Thu Feb 28 06:27:32 2019 -0500 Fixes value of validation_id in host form https://bugzilla.redhat.com/show_bug.cgi?id=1634794 * validation_id was null in template and blank in controller * => changed to null everywhere * it causes dirty state on the form (because the model and the copy was different) app/assets/javascripts/controllers/host/host_form_controller.js | 4 +- app/views/layouts/angular/_multi_auth_credentials.html.haml | 2 +- spec/javascripts/controllers/host/host_form_controller_spec.js | 11 +- 3 files changed, 13 insertions(+), 4 deletions(-)
Justin, I think it should be OK. The prompt should be displayed only when you change something in the form and click on link in the menu or breadcrumbs. The menu part looks OK, however breadcrumbs do not support this yet. So, I propose: 1. This BZ should be closed (the form works as any other form in the application - clicking in menu shows the prompt, cancel/back do not.) 2. A new BZ should be open, something like this: 'Clicking on breadcrumbs in edited forms do not show Abandon Changes' and assign me to it. It is a global issue, not connected only to this form. Do you agree? Richard
Justin, that is a correct behavior. See ""Abandon changes?" pop should not be displayed, if user presses cancel button" Richard
Verified in 5.11.0.11.20190625161125_392c61e
This BZ is now covered by test_infrastructure_hosts_crud in integration_tests.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:4199