Bug 1634819 - Re-Review Request: python2-prompt-toolkit - Library for building powerful interactive command lines in Python
Summary: Re-Review Request: python2-prompt-toolkit - Library for building powerful int...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-10-01 17:22 UTC by Carl George
Modified: 2018-10-02 15:12 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-10-02 15:12:38 UTC
Type: ---
Embargoed:
mhroncok: fedora-review+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1475812 0 unspecified CLOSED python-prompt_toolkit-2.0.4 is available 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1634091 0 medium CLOSED Re-Review Request: python-prompt-toolkit - Library for building powerful interactive command lines in Python 2021-02-22 00:41:40 UTC

Internal Links: 1475812 1634091

Description Carl George 2018-10-01 17:22:12 UTC
Spec URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/python-prompt-toolkit/fedora-rawhide-x86_64/00804816-python2-prompt-toolkit/python2-prompt-toolkit.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/python-prompt-toolkit/fedora-rawhide-x86_64/00804816-python2-prompt-toolkit/python2-prompt-toolkit-1.0.15-3.fc30.src.rpm

Description:
prompt_toolkit is a library for building powerful interactive command lines and
terminal applications in Python.

Fedora Account System Username: carlwgeorge


This is a re-review of python-prompt_toolkit.  I am trying to do a backwards-incompatible update (1.x.x to 2.x.x) for prompt_toolkit in rawhide, and the plan is to only do it for the python3 package, splitting out the python2 package.  Several packages require python2-prompt_toolkit 1.x.x and the upstreams do not yet support 2.x.x.

I'm also going to rename from python2-prompt_toolkit to python2-prompt-toolkit (underscore to dash) for consistency.

Comment 1 Miro Hrončok 2018-10-01 18:36:38 UTC
Package APPROVED.

Consider adding two comments in the specfile:


  # WARNING: Do not update this to 2.x until all dependencies are OK
  # The python3 version in python-%%{pkgname} has the 2.x version
  Name:           python2-%{pkgname}
  Version:        1.0.15

And:

  # renamed from python2-prompt_toolkit
  # remove this before Fedora 33
  Obsoletes:      python2-prompt_toolkit < 1.0.15-3
  Provides:       python2-prompt_toolkit = %{version}-%{release}


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD 3-clause "New" or "Revised" License", "Unknown or
     generated". 161 files have unknown license.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/python2.7/site-
     packages/prompt_toolkit-1.0.15-py2.7.egg-info(python2-prompt_toolkit),
     ...
     This is a rename of python2-prompt_toolkit.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
     This is a rename of python2-prompt_toolkit (it obsoletes it)
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 61440 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
     This is a rename of python2-prompt_toolkit.
     A legitimate reason to package for python2.
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[-]: Latest version is packaged.
     Not applicable here.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python2-prompt-toolkit-1.0.15-3.fc30.noarch.rpm
          python2-prompt-toolkit-1.0.15-3.fc30.src.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
python2-prompt-toolkit.noarch: W: invalid-url URL: https://github.com/jonathanslenders/python-prompt-toolkit <urlopen error [Errno -2] Name or service not known>
1 packages and 0 specfiles checked; 0 errors, 1 warnings.



Requires
--------
python2-prompt-toolkit (rpmlib, GLIBC filtered):
    python(abi)
    python2-six
    python2-wcwidth



Provides
--------
python2-prompt-toolkit:
    python-prompt-toolkit
    python2-prompt-toolkit
    python2-prompt_toolkit
    python2.7dist(prompt-toolkit)
    python2dist(prompt-toolkit)



Source checksums
----------------
https://files.pythonhosted.org/packages/source/p/prompt_toolkit/prompt_toolkit-1.0.15.tar.gz :
  CHECKSUM(SHA256) this package     : 858588f1983ca497f1cf4ffde01d978a3ea02b01c8a26a8bbc5cd2e66d816917
  CHECKSUM(SHA256) upstream package : 858588f1983ca497f1cf4ffde01d978a3ea02b01c8a26a8bbc5cd2e66d816917

Comment 2 Jason Tibbitts 2018-10-02 14:57:05 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python2-prompt-toolkit


Note You need to log in before you can comment on or make changes to this bug.