- Group: is not used in Fedora

 - This is not used since F28

%post -p /sbin/ldconfig

%postun -p /sbin/ldconfig

 If you plan to package for F27 or EPEL, use %ldconfig_scriptlets. See https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets

 - In order to avoid unintentional SONAME bump, globbing the malor soname version is forbidden, be more specific instead:

%{_libdir}/libmongoclient.so.1*

 - The license file must be installed with %license, not %doc

%doc README.md
%license APACHE-2.0.txt

 - Have you tried to unbundle third_party, especially gtest.

 - Look at THIRD-PARTY-NOTICES: there are several included programs with various licenses: add them to the License field and install THIRD-PARTY-NOTICES in %files with %license.

 - Cleanup the commented out code if it's not needed
 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- ldconfig not called in %post and %postun for Fedora 28 and later.
  Note: /sbin/ldconfig called in mongo-cxx-driver-legacy
  See: https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file disallow_copying.h is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "FSF Unlimited License (with Retention) GPL (v2 or later)",
     "GPL (v2 or later)", "Expat License", "Unknown or generated", "BSD
     3-clause "New" or "Revised" License", "Apache License (v2.0)",
     "zlib/libpng license", "GNU General Public License (v3)", "*No
     copyright* Apache License (v2.0)", "NTP License Expat License", "FSF
     Unlimited License (with Retention)", "*No copyright* Public domain",
     "NTP License". 84 files have unknown license. Detailed output of
     licensecheck in /home/bob/packaging/review/mongo-cxx-driver-legacy
     /review-mongo-cxx-driver-legacy/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/include/mongo/stdx
     (mongo-cxx-driver-devel), /usr/include/mongo/util/mongoutils(mongo-
     cxx-driver-devel), /usr/include/mongo/util/net(mongo-cxx-driver-
     devel), /usr/include/mongo/util(mongo-cxx-driver-devel),
     /usr/include/mongo/geo(mongo-cxx-driver-devel),
     /usr/include/mongo/platform(mongo-cxx-driver-devel),
     /usr/include/mongo/client(mongo-cxx-driver-devel),
     /usr/include/mongo/bson/util(mongo-cxx-driver-devel),
     /usr/include/mongo/db(mongo-cxx-driver-devel), /usr/include/mongo/base
     (mongo-cxx-driver-devel), /usr/include/mongo/logger(mongo-cxx-driver-
     devel), /usr/include/mongo/bson(mongo-cxx-driver-devel),
     /usr/include/mongo(mongo-cxx-driver-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mongo-
     cxx-driver-legacy-debuginfo , mongo-cxx-driver-legacy-debugsource
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: mongo-cxx-driver-legacy-1.1.2-1.fc30.x86_64.rpm
          mongo-cxx-driver-legacy-devel-1.1.2-1.fc30.x86_64.rpm
          mongo-cxx-driver-legacy-debuginfo-1.1.2-1.fc30.x86_64.rpm
          mongo-cxx-driver-legacy-debugsource-1.1.2-1.fc30.x86_64.rpm
          mongo-cxx-driver-legacy-1.1.2-1.fc30.src.rpm
mongo-cxx-driver-legacy.x86_64: W: obsolete-not-provided mongo-cxx-driver
mongo-cxx-driver-legacy.x86_64: W: crypto-policy-non-compliance-openssl /usr/lib64/libmongoclient.so.1.1.2 SSL_CTX_set_cipher_list
mongo-cxx-driver-legacy-devel.x86_64: W: obsolete-not-provided mongo-cxx-driver-devel
mongo-cxx-driver-legacy-devel.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 4 warnings.

Thanks for the review.

I've changed:
- Group: and scriptlets are removed
- fixed soname glob in %files
- License: is updated and %license is used (also THIRD-PARTY-NOTICES file is installed as license)
- removed unused code
- added 'Conflicts:      mongo-cxx-driver-devel' for -devel subpackage (both use same file location)

Now I was trying to unbundle gtest, but mongo-cxx-driver-legacy don't compile with this change.
Upstream doen't support unbundling, gtest is test only dependency and other bundled libs are really small and aren't packaged in Fedora). So in this case IMHO bundling isn't big problem.

Also I've realized that newer version is available - 1.1.3 (instead of 1.1.2). So rebase to this version was done.

Spec URL: https://mskalick.fedorapeople.org/reviews/mongo-cxx-driver-legacy/mongo-cxx-driver-legacy.spec
SRPM URL: https://mskalick.fedorapeople.org/reviews/mongo-cxx-driver-legacy/mongo-cxx-driver-legacy-1.1.3-1.fc30.src.rpm

 - License:        ASL 2.0 && MIT && BSD && zlib && Public Domain

Are you sure using && is ok? Never seen it used before, usually it's "and".

Actually it doesn't work:

mongo-cxx-driver-legacy-devel.x86_64: W: invalid-license ASL 2.0 && MIT && BSD && zlib && Public Domain


 - There's still a Group:          Development/Libraries in the devel subpackage.

 - I forgot to mention something last time:

mongo-cxx-driver-legacy.x86_64: W: crypto-policy-non-compliance-openssl /usr/lib64/libmongoclient.so.1.1.3 SSL_CTX_set_cipher_list

crypto-policy-non-compliance-openssl:
This application package calls a function to explicitly set crypto ciphers for
SSL/TLS. That may cause the application not to use the system-wide set
cryptographic policy and should be modified in accordance to:
https://fedoraproject.org/wiki/Packaging:CryptoPolicies

Read the above page and take appropriate action in src/mongo/util/net/ssl_manager.cpp:585

Thanks. I've missed that. I should be fixed now.

Spec URL: https://mskalick.fedorapeople.org/reviews/mongo-cxx-driver-legacy/mongo-cxx-driver-legacy.spec
SRPM URL: https://mskalick.fedorapeople.org/reviews/mongo-cxx-driver-legacy/mongo-cxx-driver-legacy-1.1.3-2.fc30.src.rpm

All ok, package approved.

Thanks for the quick review.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/mongo-cxx-driver-legacy