Spec URL: https://eclipseo.fedorapeople.org/kvantum.spec SRPM URL: https://eclipseo.fedorapeople.org/kvantum-0.10.8-1.fc30.src.rpm Description: Kvantum is an SVG-based theme engine for Qt5, KDE and LXQt, with an emphasis on elegance, usability and practicality. Kvantum has a default dark theme, which is inspired by the default theme of Enlightenment. Creation of realistic themes like that for KDE was the first reason to make Kvantum but it goes far beyond its default theme: you could make themes with very different looks and feels for it, whether they be photorealistic or cartoonish, 3D or flat, embellished or minimalistic, or something in between, and Kvantum will let you control almost every aspect of Qt widgets. Kvantum also comes with extra themes that are installed as root with Qt5 installation and can be selected and activated by using Kvantum Manager. Fedora Account System Username: eclipseo
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= 1. /usr/share/color-schemes is not owned by this package, nor by any package that it Requires. 2. Can the files under /usr/share/Kvantum go into a noarch subpackage? That is, can the arch-specific package contain only %{_bindir}/kvantum* and %{_libdir}/qt5/plugins/styles/libkvantum.so? 3. I'm not sure if that desktop file should be changed to use X-LXQt instead of LXQt. It might be good to query somebody who can say definitively. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/color-schemes [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4587520 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: kvantum-0.10.8-1.fc30.x86_64.rpm kvantum-debuginfo-0.10.8-1.fc30.x86_64.rpm kvantum-debugsource-0.10.8-1.fc30.x86_64.rpm kvantum-0.10.8-1.fc30.src.rpm kvantum.x86_64: W: spelling-error %description -l en_US photorealistic -> photo realistic, photo-realistic, prehistorical kvantum.x86_64: W: spelling-error %description -l en_US cartoonish -> cartoonist, cartoon kvantum.x86_64: W: spelling-error %description -l en_US minimalistic -> minimalist, minimalism, animistic kvantum.x86_64: W: no-manual-page-for-binary kvantummanager kvantum.x86_64: W: no-manual-page-for-binary kvantumpreview kvantum.x86_64: E: invalid-desktopfile /usr/share/applications/kvantummanager.desktop value "Qt;Utility;Settings;DesktopSettings;LXQt;X-XFCE-SettingsDialog;X-XFCE-PersonalSettings;X-GNOME-PersonalSettings;" for key "Categories" in group "Desktop Entry" contains an unregistered value "LXQt"; values extending the format should start with "X-" kvantum.src: W: spelling-error %description -l en_US photorealistic -> photo realistic, photo-realistic, prehistorical kvantum.src: W: spelling-error %description -l en_US cartoonish -> cartoonist, cartoon kvantum.src: W: spelling-error %description -l en_US minimalistic -> minimalist, minimalism, animistic 4 packages and 0 specfiles checked; 1 errors, 8 warnings. Rpmlint (debuginfo) ------------------- Checking: kvantum-debuginfo-0.10.8-1.fc30.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory kvantum.x86_64: W: spelling-error %description -l en_US photorealistic -> photo realistic, photo-realistic, prehistorical kvantum.x86_64: W: spelling-error %description -l en_US cartoonish -> cartoonist, cartoon kvantum.x86_64: W: spelling-error %description -l en_US minimalistic -> minimalist, minimalism, animistic kvantum.x86_64: W: invalid-url URL: https://github.com/tsujan/Kvantum <urlopen error [Errno -2] Name or service not known> kvantum.x86_64: W: no-manual-page-for-binary kvantummanager kvantum.x86_64: W: no-manual-page-for-binary kvantumpreview kvantum.x86_64: E: invalid-desktopfile /usr/share/applications/kvantummanager.desktop value "Qt;Utility;Settings;DesktopSettings;LXQt;X-XFCE-SettingsDialog;X-XFCE-PersonalSettings;X-GNOME-PersonalSettings;" for key "Categories" in group "Desktop Entry" contains an unregistered value "LXQt"; values extending the format should start with "X-" kvantum-debugsource.x86_64: W: invalid-url URL: https://github.com/tsujan/Kvantum <urlopen error [Errno -2] Name or service not known> kvantum-debuginfo.x86_64: W: invalid-url URL: https://github.com/tsujan/Kvantum <urlopen error [Errno -2] Name or service not known> 3 packages and 0 specfiles checked; 1 errors, 8 warnings. Requires -------- kvantum (rpmlib, GLIBC filtered): hicolor-icon-theme kde-filesystem libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.11)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Svg.so.5()(64bit) libQt5Svg.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libQt5X11Extras.so.5()(64bit) libQt5X11Extras.so.5(Qt_5)(64bit) libX11.so.6()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) kvantum-debugsource (rpmlib, GLIBC filtered): kvantum-debuginfo (rpmlib, GLIBC filtered): Provides -------- kvantum: application() application(kvantummanager.desktop) kvantum kvantum(x86-64) libkvantum.so()(64bit) kvantum-debugsource: kvantum-debugsource kvantum-debugsource(x86-64) kvantum-debuginfo: debuginfo(build-id) kvantum-debuginfo kvantum-debuginfo(x86-64) Unversioned so-files -------------------- kvantum: /usr/lib64/qt5/plugins/styles/libkvantum.so Source checksums ---------------- https://github.com/tsujan/Kvantum/archive/V0.10.8/kvantum-0.10.8.tar.gz : CHECKSUM(SHA256) this package : a169a19a05985124a946ae638bee2729adad1544497693d911bb7d15160fd20c CHECKSUM(SHA256) upstream package : a169a19a05985124a946ae638bee2729adad1544497693d911bb7d15160fd20c Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1635415 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Thanks for the review! 1. /usr/share/color-schemes is not owned by this package, nor by any package that it Requires. Now owned by Plasma desktop 2. Can the files under /usr/share/Kvantum go into a noarch subpackage? That is, can the arch-specific package contain only %{_bindir}/kvantum* and %{_libdir}/qt5/plugins/styles/libkvantum.so? Split into a data subpackage. 3. I'm not sure if that desktop file should be changed to use X-LXQt instead of LXQt. It might be good to query somebody who can say definitively. Patched into X-LXQt. Spec URL: https://eclipseo.fedorapeople.org/kvantum.spec SRPM URL: https://eclipseo.fedorapeople.org/kvantum-0.10.8-1.fc30.src.rpm
Looks good. This package is APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/kvantum
kvantum-0.10.8-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-c7c891d832
kvantum-0.10.8-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-0a209e5905
kvantum-0.10.8-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-874975a9ba
kvantum-0.10.8-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-874975a9ba
kvantum-0.10.8-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-c7c891d832
kvantum-0.10.8-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-0a209e5905
kvantum-0.10.8-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
kvantum-0.10.8-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
kvantum-0.10.8-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.