Bug 1635809 - [osp14] config download tarball getting added to git repo
Summary: [osp14] config download tarball getting added to git repo
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-tripleo-common
Version: 14.0 (Rocky)
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: beta
: 14.0 (Rocky)
Assignee: James Slagle
QA Contact: Gurenko Alex
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-10-03 17:48 UTC by James Slagle
Modified: 2019-01-11 11:53 UTC (History)
2 users (show)

Fixed In Version: openstack-tripleo-common-9.3.1-0.20180923215327.d22cb3e.el7ost
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-01-11 11:53:35 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1795949 0 None None None 2018-10-03 17:49:45 UTC
OpenStack gerrit 607701 0 None MERGED Don't add tarball to config-download dir 2020-12-10 14:37:43 UTC
Red Hat Product Errata RHEA-2019:0045 0 None None None 2019-01-11 11:53:44 UTC

Description James Slagle 2018-10-03 17:48:06 UTC
The tarball of the config-download output that we put into the overcloud-config container is getting added to the git repo we create for the config-download contents.

We have code to add *.tar.gz to .gitignore, however when we use GitPython and run repo.index.add, this defaults to using force=True which the equivalent of git add -f, which adds even ignored files to the index.

The docs at
https://gitpython.readthedocs.io/en/stable/reference.html#git.index.base.IndexFile.add

actually say that the force keyword argument doesn't currently work.

So as a workaround we'll need to use the GitCmd interface to run a git command directly.

Comment 4 Gurenko Alex 2018-12-17 12:49:52 UTC
Verified on puddle 2018-12-14.1

openstack-tripleo-common-9.4.1-0.20181012010884.el7ost.noarch

Comment 6 errata-xmlrpc 2019-01-11 11:53:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2019:0045


Note You need to log in before you can comment on or make changes to this bug.