Bug 1636612 - IVS is not restarted on firstboot, after updating config file
Summary: IVS is not restarted on firstboot, after updating config file
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: os-net-config
Version: 14.0 (Rocky)
Hardware: Unspecified
OS: Unspecified
medium
high
Target Milestone: beta
: 14.0 (Rocky)
Assignee: Bob Fournier
QA Contact: mlammon
URL:
Whiteboard:
Depends On: 1632417
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-10-05 20:37 UTC by Bob Fournier
Modified: 2019-01-11 11:53 UTC (History)
7 users (show)

Fixed In Version: os-net-config-9.2.1-0.20181008041835.bedb54a.el7ost
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1632417
Environment:
Last Closed: 2019-01-11 11:53:41 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1794182 0 None None None 2018-10-05 20:37:35 UTC
OpenStack gerrit 605668 0 None None None 2018-10-05 20:37:35 UTC
Red Hat Product Errata RHEA-2019:0045 0 None None None 2019-01-11 11:53:48 UTC

Description Bob Fournier 2018-10-05 20:37:35 UTC
+++ This bug was initially created as a clone of Bug #1632417 +++

Description of problem:
os-net-config writes the config file for IVS, but does not restart IVS.
this causes IVS to not recognize the updated list of interfaces that are active uplinks.

I believe there was a restart, which was removed as part of the fix for BZ #1549456 [1].
The restart needs to be a little more smart - to decide when a restart is required vs not required.

Ideally, if we can read the config before we write to it and compare to see if there is a change - set a boolean flag to say if there was a config change and restart IVS when that is true.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1549456
Version-Release number of selected component (if applicable):
os-net-config-8.4.1-4.el7ost.noarch

How reproducible:
100%

Steps to Reproduce:
1. Deploy RHOSP 13 
2. Check logs for IVS using journalctl -u ivs : it will have IVS running without any info about the updated config file
3. Restart IVS and it prints info about newly detected interface config and correctly sends out LLDP on the interfaces

Actual results:
After updating the config file for IVS at /etc/sysconfig/ivs, os-net-config does not restart IVS

Expected results:
After updating the config file for IVS at /etc/sysconfig/ivs, os-net-config should restart IVS, if there is a change from the previous config

Additional info:
The reported bug is for Queens release, but since the patch for the above mentioned BZ [1] is merged in Ocata/Pike/Queens/master - it will need to be fixed in all those branches too.

Comment 5 errata-xmlrpc 2019-01-11 11:53:41 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2019:0045


Note You need to log in before you can comment on or make changes to this bug.