Spec URL: https://drive.google.com/open?id=1s6GYGERLQ5B1l2GBBfxFgT53bb5NP_00 SRPM URL: https://drive.google.com/open?id=1owfZPS-a637PMgCqxhdvb9Zn45SwBmhh Description: A reference implementation of the Russian GOST crypto algorithms for OpenSSL Fedora Account System Username: beldmit This is my 1st package in Fedora so I need a sponsor. I'm the maintainer of this project on GitHub (https://github.com/gost-engine/engine) and plan to maintain it in Fedora. If I understand correctly, Tomas Mraz agreed to become such a sponsor. The build has succeeded for all the architectures (https://koji.fedoraproject.org/koji/taskinfo?taskID=30097330)
I ran a fedora-review on rawhide against the files provided by Dmitry: This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. - Header files in -devel subpackage, if present. Note: openssl-gost-engine-debugsource : /usr/src/debug/openssl-gost- engine-1.1.0.3.git3383ad1-1.x86_64/e_gost_err.h openssl-gost-engine- debugsource : /usr/src/debug/openssl-gost- engine-1.1.0.3.git3383ad1-1.x86_64/gost89.h openssl-gost-engine- debugsource : /usr/src/debug/openssl-gost- engine-1.1.0.3.git3383ad1-1.x86_64/gost_grasshopper_cipher.h openssl- gost-engine-debugsource : /usr/src/debug/openssl-gost- engine-1.1.0.3.git3383ad1-1.x86_64/gost_grasshopper_core.h openssl-gost- engine-debugsource : /usr/src/debug/openssl-gost- engine-1.1.0.3.git3383ad1-1.x86_64/gost_grasshopper_defines.h openssl- gost-engine-debugsource : /usr/src/debug/openssl-gost- engine-1.1.0.3.git3383ad1-1.x86_64/gost_grasshopper_math.h openssl-gost- engine-debugsource : /usr/src/debug/openssl-gost- engine-1.1.0.3.git3383ad1-1.x86_64/gost_grasshopper_precompiled.h openssl-gost-engine-debugsource : /usr/src/debug/openssl-gost- engine-1.1.0.3.git3383ad1-1.x86_64/gost_keywrap.h openssl-gost-engine- debugsource : /usr/src/debug/openssl-gost- engine-1.1.0.3.git3383ad1-1.x86_64/gost_lcl.h openssl-gost-engine- debugsource : /usr/src/debug/openssl-gost- engine-1.1.0.3.git3383ad1-1.x86_64/gosthash.h openssl-gost-engine- debugsource : /usr/src/debug/openssl-gost- engine-1.1.0.3.git3383ad1-1.x86_64/gosthash2012.h openssl-gost-engine- debugsource : /usr/src/debug/openssl-gost- engine-1.1.0.3.git3383ad1-1.x86_64/gosthash2012_const.h openssl-gost- engine-debugsource : /usr/src/debug/openssl-gost- engine-1.1.0.3.git3383ad1-1.x86_64/gosthash2012_precalc.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "ISC BSD (2 clause)", "OpenSSL", "Unknown or generated". 73 files have unknown license. Detailed output of licensecheck in /home/abokovoy/src/fedora/review-openssl-gost-engine/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build-id(libmad, cups-client, efivar-libs, netcdf, librsync, qemu-block-gluster, rpm- plugin-selinux, abrt, ghc-transformers, libmediaart, libimagequant, giflib, libreoffice-graphicfilter, perl-GSSAPI, trousers, tdb-tools, libdb-utils, tracker-miners, xorg-x11-font-utils, libvirt-daemon- driver-vbox, PackageKit-command-not-found, OpenEXR-libs, assimp, libcom_err, libseccomp, qca-qt5-ossl, p11-kit, pcsc-lite-devel, libabw, libvirt-daemon-driver-storage-iscsi, libid3tag, libmodman, ghc-semigroups, cfitsio, argyllcms, parted, gnome-disk-utility, libdvdread, zstd, bluez-libs, libbs2b, kf5-kjobwidgets, libwebp, libxslt, system-config-printer-udev, python2-nss, perl-Encode, libverto-libev, ModemManager, libevdev, libgpg-error, libmaxminddb, lvm2-libs, libglvnd-glx, kf5-sonnet-core, perl-Digest-SHA, libsodium, mlt, kf5-solid, libzstd, libdazzle, xdg-desktop-portal-gtk, ghc- mmorph, perl-Encode-EUCJPASCII, symlinks, python3-simplejson, python3-crypto, libcdr, cdparanoia-libs, e2fsprogs-libs, pulseaudio- libs, ltrace, tpm2-tools, lcms2, docker-rhel-push-plugin, qemu-guest- agent, annobin, deltarpm, python2-ldap, libxcb, freexl, libyubikey, python3-pycurl, python3-brlapi, openconnect, rtkit, xcb-util-keysyms, orc, m4, python26, xsel, expat, libgphoto2, rubygem-unf_ext, tinyxml, xcb-util, gvfs-fuse, mc, udisks2-iscsi, python3-coverage, python2-wrapt, anaconda-widgets, http-parser, qt5-qtspeech, pulseaudio-utils, perl-Sub-Identify, llvm5.0-libs, libeot, ghc-hxt- regex-xmlschema, python3-sss, texlive-pdftex, perl-Ref-Util-XS, libvirt-admin, ghc-old-time, dbusmenu-qt, qca-qt5, ncurses-libs, libidn2, virt-viewer, checkpolicy, libreport-plugin-logger, gnome- color-manager, fcoe-utils, xorg-x11-xkb-utils, ibus-hangul, NetworkManager-openvpn, libxkbfile, hplip-libs, libwvstreams, ghc- binary, kf5-kglobalaccel-libs, xmlrpc-c-client, sane-backends-drivers- cameras, python3-hawkey, libwpd, enchant2, libdc1394, rubygem- eventmachine, libvirt-daemon-driver-qemu, perl-Time-HiRes, ghc- filemanip, qemu-block-ssh, libwps, gssdp, uuid, gnome-calendar, kf5-knotifications, ghc-zlib, libacl, xorg-x11-drv-ati, libSM, policycoreutils, mcelog, abrt-plugin-bodhi, libmusicbrainz5, ghc-unix, pptp, sane-backends-drivers-scanners, libebur128, libXxf86misc, foomatic, texlive-dvips, minizip, colord-gtk, ccrtp, libpath_utils, python2-genshi, libicu-devel, rpm-build, libvirt-daemon-driver- storage-sheepdog, libglvnd-gles, python3-audit, redhat-lsb-core, zerofree, freeglut, gstreamer1, bsdtar, gom, msgpack, gmime30, libtomcrypt, libzrtpcpp, ccache, sshpass, libreoffice-gtk3, libreoffice-gtk2, optipng, librtmp, cairo-gobject, gnome-screenshot, libkkc, sgpio, gutenprint, openal-soft, python2-libsemanage, ghc-SHA, qpdf-libs, linux-atm-libs, libedit, ghc-hashable, subversion-libs, atk, python3-cairo, accountsservice, ghc-containers, ghc-basement, isl, ghc-integer-logarithms, python2-qpid-proton, hfsplus-tools, ImageMagick, perl-IPC-SysV, gssproxy, mesa-libGLU, libblockdev-btrfs, libatomic_ops, gupnp-av, libmpcdec, rubygem-io-console, ghc-unordered- containers, kf5-kxmlgui, python3-iscsi-initiator-utils, tpm2-abrmd, ghc-x509, NetworkManager, libkate, liblangtag, NetworkManager-glib, aws-devel, libdatrie, glade-libs, setuptool, cdrtools-libs, perl-Text- BibTeX, libcryptui, libasan, guile, pcre-utf16, tree, python33, gvfs- goa, pipewire, python37, glusterfs-libs, gnupg, python34, libnsl2, libserf, xfsprogs, authselect, libcroco, texlive-bibtex, qt5-qtsensors, spice-server, telepathy-glib, plymouth-plugin-label, colord-libs, aalib-libs, perl-Unicode-Collate, libcddb, efivar, gpgmepp, libgcab1, libzhuyin, gvnc, perl-Unicode-LineBreak, hypervfcopyd, cronie, libexttextcat, libreport, qt5-qtquickcontrols, nettle, libcacard, elfutils, ghc-hslua-module-text, python2-cryptography, colord, libpipeline, pkcs11-helper, accountsservice-libs, python3-nss, gnome-system-monitor, findutils, cmark-lib, kf5-kwindowsystem, python2-xpyb, qt5-qtx11extras, libsss_idmap, libraw1394, quazip-qt5, fontforge, folks, linphone- mediastreamer, gnome-clocks, ghc-hxt-unicode, iptables, iproute-tc, libipa_hbac, ghc-vector, libvterm, spice-glib, cool-retro-term, woff2, ghc-pandoc, coolkey, dotconf, libXfont, PackageKit-glib, patch, sqlite-libs, lttng-ust, enchant, python2-greenlet, libXxf86dga, python2-smartcols, rhash, xdg-user-dirs-gtk, perl-Data-Dumper, libwayland-client, kf5-kio-file-widgets, pinentry-gnome3, libsmbios, libXres, mdadm, openblas-threads, gnome-calculator, python2-msgpack, device-mapper, sord, python2-librepo, libXtst, ghc-lifted-base, xapian-core-libs, udisks2-lvm2, perl-Text-Soundex, gnome-terminal, GeoIP, GraphicsMagick, libsigc++20, xmlrpc-c-client++, python2-talloc, libXrandr, newt, liba52, hplip, ghc-QuickCheck, ghc-zip-archive, qt5-qtwebsockets, crda, libical, sheepdog, qt5-qtdeclarative, vo- amrwbenc, thermald, libofa, libXfont2, libblockdev-loop, libmfx, libssh2, NetworkManager-adsl, open-vm-tools-desktop, asn1c, samba-dc- libs, xmlsec1-nss, dbusmenu-qt5, libXcursor, ghc-network-uri, iio- sensor-proxy, lua-lpeg, procps-ng, plymouth-core-libs, telnet, ghc- cryptonite, libXpm, libvirt-daemon-driver-interface, python3-libsss_nss_idmap, xorg-x11-drv-nouveau, bluez-obexd, tang, zlib, libpeas, pam_krb5, gutenprint-cups, grub2-tools-efi, avahi, libselinux, ncurses-compat-libs, libassuan, nodejs, sushi, cups- filters, iw, clutter-gtk, python3-ldb, userspace-rcu, libblockdev- utils, CPUFreqUtility, libgudev, ibus-libpinyin, setroubleshoot- server, make, python3-markupsafe, clutter-gst2, libnice, libzip, libsoup, ghc-streaming-commons, glusterfs-api, fuse, perl-Net-SSLeay, perl-Filter, cups-libs, libappstream-glib, libsepol, totem-pl-parser, gzip, autogen-libopts, qt5-linguist, keyutils, php-pdo, isomd5sum, libfdisk, libdvdnav, ghc-blaze-html, libdmx, cppunit, openssl-libs, corosynclib, jose, opencc, libreport-plugin-reportuploader, libguestfs-tools-c, gavl, python3-m2crypto, boost-chrono, libtermkey, kf5-kcoreaddons, unique, libcaca, python3-samba, keybinder3, ntfs-3g, ghc-hxt, fuse-libs, libvirt-daemon-driver-storage-zfs, xorg-x11-xauth, python2-crypto, gvfs-smb, gtkspell3, libcue, libXrender, json-glib, kf5-kglobalaccel, libX11-xcb, libfontenc, libicu, libgsf, xorg-x11 -drv-vmware, sssd-common, NetworkManager-openconnect, libgtop2, qt5 -qtwayland-devel, gcc-gfortran, tracker, wvdial, icu, protobuf-c, xerces-c, mesa-libglapi, bolt, glx-utils, libgnat, libtommath, ykpers, PackageKit, kf5-kemoticons, perl-MIME-Base64, python3-bcrypt, polkit- qt5-1, libass, ghc-connection, gstreamer1-plugins-bad, ghc-time, python3-twisted, SDL_image, libstdc++, ppp, sox, libtiger, git, perl- Compress-Raw-Bzip2, jack-audio-connection-kit, mpg123-libs, opus, tcpdump, qmltermwidget, libxklavier, traceroute, cyrus-sasl-plain, libblockdev-crypto, podofo-libs, kf5-karchive, python3-tevent, libreoffice-pdfimport, rp-pppoe, libtheora, attr, mtr, libblockdev- part, pugixml, plymouth, libcanberra-gtk3, autofs, php-json, mtdev, python2-tevent, mailx, python2-regex, systemd-udev, fftw-libs-single, ghc-stm, libXvMC, check, cheese-libs, tix, python2-pillow, ghc-unix- compat, libXmu, capstone, mrxvt, python3-zope-interface, libreoffice- impress, jasper-libs, qt5-qtxmlpatterns-devel, librbd1, rubberband, device-mapper-libs, xorg-x11-xinit, gnome-initial-setup, libffi, libGLEW, pcre-utf32, libluksmeta, diffutils, python2-ldb, chrony, openblas-openmp, time, mpfr, ghc-array, kf5-knotifyconfig, cyrus-sasl- md5, iputils, qt5-qtxmlpatterns, numactl-libs, libvirt-daemon-driver- nwfilter, btrfs-progs, libwmf-lite, tigervnc-server-minimal, gpgme, hypervvssd, xorg-x11-drv-openchrome, libmcpp, libibverbs, mpg123, gdb- headless, ghc-ghc-boot-th, dleyna-core, qemu-block-nfs, libgovirt, libqmi-utils, libmbim-utils, psacct, libvirt-daemon-driver-xen, ghc- doctemplates, lame-libs, pycryptopp, gnome-bluetooth-libs, usbredir, ghostscript, iproute, iptables-libs, cryptsetup-libs, gnome-control- center, syslinux-extlinux, python2-gpg, bind-libs, pygobject2, python2-apsw, ghostscript-x11, lua-posix, libinput, qt5-qtdeclarative- devel, libreport-cli, libpkgconf, teckit, python3-dmidecode, python2-sss, abrt-gui-libs, gegl, qt5-qtconnectivity, libosinfo, acpica-tools, wireshark-cli, acpi, corosync, qt5-qtsvg, llvm3.9-libs, libreoffice-calc, sni-qt, libqmi, gawk, dmraid-events, pcsc-lite-libs, adwaita-gtk2-theme, libbasicobjects, perl-Mozilla-LDAP, hdf5, baobab, rdma-core, libIDL, vte291, libgweather, sssd-krb5, ghc-pcre-light, nmap, ghc-regex-base, libspatialite, libgrss, libdvbpsi, httpd, libsmbclient, file-roller-nautilus, ghc-xml, ghc-Glob, libkcapi, ghc- aeson-pretty, libvdpau, compat-openssl10, opencore-amr, abrt-addon- kerneloops, libnftnl, gnome-maps, evolution-data-server, qt5ct, libgta, oddjob-mkhomedir, kernel-tools-libs, kf5-kidletime, openCOLLADA, xcb-util-renderutil, subversion-perl, sssd-ad, qt5 -qttools-libs-designercomponents, texlive-luatex, libpinyin, freetype, python2-libsss_nss_idmap, logrotate, vorbis-tools, rdist, irrXML, scl- utils, libdnet, ntfsprogs, abrt-libs, efibootmgr, libgdither, systemd- bootchart, samba-common-libs, libfdt, libpsl, kf5-kconfig-gui, mpg123 -plugins-pulseaudio, python3-rpm, zbar, nautilus-sendto, luksmeta, fwupdate-libs, jimtcl, coin-or-CoinUtils, lz4-libs, aws-tools, kexec- tools, opensc, boost-date-time, pypy, cabextract, libglade2, satyr, pixman, gnome-font-viewer, kf5-kparts, wpa_supplicant, evolution, xorg-x11-drv-vesa, libbluray, ghc-uuid-types, cifs-utils, libwmf, texlive-lib, libbabeltrace, librados-devel, sssd-dbus, vpnc, psmisc, ghc-network, xorg-x11-drv-libinput, ghc-x509-validation, libsss_certmap, libblockdev-mpath, cairo, libgit2-glib, ghc-process, libgcc, gdisk, ilmbase, perl-Compress-Bzip2, krb5-libs, python3-zmq, ghc-async, poppler, pocl, libstemmer, python2-tdb, djvulibre-libs, bison, ibus-libzhuyin, fftw-libs-double, libconfig, thinkfan, abrt- gui, ibus-m17n, podman, qemu-img, qt5-qtbase-gui, ghc-pretty, ghc- digest, ghc-data-default-instances-dlist, python2-igraph, libeXosip2, polkit, libcmocka, libuuid, faad2-libs, libarchive, libfreehand, ibus- gtk3, ibus-gtk2, ghc-deepseq, python2-libselinux, cheese, udisks2, clucene-contribs-lib, paps-libs, tcp_wrappers, xz, libXcomposite, rpcbind, mtools, pygtk2, criu, vim-minimal, harfbuzz-icu, python3-sss- murmur, libplist, gstreamer-tools, xdg-user-dirs, libdap, xmlto, hwloc-libs, python3-lazy-object-proxy, gdk-pixbuf2, gupnp, hunspell- devel, libevent, redland, python2-cccolutils, python3-libipa_hbac, git-core, gnome-characters, serd, zsh, slirp4netns, NetworkManager- ssh, ghc-utf8-string, sratom, libblockdev, librdmacm, urlview, lua- socket, dconf, xz-libs, dbus-glib, PackageKit-gtk3-module, bash, ipset, perl-NetAddr-IP, libcap, libprojectM, kf5-attica, avahi-tools, libwbclient, compiler-rt, kf5-kio-widgets-libs, libvirt-daemon-driver- storage-gluster, numad, sdparm, kf5-ki18n, mod_http2, libresample, highlight, libthai, fakeroot, gnome-session, pcsc-lite-ccid, qt5 -qttools-libs-designer, nss-tools, adcli, libguestfs, gdal-libs, asdcplib-libs, libtirpc, python2-simplejson, ghc-aeson, libsmartcols, gsound, fakeroot-libs, lua, oci-systemd-hook, leptonica, orc-compiler, chmlib, libwpg, os-prober, ethtool, libreofficekit, libX11, libfprint, systemd-libs, cpio, notmuch, util-linux, ghc-mime-types, ghc-x509-system, opencv-contrib, gnome-online-accounts, net-tools, enca, php-soap, gtksourceview3, libpciaccess, clucene-core, libsss_autofs, ghc-hxt-charproperties, kmod, NetworkManager-ssh-gnome, libxml++, NetworkManager-pptp, libetonyek, libcanberra-gtk2, libgs, rubygem-ruby-libvirt, ladspa-swh-plugins, gnome-user-share, ghc- unliftio-core, sssd-client, libgxps, gnome-bluetooth, kf5-kiconthemes, js, libpagemaker, libreport-plugin-bugzilla, webkit2gtk3-jsc, kf5-kitemviews, CharLS, libxkbcommon, device-mapper-multipath-libs, yajl, lockdev, ghc-resourcet, cups-filters-libs, python2-m2ext, geocode-glib, lpsolve, ghc-asn1-encoding, xorg-x11-server-utils, ckb- next, R-core, gnupg2, ghc-parsec, gpgme-devel, pypy-libs, cracklib, evince-libs, libepubgen, libdnf, doxygen, ruby, gnuplot-common, abrt- addon-pstoreoops, gnome-keyring, perl-Encode-JIS2K, libdbusmenu-gtk3, libdbusmenu-gtk2, pulseaudio-libs-glib2, rubygem-nokogiri, texlive- makeindex, lxpolkit, libvirt-libs, nm-connection-editor, python2-qt5-webkit, qt5-qttools-libs-help, python3-pyparted, libudisks2, blas, python3-setools, clutter, zenity, rhythmbox, chkconfig, python2-qt5, libgnome-keyring, pax, hostname, iscsi- initiator-utils, librados2, libvirt-daemon-driver-storage-mpath, subunit, pam, python2-gstreamer, python2-cffi, unixODBC, openldap, oniguruma, zziplib, libXft, evince-nautilus, python3-ldap, ipcalc, SDL, speex, libvirt-daemon-driver-storage-logical, ibus-wayland, neon, rest, libsamplerate, python2-lxml, NetworkManager-vpnc-gnome, boost- iostreams, poppler-utils, samba, pakchois, lapack, subversion, zfs- fuse, ghc-JuicyPixels, libusbmuxd, perl-Unicode-Normalize, avahi-ui- tools, gperftools-libs, libimobiledevice, lzop, libvirt-daemon-driver- secret, NetworkManager-wwan, polkit-pkla-compat, gdcm, jbig2dec-libs, epiphany-runtime, libmtp, cyrus-sasl-lib, librevenge, nspr, gjs, python3-gobject-base, gnome-settings-daemon, zvbi, dnsmasq, geoclue2-libs, libXfixes, libblkid, libsss_simpleifp, cockpit-bridge, libcdio, libsss_sudo, rsync, samba-winbind, gnome-software, krb5-pkinit, lua-libs, abrt-addon-coredump-helper, msr-tools, NetworkManager-bluetooth, authselect-libs, soundtouch, live555-libs, xorg-x11-drv-evdev, libpeas-gtk, libXinerama, lirc-libs, ghc-blaze- markup, libteam, vim-enhanced, libcmis, qt5-qttools, libesmtp, osm- gps-map, acl, libogg, gupnp-igd, kf5-kinit, vid.stab, ghc-temporary, libgee, libXxf86vm, mesa-libEGL, python2-pyxattr, rpm-plugin-systemd- inhibit, systemd-pam, python2-libvirt, ftgl, python2-libreport, ghc- transformers-compat, perl-Digest-MD5, qt5-qtserialport, spandsp, libshout, net-snmp-agent-libs, python2-hawkey, perl-Sort-Key, libvirt- daemon-driver-storage-rbd, libnfsidmap, nss-util, libsemanage, marisa, arpack, ghc-primitive, rust, mozjs52, systemd-container, libcomps, libaec, ghc-texmath, at, file, conmon, vamp-plugin-sdk, ghc-data- default-instances-old-locale, kf5-kcompletion, libmspack, libblockdev- fs, java-1.8.0-openjdk-headless, konversation, libnma, gettext, pcre2-utf32, soxr, espeak, oci-umount, libvirt-gobject, libutempter, cockpit-ws, libmetalink, ghc-blaze-builder, liblrdf, openblas-serial, gvfs-afp, cryptopp, usbutils, e2fsprogs, libcdio-paranoia, grub2 -tools-minimal, cpp, libksba, libwayland-server, virglrenderer, dracut, gdbm, libchromaprint, osinfo-db-tools, libsndfile, libvisio, ghc-th-abstraction, tk, ruby-libs, bzip2-libs, dbus-libs, ghc- asn1-parse, gmp-c++, libalpm, openssl-pkcs11, switcheroo-control, gnutls, ncftp, SuperLU, ghc-transformers-base, device-mapper- persistent-data, ghc-exceptions, python2-krbv, webkit2gtk3-plugin- process-gtk2, freeipa-client, libselinux-utils, perl-Scalar-List- Utils, dosfstools, rng-tools, gnome-abrt, libspectre, ostree-libs, compat-openssl10-pkcs11-helper, keyutils-libs, qt5-qtwebsockets-devel, libproxy, sssd-common-pac, ncurses-c++-libs, ntp, libreoffice-math, libtimezonemap, ghc-base, glusterfs-fuse, game-music-emu, anaconda- core, libEMF, tesseract, php-mbstring, libatasmart, perl-XML-Parser, mlocate, tmux, file-libs, grub2-tools, avahi-glib, mokutil, libblockdev-swap, libnetfilter_conntrack, usermode, python3-gobject, libev, rpm-devel, frei0r-plugins, python2-netifaces, fprintd-pam, libgepub, libusbx, python3-pygpgme, NetworkManager-openvpn-gnome, qrencode-libs, libICE, libgexiv2, flac, drpm, xsane, pstoedit, createrepo_c-libs, kf5-kio-core, grilo, perl-Compress-Raw-Zlib, libindicator-gtk3, speexdsp, upower, java-1.8.0-openjdk-devel, ghc- tls, libreoffice-x11, nautilus, xcb-util-wm, diffstat, gtk2-devel, libvirt-gconfig, 389-ds-base-libs, socat, libvirt-daemon-driver-lxc, alsa-lib, gstreamer1-plugins-good-gtk, cyrus-sasl-gssapi, libwnck3, x264-libs, python2-gobject, gtkmm24, libvirt-daemon-driver-storage- disk, brasero-libs, libucil, mesa-dri-drivers, kf5-kbookmarks, ghc- hourglass, pyliblzma, python3-abrt, libffado, ghc-highlighting-kate, suitesparse, libopenraw, gdbm-libs, fribidi, libgnomekbd, libblockdev- kbd, ibus-rawcode, powertop, pciutils, libini_config, openssh-clients, texlive-mfware, ghc-directory, celt051, beignet, htop, kyotocabinet- libs, python3-pwquality, gvfs-mtp, python3-cryptography, systemd, ghc- template-haskell, python3-msgpack, u2f-hidraw-policy, libnl3, gimp- libs, kf5-kservice, libidn, ghc-monad-control, grubby, coin-or-Clp, openjpeg-libs, python2-gssapi, python3-libreport, libdbusmenu, libbytesize, libmpeg2, qemu-block-rbd, python3-systemd, llvm4.0-libs, rpm-ostree-libs, libnl3-cli, ibus-libs, opencv-core, python2-libcomps, python2-pyyaml, audit-libs, cyrus-sasl-devel, bluez, gettext-libs, liborcus, kf5-kwidgetsaddons, cups, qt5-qtwayland, libref_array, gvfs- afc, ghc-socks, fwupd, raptor2, gtk-update-icon-cache, plymouth- plugin-two-step, sbc, qt-x11, libsane-hpaio, ghc-random, libhangul, python3-sqlalchemy, ocl-icd, poppler-glib, libgpod, seahorse, libblockdev-lvm, utf8proc, ibus-kkc, lvm2, wireshark-qt, harfbuzz, ghc-syb, libva, dmraid, neovim, pandoc, tokyocabinet, python3-wrapt, gvfs-client, NetworkManager-libnm, ghc-cereal, coin-or-Osi, python2-libs, zeromq, krb5-server, ibus-qt, gnome-boxes, clevis- udisks2, lrzsz, libglvnd-egl, libunwind, unbound-libs, ghc-http-types, dpkg, libtalloc, python2-sss-murmur, libtar, hypervkvpd, perl-Sys- Syslog, libepoxy, perl-Variable-Magic, man-db, python2-dbus, gedit, plotutils, libvirt-daemon-driver-storage-core, libzapojit, mesa- libgbm, boost-locale, timedatex, fltk, xdg-desktop-portal, qt5-qtenginio, libebml, rasqal, wireless-tools, libdb, passwd, cups- pk-helper, quota, kmod-libs, NetworkManager-team, libdv, gutenprint- libs, lm_sensors-libs, libreoffice-writer, desktop-file-utils, libXdamage, xorg-x11-utils, libmwaw, flite, libusal, sombok, qt5-designer, gcc-gdb-plugin, dleyna-connector-dbus, gtkmm30, clang5.0-libs, libgit2, qt5-qtmultimedia, dhcp-libs, libplacebo, texlive-xdvi, gobject-introspection, kf5-kconfig-core, libpwquality, fontconfig, compat-ffmpeg28, libnsl, rxvt-unicode-256color-ml, libblockdev-dm, ghc-mtl, compat-lua-libs, evince-djvu, certmonger, libkcapi-hmaccalc, grep, zlib-ada, ffmpeg, mariadb-connector-c, nitrokey-app, tcl, php-pecl-zip, flatpak, python3-librepo, pkgconf, php-fpm, ghc-case-insensitive, vino, json-c, kf5-kauth, python2-html5-parser, sed, sssd-ipa, pygtk2-libglade, jemalloc, perl- threads-shared, ghc-cmark-gfm, php-process, glib-networking, samba- libs, kpartx, movit, sane-backends-libs, python3-pillow, ghc-old- locale, python35, ghc-HTTP, cyrus-sasl, hardlink, libcollection, libgcrypt, cairomm, perl-Unicode-UTF8, nss-softokn, geoclue2, lsof, binutils, duplicity, cronie-anacron, gnome-online-miners, python3-solv, twolame-libs, adwaita-qt4, adwaita-qt5, gnome-shell, cups-ipptool, libosip2, fuse-exfat, xorg-x11-server-Xorg, rxvt- unicode-ml, openh264-libs, libmbim, perl-IO, libomp, libverto, glibmm24, libXScrnSaver, libtasn1-tools, realmd, libmspub, ncurses, libkml, python2-sip, nfs-utils, graphite2, python3-kerberos, perl- List-MoreUtils-XS, passwdqc-lib, imlib2, libreport-plugin-kerneloops, libde265, libpng12, glusterfs-server, gmp, sssd-krb5-common, python2-samba, softhsm, uriparser, volume_key-libs, b43-fwcutter, ffmpeg-libs, ghc-data-default-class, alsa-plugins-pulseaudio, perl- interpreter, oci-register-machine, bluez-cups, gimp, rubygem-ffi, texlive-metafont, chromium-libs-media, libcurl, kf5-kcrash, coreutils, gnutls-utils, libcap-ng, gvfs, dbus-x11, pinentry, libvirt-daemon- driver-storage-scsi, librepo, compat-ffmpeg-libs, nautilus-extensions, python2-mistune, qemu-common, docker, gsm, libuv, boost-filesystem, libtevent, kf5-sonnet-ui, ilbc, ghc-base-compat, libchamplain, libglvnd, gnome-documents-libs, boost-system, libpcap, openblas- threads64_, ghc-x509-store, calibre, qemu-block-iscsi, snappy, sscg, lmdb, libindicator, clutter-gst3, libdrm, genisoimage, ghc-foundation, brotli, libgcrypt-devel, rubygem-bigdecimal, pcre2, shotwell, openssh, xmlrpc-c, jsoncpp, perl-TermReadKey, qt5-qtwebkit, cogl, rygel, daala- libs, libpng-devel, python3-PyYAML, libvirt-glib, perl-Sub-Name, sssd- nfs-idmap, telepathy-logger, python2-libipa_hbac, libssh, libmodulemd, qt5-qtimageformats, GConf2, glibc, jsl, proj, hidapi, ttmkfdir, flatpak-libs, fipscheck, libRmath, mactel-boot, bc, ghc-bytestring, gtk-vnc2, gdk-pixbuf2-devel, wget, libijs, openssl, zip, ghc-filepath, libreport-web, libgomp, libexif, libkadm5, tigervnc, ladspa, php-cli, libgusb, glib2, hesiod, spirv-tools-libs, python2-libxml2, qemu- system-x86-core, ImageMagick-libs, libproxy-mozjs, pcre2-utf16, libmnl, gettext-devel, libzmf, libmng, nss, pcre, python3-pynacl, libchamplain-gtk, tcp_wrappers-libs, sane-backends, gstreamer1 -plugins-base, spax, speech-dispatcher, php-common, pciutils-libs, ghc-attoparsec, libiptcdata, libmpc, libXi, file-roller, openjpeg2, libmatroska, flac-libs, libXt, libXv, rubygem-openssl, rpm-libs, info, libnfnetlink, ghc-time-locale-compat, libiec61883, gstreamer, faac, python3-gssapi, device-mapper-event, perl-autovivification, qt5 -qttools-devel, qt5-qtbase, ghc-scientific, libreoffice-base, qpdf, libpskc, java-1.8.0-openjdk, ibus, python3-greenlet, gamin, jwhois, qemu-block-dmg, curl, yelp-libs, cmake, gnutls-dane, gnuplot, libdmapsharing, rubygem-json, fipscheck-lib, hivex, scrub, python2-pycurl, dos2unix, paps, libqxp, abrt-tui, lzo-minilzo, ustr, pinfo, tpm2-tss, qt5-qtspeech-speechd, abrt-addon-xorg, libdhash, linphone, gnome-keyring-pam, sssd-proxy, libfdk-aac, totem, gd, gc, python3-cups, libxshmfence, libvo-aacenc, ghc-text, libreport-plugin- systemd-journal, python2-libxslt, atlas, libcgroup, libcephfs2, glusterfs-extra-xlators, unzip, vlc, gtk2, gtk3, libwayland-egl, ghc- conduit, perl-Encode-HanExtra, libv4l, 389-ds-base-legacy-tools, atkmm, npth, perl-Params-Util, libyaml, mercurial, tre, libXaw, qt5-qt3d, ghc-asn1-types, gspell, xcb-util-image, m17n-lib, libblockdev-mdraid, glusterfs, exiv2-libs, lensfun, python2-pynacl, libunistring, postgresql-libs, rxvt-unicode, dleyna-server, php-gd, autotrace, qgnomeplatform, gstreamer1-plugins-good, ghc-pem, python2-rpm, libasyncns, qemu-block-curl, python2-pygpgme, device- mapper-multipath, c-ares, xmlsec1-openssl, libspiro, python2-cairo, veritysetup, gfbgraph, NetworkManager-pptp-gnome, jansson, bind-utils, ghc-yaml, librsvg2, firefox, alsa-utils, apr, ghc-split, libsss_nss_idmap, acpitool, gupnp-dlna, trousers-lib, libmp4v2, webrtc-audio-processing, bcache-tools, openblas-Rblas, startup- notification, feh, ghc-data-default-instances-containers, python2 -lazy-object-proxy, libgeotiff, python3-psutil, babl, libstaroffice, harfbuzz-devel, armadillo, opusfile, lm_sensors, bubblewrap, elfutils- libs, gcc-c++, libtasn1, jbigkit-libs, php-xml, perl-libintl-perl, libe-book, freerdp1.2, python3-dbus, sqlite, tar, python3-netifaces, sudo, speech-dispatcher-espeak, rxvt-unicode-256color, dhcp-client, chromium-libs-media-freeworld, fprintd, pinentry-gtk, gcc, lame, dwz, xorg-x11-drv-qxl, gcr, python2-psutil, oddjob, ebtables, libupnp, avahi-libs, popt, pigz, libappindicator-gtk3, libquvi, gvfs-archive, kvazaar-libs, libao, ghc-hslua, lz4, kbd, mutt, gnome-shell-extension- pomodoro, libreoffice-core, wayland-devel, python3-pyicu, libdaemon, ghc-skylighting, libphodav, libwayland-cursor, openvpn, libpaper, squashfs-tools, chromium-libs, gstreamer1-plugins-ugly, xvidcore, libwacom, xmlada, lzo, pango, gstreamer-plugins-base, libss, aspell, mod_dnssd, libuninameslist, dbus, polkit-libs, perl-threads, perl- Params-Validate, compat-readline6, pangomm, cryptsetup, flickcurl, mpg123-plugins-jack, mesa-libxatracker, nss-sysinit, LibRaw, texlive- gsftopk, nss_wrapper, gdb-gdbserver, openni, nss-mdns, geos, runc, python3-cffi, perl-Socket6, kf5-kio-ntlm, kf5-kwallet-libs, at- spi2-core, libvirt-daemon-driver-network, ghc-cookie, yum-metadata- parser, glibc-common, liblockfile, kf5-kcodecs, clang-libs, bind- export-libs, ghc-safe, gnome-autoar, lshw, qt5-qtlocation, python3-libxml2, libnfs, php-intl, libgfortran, stoken-libs, gnome- contacts, gdm, aribb25, libiscsi, texlive-kpathsea, libvirt-daemon- driver-libxl, pypy3, groff-base, ghc-dlist, libusb, hdparm, openssh- askpass, mesa-libGL, perl-Devel-LexAlias, abrt-addon-ccpp, libldb, libldm, bind-libs-lite, NetworkManager-vpnc, libmodplug, libvirt- daemon-driver-nodedev, libipt, samba-winbind-modules, libcanberra, pcsc-lite, kf5-kio-core-libs, PackageKit-gstreamer-plugin, wavpack, xorg-x11-drv-wacom, 389-ds-base, libsrtp, perl-Package-Stash-XS, samba-client-libs, qt5-qtscript, openssh-server, lilv, which, x265-libs, samba-client, libaio, lua-expat, rpcgen, ldb-tools, aws, libquadmath, sssd-tools, gvfs-gphoto2, brlapi, strace, thunderbird, createrepo_c, python2-markupsafe, elinks, python2-pyicu, libreport- gtk, liboauth, lmdb-libs, libgpg-error-devel, xmlsec1, libuser, python2-qt5-base, ghc-memory, isns-utils-libs, ghc-extensible- exceptions, libwsman1, openldap-clients, krb5-workstation, perl-libs, nmap-ncat, libglvnd-opengl, python3-talloc, libpng, lksctp-tools, libgltf, usb_modeswitch, tbb, mythes, rubygem-psych, NetworkManager- wifi, qt, mjpegtools-libs, abrt-retrace-client, git-svn, teamd, libvorbis, ghc-enclosed-exceptions, NetworkManager-openconnect-gnome, vconfig, ghc-regex-pcre, pcre-cpp, python3-libselinux, libodfgen, liblouis, exiv2, texlive-xetex, qt5-qtwebchannel, uid_wrapper, perl- PadWalker, qt3, OpenEXR, libvirt-daemon-driver-uml, gnutls-c++, libpeas-loader-python3, libjose, ghc-http-client, llvm-libs, gnome- logs, ogdi, pulseaudio-module-bluetooth, templates_parser, valgrind, kf5-kconfigwidgets, ghc-cmark, qt5-qtgraphicaleffects, qpid-proton-c, portaudio, passwdqc, ghc-tagged, schroedinger, libattr, gitg, qt5 -qtbase-devel, ghc-data-default, hyphen, gnupg2-smime, containernetworking-plugins, mpg123-plugins-portaudio, rpm, kf5-kwallet, syslinux, libxcrypt, kernel-tools, sssd-ldap, iptstate, glib2-devel, libreport-plugin-ureport, radvd, OpenEXR_Viewers, python3-lxml, kf5-kdbusaddons, openpgm, python3-libs, libappindicator, glusterfs-cli, perl-PathTools, ipset-libs, cri-o, kf5-kio-widgets, cvs, perl-Devel-Size, rpm-sign-libs, plymouth-graphics-libs, ghc-http- client-tls, mozjs38, gnome-menus, glusterfs-client-xlators, libreoffice-pyuno, hexedit, flex, libxml2, gmime, libreoffice-ure, iscsi-initiator-utils-iscsiuio, gitg-libs, mpage, libargon2, libnm- gtk, mesa-vulkan-drivers, mousetweaks, libvirt-daemon, protobuf-lite, libsecret, libnet, p11-kit-trust, dcraw, m2crypto, augeas-libs, libsysfs, pypy3-libs, php, audit, buildah, abrt-dbus, gnome-desktop3, gdk-pixbuf2-modules, at-spi2-atk, xen-libs, nss-pem, vim-common, python2-kerberos, less, brltty, libvpx, evince, rpm-build-libs, libnghttp2, python2-systemd, util-linux-user, totem-nautilus, libsolv, exempi, libxkbcommon-x11, libmms, chromium, libtdb, python3-gpg, libXdmcp, ghc-haddock-library, perl-Socket, apr-util, python2-bcrypt, krb5-devel, libvisual, python3, python2, gpm-libs, clevis, avahi-ui- gtk3, xorg-x11-server-Xwayland, esmtp, supermin, perl-DB_File, shared- mime-info, httpd-tools, SDL2, webkit2gtk3, perl-GD, libsigsegv, qt5 -qt3d-devel, boost-thread, perl-Devel-Caller, libunicap, grilo- plugins, ghc-byteable, net-snmp-libs, shadow-utils, boost-random, esc, dbus-glib-devel, libXau, netcf-libs, libgdata, phonon-qt5, libvirt- client, pulseaudio-module-x11, dmidecode, usbmuxd, python3-libcomps, phonon-qt5-backend-gstreamer, libjpeg-turbo, spice-gtk3, oggvideotools, libmount, ghc-tagsoup, epiphany, spice-vdagent, xorg-x11-drv-wacom-serial-support, xorg-x11-drv-fbdev, ghc- base64-bytestring, libqb, libavc1394, lldpad, libtiff, python3-libsemanage, libvncserver, samba-common-tools, sg3_utils-libs, libnotify, libnitrokey, kf5-kguiaddons, ima-evm-utils, nftables, slang, texlive-tex, ed, libmx, ghc-tf-random, python2-gobject-base, mesa-libOpenCL, grub2-tools-extra, dbxtool, ghc-pandoc-types, darktable, mutter, qt5-doctools, taglib, wireshark-gtk, libXext, mcpp, ModemManager-glib, bridge-utils, ostree, device-mapper-event-libs, initscripts, hunspell, lynx, libieee1284, libndp, xmlrpc-c-c++, poly2tri, pulseaudio, libaesgm, lsscsi, kf5-ktextwidgets, bzip2, elfutils-libelf, nss-softokn-freebl, open-vm-tools, evolution-ews, libsmi, ucommon, kf5-kdoctools, python3-tdb, python3-smartcols, libavdevice, unibilium, libtool-ltdl, readline, perl-Storable, eog, yelp, xorg-x11-drv-intel, vulkan-loader, abrt-java-connector, perl- version), /usr/lib/.build-id/93(argyllcms, xmlrpc-c-c++, dhcp-libs, ImageMagick-libs, rubygem-eventmachine, xorg-x11-drv-qxl, opencv-core, cups, gstreamer1, gimp, 389-ds-base, python3-sss-murmur, glibc, gegl, tokyocabinet, coreutils, acpica-tools, frei0r-plugins, python26, fwupd, ruby-libs, iptables, ebtables, chromium-libs, darktable, vlc, xorg-x11-drv-evdev, gtk2, flac, brltty, libbabeltrace, subversion- perl, pipewire, python35, samba-client-libs), /usr/lib/.build-id/d3 (ghc-binary, nss-tools, libassuan, PackageKit-gstreamer-plugin, perl- interpreter, chromium, libreoffice-core, tpm2-tools, xorg-x11-server- utils, httpd, sssd-common, glibc, coreutils, ladspa-swh-plugins, python2-libs, gimp, python2-libreport, authselect-libs, acpica-tools, vlc, python3-libs, flac-libs, pigz, tbb, llvm-libs, doxygen, serd, rygel, qt5-qttools-devel, zsh, samba-client-libs), /usr/lib/.build- id/b3(gstreamer1-plugins-bad, libndp, ghc-asn1-encoding, libxml2, totem, nss-tools, gnome-software, openni, gimp, webrtc-audio- processing, clang-libs, jack-audio-connection-kit, kf5-kwallet, ladspa-swh-plugins, frei0r-plugins, ruby-libs, vlc, open-vm-tools, chromium-libs, darktable, unixODBC, sane-backends-drivers-scanners, gstreamer1-plugins-good, fuse, imlib2, evolution, libgpod, python33, bind-utils, python37, xen-libs, glibc, freerdp1.2) [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gostsum , openssl-gost-engine-debuginfo , openssl-gost-engine-debugsource [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: openssl-gost-engine-1.1.0.3.git3383ad1-1.x86_64.rpm gostsum-1.1.0.3.git3383ad1-1.x86_64.rpm openssl-gost-engine-debuginfo-1.1.0.3.git3383ad1-1.x86_64.rpm openssl-gost-engine-debugsource-1.1.0.3.git3383ad1-1.x86_64.rpm openssl-gost-engine-1.1.0.3.git3383ad1-1.src.rpm openssl-gost-engine.x86_64: W: incoherent-version-in-changelog 1.1.0.3-1 ['1.1.0.3.git3383ad1-1', '1.1.0.3.git3383ad1-1'] openssl-gost-engine.x86_64: W: invalid-license BSD-style openssl-gost-engine.x86_64: W: no-url-tag openssl-gost-engine.x86_64: W: no-documentation gostsum.x86_64: W: spelling-error Summary(en_US) utilites -> utilities, utilizes, titillates gostsum.x86_64: W: spelling-error %description -l en_US utilites -> utilities, utilizes, titillates gostsum.x86_64: W: invalid-license BSD-style gostsum.x86_64: W: no-url-tag openssl-gost-engine-debuginfo.x86_64: W: invalid-license BSD-style openssl-gost-engine-debuginfo.x86_64: W: no-url-tag openssl-gost-engine-debugsource.x86_64: W: invalid-license BSD-style openssl-gost-engine-debugsource.x86_64: W: no-url-tag openssl-gost-engine.src: W: invalid-license BSD-style openssl-gost-engine.src: W: no-url-tag openssl-gost-engine.src:29: W: setup-not-quiet openssl-gost-engine.src: W: invalid-url Source0: engine-1.1.0.3.git3383ad1.tar.gz 5 packages and 0 specfiles checked; 0 errors, 16 warnings. Rpmlint (debuginfo) ------------------- Checking: openssl-gost-engine-debuginfo-1.1.0.3.git3383ad1-1.x86_64.rpm openssl-gost-engine-debuginfo.x86_64: W: invalid-license BSD-style openssl-gost-engine-debuginfo.x86_64: W: no-url-tag 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory openssl-gost-engine.x86_64: W: incoherent-version-in-changelog 1.1.0.3-1 ['1.1.0.3.git3383ad1-1', '1.1.0.3.git3383ad1-1'] openssl-gost-engine.x86_64: W: invalid-license BSD-style openssl-gost-engine.x86_64: W: no-url-tag openssl-gost-engine.x86_64: W: no-documentation openssl-gost-engine-debuginfo.x86_64: W: invalid-license BSD-style openssl-gost-engine-debuginfo.x86_64: W: no-url-tag gostsum.x86_64: W: spelling-error Summary(en_US) utilites -> utilities, utilizes, titillates gostsum.x86_64: W: spelling-error %description -l en_US utilites -> utilities, utilizes, titillates gostsum.x86_64: W: invalid-license BSD-style gostsum.x86_64: W: no-url-tag openssl-gost-engine-debugsource.x86_64: W: invalid-license BSD-style openssl-gost-engine-debugsource.x86_64: W: no-url-tag 4 packages and 0 specfiles checked; 0 errors, 12 warnings. Requires -------- openssl-gost-engine (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypto.so.1.1()(64bit) libcrypto.so.1.1(OPENSSL_1_1_0)(64bit) rtld(GNU_HASH) openssl-gost-engine-debuginfo (rpmlib, GLIBC filtered): gostsum (rpmlib, GLIBC filtered): libc.so.6()(64bit) rtld(GNU_HASH) openssl-gost-engine-debugsource (rpmlib, GLIBC filtered): Provides -------- openssl-gost-engine: openssl-gost-engine openssl-gost-engine(x86-64) openssl-gost-engine-debuginfo: debuginfo(build-id) openssl-gost-engine-debuginfo openssl-gost-engine-debuginfo(x86-64) gostsum: gostsum gostsum(x86-64) openssl-gost-engine-debugsource: openssl-gost-engine-debugsource openssl-gost-engine-debugsource(x86-64) Unversioned so-files -------------------- openssl-gost-engine: /usr/lib64/engines-1.1/gost.so Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -v -m fedora-rawhide-x86_64 -n openssl-gost-engine Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Spec URL: https://drive.google.com/open?id=1TpaA4MhNxYS7ltEoTlhNnOa6RnFkGfon SRPM URL: https://drive.google.com/open?id=1gJsjsX4qoAbJlkVWpJsL4HSNO6-qj5mJ Koji URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=30104788 Hopefully it fixes most of review/rpmlint warnings. I do not understand how to deal with the following ones: 1. [!]: Uses parallel make %{?_smp_mflags} macro - this macro is not mentioned in spec file, and build is processed via Cmake 2. openssl-gost-engine.src:30: W: setup-not-quiet 3. Unversioned so-files -------------------- openssl-gost-engine: /usr/lib64/engines-1.1/gost.so Naming and layout of the engine file itself matches the same provided by openssl-libs
Issues so far: - "Uses parallel make %{?_smp_mflags} macro" - you just need to replace 'make' call in %build with '%make_build' - W: setup-not-quiet - just add '-q' option to %setup - unversioned so-files - this is OK as this is a plug-in and not a general purpose library - version & release - the version & release does not conform to the: https://fedoraproject.org/wiki/Packaging:Versioning (the version should not contain the git snapshot tag - it should be placed into the Release. And there is also missing the dist tag in the Release. - license - this is in general OK, but I would recommend upstream to add the OpenSSL License file to the git and released tarballs so it could be included in the package (do not do that downstream) - Please add Requires: %{name}%{?_isa} = %{version}-%{release} to the gostsum subpackage
SPEC URL: https://drive.google.com/open?id=1z6XStVyNvDBBwNjA1nyDEN6JhNUK-mSi SRPM URL: https://drive.google.com/open?id=1UFB9pioQapnS0mVbtkB5NnuXK87Hpi31 Koji URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=30398091 The only left warning left is: rpmlint openssl-gost-engine/openssl-gost-engine-1.1.0.3-3.fc29.src.rpm openssl-gost-engine.src: W: invalid-url Source0: engine-1.1.0.3.tar.gz According to https://bugzilla.redhat.com/show_bug.cgi?id=566978, this is intentional.
As this is a snapshot from git, the snapshot should be clearly marked in the release. So the name-version-release should actually be: openssl-gost-engine-1.1.0.3-3.20181002git3383ad1.fcxy This will make it clear what snapshot was used. If you later switch to a regular release this can be of course omitted. This is a minor issue that can be fixed later and I approve the package. rpmlint output: gostsum-debuginfo.x86_64: I: checking gostsum-debuginfo.x86_64: I: checking-url https://github.com/gost-engine/engine (timeout 10 seconds) gostsum-debuginfo.x86_64: E: useless-provides debuginfo(build-id) gostsum.x86_64: I: checking gostsum.x86_64: I: checking-url https://github.com/gost-engine/engine (timeout 10 seconds) gostsum.x86_64: W: only-non-binary-in-usr-lib openssl-gost-engine-debuginfo.x86_64: I: checking openssl-gost-engine-debuginfo.x86_64: I: checking-url https://github.com/gost-engine/engine (timeout 10 seconds) openssl-gost-engine-debugsource.x86_64: I: checking openssl-gost-engine-debugsource.x86_64: I: checking-url https://github.com/gost-engine/engine (timeout 10 seconds) openssl-gost-engine-debugsource.x86_64: W: no-documentation openssl-gost-engine.src: I: checking openssl-gost-engine.src: I: checking-url https://github.com/gost-engine/engine (timeout 10 seconds) openssl-gost-engine.src: W: invalid-url Source0: engine-1.1.0.3.tar.gz openssl-gost-engine.x86_64: I: checking openssl-gost-engine.x86_64: I: checking-url https://github.com/gost-engine/engine (timeout 10 seconds) 6 packages and 0 specfiles checked; 1 errors, 3 warnings. All the warnings and errors above are OK.
I've sponsored you into Fedora packagers.
Is it necessary to specify the exact commit? I use git tags as the exact identifier of the codebase, and the tag is 1.1.0.3 What are next expected steps from me?
If the git tag points at the right commit, then it is ok and you do not need to specify it. So please disregard this. Next steps - just follow the document: https://fedoraproject.org/wiki/Package_Review_Process ... When your package pass the review, you should use the fedpkg tool to request a git repository for it. Before doing that you will need a pagure_api_token configured (one with "Create a new ticket" ACL) and added into ~/.config/rpkg/fedpkg.conf and so on
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/openssl-gost-engine
The result of "fedpkg build" is available here: https://koji.fedoraproject.org/koji/taskinfo?taskID=30497295
Should this be closed if package is already in Rawhide?
I do not know the procedures. Should I close it myself?
Yes, see the contributor steps in: https://fedoraproject.org/wiki/Package_Review_Process
Done.