Description of problem: When deploying HE using DHCP via the Cockpit wizard, the general error message "Please correct errors before moving to the next step." is displayed when the user clicks "Next" in the first step, but no errors are shown at the field level. The issue is that the default gateway is not pingable, but the error is not shown on the UI. This is in either DHCP or Static configuration. Version-Release number of selected component (if applicable): cockpit-ovirt-dashboard.noarch 0.11.33-1.el7ev How reproducible: Steps to Reproduce: 1. Attempt to deploy HE via the Cockpit wizard. 2. Click "Next" while on the VM step Actual results: "Please correct errors before moving to the next step." will be displayed at the top of the page, but no field-specific error message will be shown. Expected results: The wizard moves to the next step or displayed field-specific error messages. Additional info:
Test Version RHVH-4.2-20181004.3-RHVH-x86_64-dvd1.iso cockpit-176-3.el7.x86_64 cockpit-system-176-3.el7.noarch cockpit-machines-ovirt-176-3.el7.noarch cockpit-ovirt-dashboard-0.11.35-1.el7ev.noarch cockpit-ws-176-3.el7.x86_64 cockpit-dashboard-176-3.el7.x86_64 cockpit-bridge-176-3.el7.x86_64 cockpit-storaged-176-3.el7.noarch Test Steps: 1. Attempt to deploy HE via the Cockpit wizard. 2. The default gateway is not pingable 3. In DHCP mode Result: "Please correct errors before moving to the next step." will be displayed at the top of the page, but no field-specific error message will be shown. QE can reproduce this issue, change flag qa_ack to "+".
Created attachment 1493491 [details] Show the issue
After check again and again, I found it will show the field-specific error massage in advanced.So QE cannot reproduced, change flag qa_ack to "-"
Quality Engineering Management has reviewed and declined this request. You may appeal this decision by reopening this request.
(In reply to Wei Wang from comment #3) > After check again and again, I found it will show the field-specific error > massage in advanced.So QE cannot reproduced, change flag qa_ack to "-" Hi Wei Wang, Where does it show the gateway is not pingable under advanced? My test system is not showing that result. Also, shouldn't the field specific error for the gateway field show under VM Settings > Network configuration?
Just recheck in 4.3 according to comment #5
Let's call message "Please correct errors before moving to the next step." as "general error message", while "Unable to ping address. Please enter a pingable address" as "field error message". To answer comment #5, the field error message is under the gateway address field which is in "Advanced" section, users need to expand the "Advanced" section to see it. When does the field error message appear? 1. If the default gateway is not pingable, the general error message and the field error message will appear when Hosted Engine Deployment window is opened.(need to expand the "Advanced" section to see the field error message) 2. If manually enter a not pingable address to the gateway address input box, the address will be verified immediately, the general error message and the field error message would appear. when does the field error message disappear? 1. To enter a correct address to the gateway address input box. Both general error message and field error message will disappear. 2. To change any field, except the root password, on the VM Settings page, will make the general error message and the field error message disappear. 3. To click the "Next" button, will make the field error message disappear, only leave the general error message there. In my point of view, the 2nd and 3rd scenarios that making field error message disappear are not reasonable, in such case people can't understand which filed is still error. Testing Versions: cockpit-ovirt-dashboard-0.11.37-1.el7ev.noarch cockpit-ovirt-dashboard-0.11.999-0.1.master.gitc7c3c69.el7ev.noarch
(In reply to Qin Yuan from comment #8) > Let's call message "Please correct errors before moving to the next step." > as "general error message", while "Unable to ping address. Please enter a > pingable address" as "field error message". > > To answer comment #5, the field error message is under the gateway address > field which is in "Advanced" section, users need to expand the "Advanced" > section to see it. > > > When does the field error message appear? > > 1. If the default gateway is not pingable, the general error message and the > field error message will appear when Hosted Engine Deployment window is > opened.(need to expand the "Advanced" section to see the field error message) > > 2. If manually enter a not pingable address to the gateway address input > box, the address will be verified immediately, the general error message and > the field error message would appear. > > > when does the field error message disappear? > > 1. To enter a correct address to the gateway address input box. Both general > error message and field error message will disappear. > > 2. To change any field, except the root password, on the VM Settings page, > will make the general error message and the field error message disappear. > > 3. To click the "Next" button, will make the field error message disappear, > only leave the general error message there. > > In my point of view, the 2nd and 3rd scenarios that making field error > message disappear are not reasonable, in such case people can't understand > which filed is still error. > > > Testing Versions: > cockpit-ovirt-dashboard-0.11.37-1.el7ev.noarch > cockpit-ovirt-dashboard-0.11.999-0.1.master.gitc7c3c69.el7ev.noarch In my opinion, the 2nd and 3rd scenarios are illogically for using. Why after user see the gateway error occur,but will change the other field or click "Next" button. I think testing scenarios must in line with user habits firstly.
(In reply to Adam Nissley from comment #5) > (In reply to Wei Wang from comment #3) > > After check again and again, I found it will show the field-specific error > > massage in advanced.So QE cannot reproduced, change flag qa_ack to "-" > > Hi Wei Wang, > > Where does it show the gateway is not pingable under advanced? My test > system is not showing that result. Also, shouldn't the field specific error > for the gateway field show under VM Settings > Network configuration? Yes, I think it's much better for it show under VM Settings > Network configuration. the error information is better show at the most conspicuous place. Like other settings field e.g Engine VM FQDN.
Hi Simone Could you please help with creating a more descriptive doc text for the release notes. Is the following correct? Previously, when deploying the Self-Hosted Engine from the Cockpit, an error message appeared together with an explanation that ping issues were encountered. However, under certain conditions the explanation would disappear, leaving only a generic error message "Please correct errors before moving to the next step." In this release, if ping errors are encountered during deployment, the user will be informed of the issue, and the message will remain in the error dialog window until the issue is resolved.
(In reply to Emma Heftman from comment #12) > Hi Simone > Could you please help with creating a more descriptive doc text for the > release notes. Yes, right
Moving to 4.3.2 not being identified as blocker for 4.3.1.
Fixed this issue while fixing another bug: https://bugzilla.redhat.com/show_bug.cgi?id=1693257. Moving to modified
Test Version: RHVH-4.3-20190404.1-RHVH-x86_64-dvd1.iso cockpit-system-176-4.el7.noarch cockpit-ws-176-4.el7.x86_64 cockpit-bridge-176-4.el7.x86_64 cockpit-storaged-176-4.el7.noarch cockpit-ovirt-dashboard-0.12.7-1.el7ev.noarch cockpit-machines-ovirt-176-4.el7.noarch cockpit-dashboard-176-4.el7.x86_64 cockpit-176-4.el7.x86_64 Test steps: According to comment 0 Test Result: The wizard moves to the next step or displayed field-specific error messages. Bug is fixed, move it to "VERIFIED"
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2019:1059