Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1638422

Summary: [REST API] Networks link point to 'datacenters' instead of 'networks'
Product: [oVirt] ovirt-engine Reporter: Roni <reliezer>
Component: RestAPIAssignee: Ori Liel <oliel>
Status: CLOSED CURRENTRELEASE QA Contact: Michael Burman <mburman>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 4.3.0CC: bugs, danken, ebenahar, mperina, oliel, ratamir
Target Milestone: ovirt-4.3.0Keywords: Automation, AutomationBlocker, Regression
Target Release: 4.3.0Flags: rule-engine: ovirt-4.3+
rule-engine: blocker+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: ovirt-engine-4.3.0_alpha Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-02-13 07:48:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
REST Client none

Description Roni 2018-10-11 14:16:28 UTC 
Created attachment 1492950 [details]
REST Client

Description of problem:
Got HTTP error 404 or 'EntityNotFound' while trying to fetch vnicprofile object via REST API


Version-Release number of selected component (if applicable):
4.3.0-0.0.master.20181010155922.gite89babf.el7

How reproducible:
100%

Steps to Reproduce:
1. Open: https://[engine_fqdn]/ovirt-engine/api/networks
2. Try to open one of the following links: 'permissions', 'vnicprofiles', 'networklabels' for one of the Networks

Actual results:
Got HTTP error 404
Links point as followed:
/ovirt-engine/api/datacenters/[DC_ID]/networks/[NETWORK_ID]/vnicprofiles

Expected results:
200 Ok!
/ovirt-engine/api/networks/[NETWORK_ID]/vnicprofiles


Additional info:
See also attached screen capture of REST client results
Comment 2 Ori Liel 2018-10-15 07:43:37 UTC 
The reason for the bug is actually a proper repair done to the repository of static data about the API structure, used for link-generation purposes. This data was manually maintained by developers, and thus contained many errors.

This patch:

  https://gerrit.ovirt.org/#/c/82294/

made the repository 100% correct by replacing the human maintenance with automatic data mining. However in some cases, the result of the repository containing the correct data broke backwards compatibility, in places where particular implementations 'counted on' the repository being wrong, containing a bug (2 wrongs make a right).

Analyzing the data in the old vs new and updated repositories, the above problem is expected to happen also for iscsibond networks, and thus this has been addressed as well.
Comment 3 Ori Liel 2018-10-15 07:43:49 UTC 
The reason for the bug is actually a proper repair done to the repository of static data about the API structure, used for link-generation purposes. This data was manually maintained by developers, and thus contained many errors.

This patch:

  https://gerrit.ovirt.org/#/c/82294/

made the repository 100% correct by replacing the human maintenance with automatic data mining. However in some cases, the result of the repository containing the correct data broke backwards compatibility, in places where particular implementations 'counted on' the repository being wrong, containing a bug (2 wrongs make a right).

Analyzing the data in the old vs new and updated repositories, the above problem is expected to happen also for iscsibond networks, and thus this has been addressed as well.
Comment 4 Dan Kenigsberg 2018-10-17 19:38:59 UTC 
With the patch merged, shouldn't this move to MODIFIED?
Comment 5 Michael Burman 2018-11-04 07:45:29 UTC 
Verified on - ovirt-engine-4.3.0-0.0.master.20181030100636.git6215452.el7.noarch
Comment 6 Sandro Bonazzola 2019-02-13 07:48:10 UTC 
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.