Bug 1638422 - [REST API] Networks link point to 'datacenters' instead of 'networks'
Summary: [REST API] Networks link point to 'datacenters' instead of 'networks'
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: RestAPI
Version: 4.3.0
Hardware: All
OS: Linux
urgent
urgent
Target Milestone: ovirt-4.3.0
: 4.3.0
Assignee: Ori Liel
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-10-11 14:16 UTC by Roni
Modified: 2019-02-13 07:48 UTC (History)
6 users (show)

Fixed In Version: ovirt-engine-4.3.0_alpha
Clone Of:
Environment:
Last Closed: 2019-02-13 07:48:10 UTC
oVirt Team: Infra
Embargoed:
rule-engine: ovirt-4.3+
rule-engine: blocker+


Attachments (Terms of Use)
REST Client (258.56 KB, image/png)
2018-10-11 14:16 UTC, Roni
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 94909 0 master MERGED restapi: Direct Network Links To API Root 2018-10-15 08:49:34 UTC

Description Roni 2018-10-11 14:16:28 UTC
Created attachment 1492950 [details]
REST Client

Description of problem:
Got HTTP error 404 or 'EntityNotFound' while trying to fetch vnicprofile object via REST API


Version-Release number of selected component (if applicable):
4.3.0-0.0.master.20181010155922.gite89babf.el7

How reproducible:
100%

Steps to Reproduce:
1. Open: https://[engine_fqdn]/ovirt-engine/api/networks
2. Try to open one of the following links: 'permissions', 'vnicprofiles', 'networklabels' for one of the Networks

Actual results:
Got HTTP error 404
Links point as followed:
/ovirt-engine/api/datacenters/[DC_ID]/networks/[NETWORK_ID]/vnicprofiles

Expected results:
200 Ok!
/ovirt-engine/api/networks/[NETWORK_ID]/vnicprofiles


Additional info:
See also attached screen capture of REST client results

Comment 2 Ori Liel 2018-10-15 07:43:37 UTC
The reason for the bug is actually a proper repair done to the repository of static data about the API structure, used for link-generation purposes. This data was manually maintained by developers, and thus contained many errors.

This patch:

  https://gerrit.ovirt.org/#/c/82294/

made the repository 100% correct by replacing the human maintenance with automatic data mining. However in some cases, the result of the repository containing the correct data broke backwards compatibility, in places where particular implementations 'counted on' the repository being wrong, containing a bug (2 wrongs make a right).

Analyzing the data in the old vs new and updated repositories, the above problem is expected to happen also for iscsibond networks, and thus this has been addressed as well.

Comment 3 Ori Liel 2018-10-15 07:43:49 UTC
The reason for the bug is actually a proper repair done to the repository of static data about the API structure, used for link-generation purposes. This data was manually maintained by developers, and thus contained many errors.

This patch:

  https://gerrit.ovirt.org/#/c/82294/

made the repository 100% correct by replacing the human maintenance with automatic data mining. However in some cases, the result of the repository containing the correct data broke backwards compatibility, in places where particular implementations 'counted on' the repository being wrong, containing a bug (2 wrongs make a right).

Analyzing the data in the old vs new and updated repositories, the above problem is expected to happen also for iscsibond networks, and thus this has been addressed as well.

Comment 4 Dan Kenigsberg 2018-10-17 19:38:59 UTC
With the patch merged, shouldn't this move to MODIFIED?

Comment 5 Michael Burman 2018-11-04 07:45:29 UTC
Verified on - ovirt-engine-4.3.0-0.0.master.20181030100636.git6215452.el7.noarch

Comment 6 Sandro Bonazzola 2019-02-13 07:48:10 UTC
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.