Created attachment 1492990 [details] Proposed spec file modifications Description of problem: I am attempting to update python-networkx to version 2.2 in Rawhide. However, the test suite is failing with errors being thrown from pygraphviz when built with python 3. Upstream seems to have fixed the problems. I would like to propose that python-pygraphviz be updated to version 1.5. I will attach a modified spec file and a patch to the swig interface to make that work. Version-Release number of selected component (if applicable): N/A How reproducible: N/A Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Created attachment 1492991 [details] Proposed patch to the swig interface
I was too hasty. Apparently the top-level __init__.py imports the tests. That seems quite strange. Still, I guess you have to ship the tests after all, which means the dependency on nose is also needed. Ugh.
And, after all that, the python-networkx tests are still failing, but now it is because multigraph support is broken in graphviz itself. See https://github.com/pygraphviz/pygraphviz/issues/162. I guess I'm just going to have to disable %check for python-networkx until that issue is fixed... I still need this pygraphviz update, though, to fix the python 3 issues. Thanks!
Among the problems with running pygraphviz 1.3 with python 3.7 are StopIteration errors, which are fixed in later versions of pygraphviz. Now that the python2-pygraphviz package has officially been removed, it is important that pygraphviz work with python 3.7. The python3-pygraphviz package in (at least) Fedora 29 is version 1.3 and therefore has compatibility bugs--but at there's a python2-pygraphviz package to fall back on. Because the version of python3-graphviz package in Rawhide is also 1.3 and therefore has issues with python 3.7, but there is no python2 fallback, it's problematic. This is especially important to me, as I have software that depends on pygraphviz, and without an updated version python3-pygraphviz, my software won't work with Fedora Rawhide.
I pushed the proposed patch to rawhide and F29 (in F29 both packages are built, and in F30 only python3). I'm leaning towards pushing an update in F29, because it doesn't seem useful to have a broken package. What do you think?
Sounds like the right thing to do. Thanks!
python-pygraphviz-1.5-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-ce1b2603fc
python-pygraphviz-1.5-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ce1b2603fc
python-pygraphviz-1.5-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.