Bug 163875 - incorrect handling of timestamp argument to makestamp.py
incorrect handling of timestamp argument to makestamp.py
Status: CLOSED RAWHIDE
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: anaconda (Show other bugs)
4.0
All Linux
medium Severity medium
: ---
: ---
Assigned To: Anaconda Maintenance Team
Mike McLean
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2005-07-21 14:51 EDT by Dennis Gregorovic
Modified: 2007-11-30 17:07 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-07-26 10:47:44 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Dennis Gregorovic 2005-07-21 14:51:55 EDT
Note: This affects RHEL 3 and RHEL 4

If you pass a timestamp to makestamp.py via --timestamp, that variable is set as
a string in the script.  This causes the following to fail:

f.write("%f\n" % data["timestamp"])

Here's a patch:

--- makestamp.py    2005-07-21 14:50:04.480315447 -0400
+++ /usr/lib/anaconda-runtime/makestamp.py  2005-04-27 02:02:55.000000000 -0400
@@ -51,8 +51,6 @@
 if data["timestamp"] is None:
     print >> sys.stderr, "timestamp not specified; using the current time"
     data["timestamp"] = time.time()
-else:
-    data["timestamp"] = float(data["timestamp"])

 if data["releasestr"] is None:
     print "What should be the release name associated with this disc?"
Comment 1 Jeremy Katz 2005-07-26 00:10:07 EDT
Isn't this diff backwards? :)

Also, how important is this for rhel[34] vs just doing it on head?
Comment 2 Dennis Gregorovic 2005-07-26 00:37:48 EDT
I don't think the diff is backwards, but it's also past midnight so I'm probably
not thinking all that clearly.  ;)  This isn't a high priority bug as there are
workarounds (namely writing the stamp by hand instead of using makestamp.py).  
Comment 3 Jeremy Katz 2005-07-26 10:47:44 EDT
Applied to HEAD

Note You need to log in before you can comment on or make changes to this bug.