Bug 1639032 - Use LIBADD instead of LDFLAGS to link against krb5
Summary: Use LIBADD instead of LDFLAGS to link against krb5
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: libtirpc
Version: 31
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Steve Dickson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-10-14 15:45 UTC by Laurent Bigonville
Modified: 2019-09-21 01:24 UTC (History)
3 users (show)

Fixed In Version: libtirpc-1.1.4-2.rc3.fc31 libtirpc-1.1.4-2.rc3.fc30
Clone Of:
Environment:
Last Closed: 2019-09-18 00:02:33 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
0001-Use-LIBADD-instead-of-LDFLAGS-to-link-against-krb5.patch (835 bytes, patch)
2018-10-14 15:45 UTC, Laurent Bigonville
no flags Details | Diff

Description Laurent Bigonville 2018-10-14 15:45:19 UTC
Created attachment 1493731 [details]
0001-Use-LIBADD-instead-of-LDFLAGS-to-link-against-krb5.patch

Hi,

Could you please merge the attached patch?

LDFLAGS shouldn't be used to link against libraries as this would break positional flags like --as-needed

Thanks

Comment 1 Steve Dickson 2018-10-26 13:11:33 UTC
(In reply to Laurent Bigonville from comment #0)
> Created attachment 1493731 [details]
> 0001-Use-LIBADD-instead-of-LDFLAGS-to-link-against-krb5.patch
> 
> Hi,
> 
> Could you please merge the attached patch?
> 
> LDFLAGS shouldn't be used to link against libraries as this would break
> positional flags like --as-needed
> 
> Thanks

Would you mind posting this patch to 
     tirpc-devel <libtirpc-devel.net>

to get more eyes on it... tia!

Comment 2 Laurent Bigonville 2019-03-13 10:01:13 UTC
Hi,

I posted a message to the ML back in December 2018, nothing so far7

Comment 3 Steve Dickson 2019-06-11 15:43:30 UTC
Upstream Commit

commit 013cc45abef8055b3ee135fc072e402611a4a3f0
Author: Laurent Bigonville <bigon>
Date:   Tue Jun 11 11:34:16 2019 -0400

    Makefile.am: Use LIBADD instead of LDFLAGS to link against krb5

Comment 4 Ben Cotton 2019-08-13 16:50:15 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.

Comment 5 Ben Cotton 2019-08-13 19:12:06 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.

Comment 6 Fedora Update System 2019-09-05 14:11:01 UTC
FEDORA-2019-fc8b6238f8 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-fc8b6238f8

Comment 7 Fedora Update System 2019-09-05 14:11:01 UTC
FEDORA-2019-78258f7c6c has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-78258f7c6c

Comment 8 Fedora Update System 2019-09-06 00:22:33 UTC
libtirpc-1.1.4-2.rc3.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-78258f7c6c

Comment 9 Fedora Update System 2019-09-06 12:11:12 UTC
libtirpc-1.1.4-2.rc3.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-fc8b6238f8

Comment 10 Fedora Update System 2019-09-18 00:02:33 UTC
libtirpc-1.1.4-2.rc3.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2019-09-21 01:24:26 UTC
libtirpc-1.1.4-2.rc3.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.