Description of problem:

Core was generated by `/usr/bin/gnome-shell'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00007efc08be7467 in shell_app_dispose (object=0x563240bb0580) at ../src/shell-app.c:1485


Version-Release number of selected component (if applicable):

gnome-shell-3.30.1-1.fc29

How reproducible:

Always

Steps to Reproduce:
1. Install virtual F29 from Fedora-Workstation-Live-x86_64-29_Beta-1.5.iso to HD, update, reboot.
2. Install passwordsafe from:
https://copr.fedorainfracloud.org/coprs/simger/passwordsafe/
3. Start passwordsafe (pwsafe) click New... | Save | Safe: Combination: a | Verify: a | Yes

Actual results:


Gnome session ends when gnome-shell crashes

Expected results:


Passwordsafe safe window is opened.

Additional info:

I tried to report this from reporter, upload core and so on, but it says it is not possible because trace was not okay. I've tried several times and result is always the same.

Same issue was reported as #1067704 as far as I can see but no action.

https://gitlab.gnome.org/GNOME/gnome-shell/blob/master/src/shell-app.c#L1485

1484  while (app->running_state)
1485    _shell_app_remove_window (app, app->running_state->windows->data);

Here app->running_state->windows is NULL.

Locally I was able to avoid crashing with this patch, but I'm not sure if it is right call as my gnome coding is bit rusty atm.

--- a/src/shell-app.c
+++ b/src/shell-app.c
@@ -1481,8 +1481,13 @@ shell_app_dispose (GObject *object)
 
   g_clear_object (&app->info);
 
-  while (app->running_state)
+  while (app->running_state) {
+    if (app->running_state->windows == NULL) {
+      g_clear_pointer (&app->running_state, unref_running_state);
+      continue;
+    }
     _shell_app_remove_window (app, app->running_state->windows->data);
+  }
 
   /* We should have been transitioned when we removed all of our windows */
   g_assert (app->state == SHELL_APP_STATE_STOPPED);