Bug 1639372 - systemd presets request - ostree-finalize-staged.path
Summary: systemd presets request - ostree-finalize-staged.path
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: fedora-release
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Stephen Gallagher
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-10-15 15:10 UTC by Jonathan Lebon
Modified: 2018-11-14 03:12 UTC (History)
9 users (show)

Fixed In Version: fedora-release-29-3
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-11-14 03:12:31 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Jonathan Lebon 2018-10-15 15:10:55 UTC
* Does the service require post-rpm-installation configuration in order to be useful (for example, does it need manual edits to a configuration file)?

No

* Does the service listen on a network socket for connections originating on a separate physical or virtual machine?

No

* Is the service non-persistent (i.e. run once at startup and exit)?

Yes (once path-activated, it runs once at shutdown and exits).

* What is the exact name (or names) of the systemd unit files to be enabled?

ostree-finalize-staged.path

* Is this request for all Fedora deliverables or only for some Editions (list them)?

All OSTree-based deliverables:
- Silverblue
- Atomic Host
- Fedora CoreOS

(But really, the service unit has `ConditionPathExists=/run/ostree-booted` so it won't have any effect on non-OSTree systems even if somehow activated).

---

This unit is an implementation detail of how OSTree now creates new deployments. It is not expected to be directly interacted with, except for looking at logs in case of failures.

Comment 1 Peter Robinson 2018-10-15 15:49:46 UTC
> - Silverblue
> - Atomic Host
> - Fedora CoreOS

- IoT

Comment 2 Stephen Gallagher 2018-10-15 15:56:44 UTC
Given that it has `ConditionPathExists=/run/ostree-booted`, I'm inclined to just move this into the standard presets that apply to all of Fedora, rather than maintaining a specialized list of artifacts that require it.

If no one disagrees with that, I'll prepare the pull-request for Rawhide/F30 immediately. If this is needed for Fedora 29, please submit this as a Freeze Exception request at https://qa.fedoraproject.org/blockerbugs/propose_bug

Comment 3 Stephen Gallagher 2018-10-15 16:01:14 UTC
PR for Rawhide: https://src.fedoraproject.org/rpms/fedora-release/pull-request/36

Comment 4 Jonathan Lebon 2018-10-16 18:09:51 UTC
Thanks for the quick turnaround!

> If this is needed for Fedora 29, please submit this as a Freeze Exception request at https://qa.fedoraproject.org/blockerbugs/propose_bug

Yes, it's needed for Fedora 29, but doesn't need to be in at release day. I can create an F29 PR once the one for rawhide gets merged.

Comment 5 Fedora Update System 2018-11-01 15:11:02 UTC
fedora-release-29-2 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-4eb77f1fa6

Comment 6 Fedora Update System 2018-11-03 00:54:23 UTC
fedora-release-29-2 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-4eb77f1fa6

Comment 7 Fedora Update System 2018-11-12 18:12:31 UTC
fedora-release-29-3 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-6dae7e056e

Comment 8 Fedora Update System 2018-11-13 04:49:52 UTC
fedora-release-29-3 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-6dae7e056e

Comment 9 Fedora Update System 2018-11-14 03:12:31 UTC
fedora-release-29-3 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.