Bug 1639460 - [RFE] inter-mac-pool or intra-mac-pool overlapping ranges: warn if found
Summary: [RFE] inter-mac-pool or intra-mac-pool overlapping ranges: warn if found
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-4.2.8
: ---
Assignee: eraviv
QA Contact: Michael Burman
URL:
Whiteboard: Infra
Depends On:
Blocks: 1537414 1593800 1767319
TreeView+ depends on / blocked
 
Reported: 2018-10-15 18:56 UTC by eraviv
Modified: 2021-12-10 17:57 UTC (History)
13 users (show)

Fixed In Version: ovirt-engine-4.2.8.1
Doc Type: Enhancement
Doc Text:
This release supports a new WARN message in the Red Hat Virtualization Manager log on startup if overlapping ranges are found within a MAC pool or between MAC pools. Each warning details the outcome as applicable.
Clone Of: 1593800
Environment:
Last Closed: 2019-01-22 12:44:50 UTC
oVirt Team: Network
Target Upstream Version:
Embargoed:
mburman: testing_plan_complete-


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHV-44295 0 None None None 2021-12-10 17:57:52 UTC
Red Hat Product Errata RHBA-2019:0121 0 None None None 2019-01-22 12:45:01 UTC
oVirt gerrit 93447 0 master MERGED core: warn intra-mac-pool range overlap 2020-07-01 11:42:40 UTC
oVirt gerrit 93608 0 master MERGED core: warn inter-mac-pool range overlap 2020-07-01 11:42:39 UTC
oVirt gerrit 94867 0 ovirt-engine-4.2 MERGED core: warn intra-mac-pool range overlap 2020-07-01 11:42:39 UTC
oVirt gerrit 94868 0 ovirt-engine-4.2 MERGED core: warn inter-mac-pool range overlap 2020-07-01 11:42:40 UTC

Comment 1 eraviv 2018-10-24 07:00:40 UTC
Hi Michael,

I have two questions regarding this bug:

1. the bug occurs because of overlapping ranges between different mac-pools. Do you think it is enough to warn about this situation, or should we also warn about overlapping ranges within the same mac pool (for example for consistency)?

2. please ack the output that will appear in engine.log and events tab:

   a. for overlapping ranges between mac pools:

engine.log:
MAC pool 'm3' overlaps with other MAC pools: [e1fcc1e4-1548-4ad3-856d-1add75ba58a8] 
EVENT_ID: MAC_POOL_VIOLATES_NO_OVERLAPPING_MAC_POOLS(10,925), MAC pool 'm3' contains ranges which overlap ranges in mac pools: [e1fcc1e4-1548-4ad3-856d-1add75ba58a8]. All mac pools remain usable but it is recommended to disjoint them.

events tab:
MAC pool 'm3' contains ranges which overlap ranges in mac pools: [e1fcc1e4-1548-4ad3-856d-1add75ba58a8]. All mac pools remain usable but it is recommended to disjoint them.


   b. for overlapping ranges within mac pool:

engine.log:
MAC pool 'm3' contains a MAC range overlapping MAC ranges: [00:2a:4a:16:01:00-00:2a:4a:16:01:ff, 00:2a:4a:16:01:00-00:2a:4a:16:01:ff]
EVENT_ID: MAC_POOL_VIOLATES_NO_OVERLAPPING_RANGES(10,919), MAC pool 'm3' contains overlapping ranges: [00:2a:4a:16:01:00-00:2a:4a:16:01:ff, 00:2a:4a:16:01:00-00:2a:4a:16:01:ff]. All ranges remain usable but it is recommended to disjoint them.

events tab:
MAC pool 'm3' contains overlapping ranges: [00:2a:4a:16:01:00-00:2a:4a:16:01:ff, 00:2a:4a:16:01:00-00:2a:4a:16:01:ff]. All ranges remain usable but it is recommended to disjoint them.

Comment 2 Michael Burman 2018-10-24 07:54:32 UTC
(In reply to eraviv from comment #1)
> Hi Michael,
> 
> I have two questions regarding this bug:
> 
> 1. the bug occurs because of overlapping ranges between different mac-pools.
> Do you think it is enough to warn about this situation, or should we also
> warn about overlapping ranges within the same mac pool (for example for
> consistency)?
> 
> 2. please ack the output that will appear in engine.log and events tab:
> 
>    a. for overlapping ranges between mac pools:
> 
> engine.log:
> MAC pool 'm3' overlaps with other MAC pools:
> [e1fcc1e4-1548-4ad3-856d-1add75ba58a8] 
> EVENT_ID: MAC_POOL_VIOLATES_NO_OVERLAPPING_MAC_POOLS(10,925), MAC pool 'm3'
> contains ranges which overlap ranges in mac pools:
> [e1fcc1e4-1548-4ad3-856d-1add75ba58a8]. All mac pools remain usable but it
> is recommended to disjoint them.
> 
> events tab:
> MAC pool 'm3' contains ranges which overlap ranges in mac pools:
> [e1fcc1e4-1548-4ad3-856d-1add75ba58a8]. All mac pools remain usable but it
> is recommended to disjoint them.
> 
> 
>    b. for overlapping ranges within mac pool:
> 
> engine.log:
> MAC pool 'm3' contains a MAC range overlapping MAC ranges:
> [00:2a:4a:16:01:00-00:2a:4a:16:01:ff, 00:2a:4a:16:01:00-00:2a:4a:16:01:ff]
> EVENT_ID: MAC_POOL_VIOLATES_NO_OVERLAPPING_RANGES(10,919), MAC pool 'm3'
> contains overlapping ranges: [00:2a:4a:16:01:00-00:2a:4a:16:01:ff,
> 00:2a:4a:16:01:00-00:2a:4a:16:01:ff]. All ranges remain usable but it is
> recommended to disjoint them.
> 
> events tab:
> MAC pool 'm3' contains overlapping ranges:
> [00:2a:4a:16:01:00-00:2a:4a:16:01:ff, 00:2a:4a:16:01:00-00:2a:4a:16:01:ff].
> All ranges remain usable but it is recommended to disjoint them.

Hi Eitan, 

1. It will be great if we warn about this situation and also warn about overlapping ranges within the same mac pool. This may be very helpful for the user/admin

2. a. I'm confused, the message contain the same m3 MAC pool name that has an overlap? i expected to see 2 different MAC pool names..with which other MAC pools it is overlapping? very confusing message. I expect to see the other MAC pool name as well. I got very confused by this message.

2. b. ACK

Comment 3 eraviv 2018-10-25 07:06:29 UTC
1. ok
2. will log pool name instead of id

Comment 4 eraviv 2018-10-28 09:04:43 UTC
Michael, please confirm new message for inter-mac-pool overlaps:

EVENT_ID: MAC_POOL_VIOLATES_NO_OVERLAPPING_MAC_POOLS(10,925), MAC pools containing ranges overlapping ranges in other mac pools found: ['m2' & 'Default'], ['m2' & 'm3'], ['Default' & 'm3']. All MAC pools remain usable but it is recommended to disjoint them. Inter MAC pool overlap may cause MAC roaming between pools.

Comment 10 Michael Burman 2018-11-11 09:15:48 UTC
Verified upstream on - 4.2.8-0.0.master.20181107085801.git20768fb.el7

If there are overlapping ranges in the system(both inter-mac-pool and intra-mac-pool) we will see the next warnings on 4.2.8 on every engine start or after engine restart -  

- Inter -

MAC pool 'mac1' contains overlapping ranges: [00:00:00:00:00:65-00:00:00:00:00:75, 00:00:00:00:00:70-00:00:00:00:00:85]. All ranges remain usable but it is recommended to disjoint them.

MAC pool 'mac3' contains overlapping ranges: [00:00:00:00:00:65-00:00:00:00:00:85, 00:00:00:00:00:75-00:00:00:00:00:90]. All ranges remain usable but it is recommended to disjoint them.

- Intra- 

Found MAC pools with overlapping ranges: [a range in 'mac3' overlaps a range in 'mac1'], [a range in 'mac2' overlaps a range in 'mac1'], [a range in 'mac2' overlaps a range in 'mac3']. An overlap of ranges between two MAC pools may cause unexpected behavior, see BZ1593800

Comment 11 RHV bug bot 2018-11-28 14:37:48 UTC
WARN: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Found non-acked flags: '{'rhevm-4.2.z': '?'}', ]

For more info please contact: rhv-devops: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Found non-acked flags: '{'rhevm-4.2.z': '?'}', ]

For more info please contact: rhv-devops

Comment 12 eraviv 2018-11-28 15:19:28 UTC
add doc text

Comment 14 Raz Tamir 2018-11-30 11:30:10 UTC
QE verification bot: the bug was verified upstream

Comment 16 errata-xmlrpc 2019-01-22 12:44:50 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0121


Note You need to log in before you can comment on or make changes to this bug.