Bug 1639557 - Unable to remove catalog items from Catalog Bundle resource list
Summary: Unable to remove catalog items from Catalog Bundle resource list
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.10.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.10.0
Assignee: Hilda Stastna
QA Contact: Niyaz Akhtar Ansari
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On:
Blocks: 1615853
TreeView+ depends on / blocked
 
Reported: 2018-10-16 05:17 UTC by Niyaz Akhtar Ansari
Modified: 2019-02-12 16:52 UTC (History)
7 users (show)

Fixed In Version: 5.10.0.22
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-12 16:52:56 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screenshot (104.73 KB, image/png)
2018-10-16 05:17 UTC, Niyaz Akhtar Ansari
no flags Details

Description Niyaz Akhtar Ansari 2018-10-16 05:17:52 UTC
Created attachment 1494232 [details]
screenshot

Description of problem:


Version-Release number of selected component (if applicable):
Version 5.10.0.19.20181009184346_1c8bf5d


How reproducible:
100%

Steps to Reproduce:
1.Create 2 catalog items and add them into catalog bundle
2.Remove it from Selected Resources

Actual results:
unable to remove catalog_item from Selected resources list.It throws an error in production log.

Expected results:


Additional info:
production log:

[----] I, [2018-10-16T01:09:54.756353 #12168:17b77d4]  INFO -- : Started POST "/catalog/resource_delete/new?grp_id=0&rec_id=4" for 127.0.0.1 at 2018-10-16 01:09:54 -0400
[----] I, [2018-10-16T01:09:54.760029 #12168:17b77d4]  INFO -- : Processing by CatalogController#resource_delete as JS
[----] I, [2018-10-16T01:09:54.760184 #12168:17b77d4]  INFO -- :   Parameters: {"grp_id"=>"0", "rec_id"=>"4", "id"=>"new"}
[----] I, [2018-10-16T01:09:54.791888 #12168:17b77d4]  INFO -- :   Rendered /opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-f80f95c0236a/app/views/layouts/_tree.html.haml (0.5ms)
[----] I, [2018-10-16T01:09:54.792077 #12168:17b77d4]  INFO -- :   Rendered /opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-f80f95c0236a/app/views/shared/_tree.html.haml (0.9ms)
[----] I, [2018-10-16T01:09:54.792942 #12168:17b77d4]  INFO -- :   Rendered /opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-f80f95c0236a/app/views/layouts/_ae_tree_select.html.haml (2.0ms)
[----] I, [2018-10-16T01:09:54.794960 #12168:17b77d4]  INFO -- :   Rendered /opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-f80f95c0236a/app/views/catalog/_form_basic_info.html.haml (4.4ms)
[----] F, [2018-10-16T01:09:54.795287 #12168:17b77d4] FATAL -- : Error caught: [ActionView::Template::Error] no implicit conversion of nil into Array
/opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-f80f95c0236a/app/views/catalog/_form_basic_info.html.haml:34:in `+'
/opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-f80f95c0236a/app/views/catalog/_form_basic_info.html.haml:34:in `__opt_rh_cfme_gemset_bundler_gems_cfme_ui_classic_f__f__c____a_app_views_catalog__form_basic_info_html_haml___2559668064223908371_187026740'
/opt/rh/cfme-gemset/gems/actionview-5.0.7/lib/action_view/template.rb:159:in `block in render'
/opt/rh/cfme-gemset/gems/activesupport-5.0.7/lib/active_support/notifications.rb:166:in `instrument'
/opt/rh/cfme-gemset/gems/actionview-5.0.7/lib/action_view/template.rb:354:in `instrument'
/opt/rh/cfme-gemset/gems/actionview-5.0.7/lib/action_view/template.rb:157:in `render'
/opt/rh/cfme-gemset/gems/actionview-5.0.7/lib/action_view/renderer/partial_renderer.rb:343:in `render_partial'
/opt/rh/cfme-gemset/gems/actionview-5.0.7/lib/action_view/renderer/partial_renderer.rb:311:in `block in render'
/opt/rh/cfme-gemset/gems/actionview-5.0.7/lib/action_view/renderer/abstract_renderer.rb:42:in `block in instrument'
/opt/rh/cfme-gemset/gems/activesupport-5.0.7/lib/active_support/notifications.rb:164:in `block in instrument'
/opt/rh/cfme-gemset/gems/activesupport-5.0.7/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
/opt/rh/cfme-gemset/gems/activesupport-5.0.7/lib/active_support/notifications.rb:164:in `instrument'
/opt/rh/cfme-gemset/gems/actionview-5.0.7/lib/action_view/renderer/abstract_renderer.rb:41:in `instrument'
/opt/rh/cfme-gemset/gems/actionview-5.0.7/lib/action_view/renderer/partial_renderer.rb:310:in `render'
/opt/rh/cfme-gemset/gems/actionview-5.0.7/lib/action_view/renderer/renderer.rb:47:in `render_partial'
/opt/rh/cfme-gemset/gems/actionview-5.0.7/lib/action_view/renderer/renderer.rb:21:in `render'
/opt/rh/cfme-gemset/gems/actionview-5.0.7/lib/action_view/helpers/rendering_helper.rb:32:in `render'
/opt/rh/cfme-gemset/bundler/gems/jquery-rjs-ded3d28d0049/lib/action_view/helpers/jquery_helper.rb:566:in `block in render'
/opt/rh/cfme-gemset/bundler/gems/jquery-rjs-ded3d28d0049/lib/action_view/helpers/jquery_helper.rb:579:in `with_formats'
/opt/rh/cfme-gemset/bundler/gems/jquery-rjs-ded3d28d0049/lib/action_view/helpers/jquery_helper.rb:563:in `render'
/opt/rh/cfme-gemset/bundler/gems/jquery-rjs-ded3d28d0049/lib/action_view/helpers/jquery_helper.rb:381:in `replace'
/opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-f80f95c0236a/app/controllers/catalog_controller.rb:447:in `block in resource_delete'
/opt/rh/cfme-gemset/bundler/gems/jquery-rjs-ded3d28d0049/lib/action_view/helpers/jquery_helper.rb:154:in `instance_exec'
/opt/rh/cfme-gemset/bundler/gems/jquery-rjs-ded3d28d0049/lib/action_view/helpers/jquery_helper.rb:154:in `block in initialize'
/opt/rh/cfme-gemset/gems/actionview-5.0.7/lib/action_view/helpers/capture_helper.rb:203:in `with_output_buffer'
/opt/rh/cfme-gemset/bundler/gems/jquery-rjs-ded3d28d0049/lib/action_view/helpers/jquery_helper.rb:153:in `initialize'
/opt/rh/cfme-gemset/bundler/gems/jquery-rjs-ded3d28d0049/lib/jquery-rjs/renderers.rb:7:in `new'
/opt/rh/cfme-gemset/bundler/gems/jquery-rjs-ded3d28d0049/lib/jquery-rjs/renderers.rb:7:in `block in <module:Renderers>'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_controller/metal/renderers.rb:150:in `block in _render_to_body_with_renderer'
/usr/share/ruby/set.rb:324:in `each_key'
/usr/share/ruby/set.rb:324:in `each'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_controller/metal/renderers.rb:146:in `_render_to_body_with_renderer'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_controller/metal/renderers.rb:142:in `render_to_body'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/abstract_controller/rendering.rb:26:in `render'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_controller/metal/rendering.rb:36:in `render'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_controller/metal/instrumentation.rb:44:in `block (2 levels) in render'
/opt/rh/cfme-gemset/gems/activesupport-5.0.7/lib/active_support/core_ext/benchmark.rb:12:in `block in ms'
/usr/share/ruby/benchmark.rb:308:in `realtime'
/opt/rh/cfme-gemset/gems/activesupport-5.0.7/lib/active_support/core_ext/benchmark.rb:12:in `ms'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_controller/metal/instrumentation.rb:44:in `block in render'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_controller/metal/instrumentation.rb:87:in `cleanup_view_runtime'
/opt/rh/cfme-gemset/gems/activerecord-5.0.7/lib/active_record/railties/controller_runtime.rb:25:in `cleanup_view_runtime'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_controller/metal/instrumentation.rb:43:in `render'
/opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-f80f95c0236a/app/controllers/catalog_controller.rb:445:in `resource_delete'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_controller/metal/basic_implicit_render.rb:4:in `send_action'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/abstract_controller/base.rb:188:in `process_action'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_controller/metal/rendering.rb:30:in `process_action'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/abstract_controller/callbacks.rb:20:in `block in process_action'
/opt/rh/cfme-gemset/gems/activesupport-5.0.7/lib/active_support/callbacks.rb:126:in `call'
/opt/rh/cfme-gemset/gems/activesupport-5.0.7/lib/active_support/callbacks.rb:506:in `block (2 levels) in compile'
/opt/rh/cfme-gemset/gems/activesupport-5.0.7/lib/active_support/callbacks.rb:455:in `call'
/opt/rh/cfme-gemset/gems/activesupport-5.0.7/lib/active_support/callbacks.rb:101:in `__run_callbacks__'
/opt/rh/cfme-gemset/gems/activesupport-5.0.7/lib/active_support/callbacks.rb:750:in `_run_process_action_callbacks'
/opt/rh/cfme-gemset/gems/activesupport-5.0.7/lib/active_support/callbacks.rb:90:in `run_callbacks'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/abstract_controller/callbacks.rb:19:in `process_action'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_controller/metal/rescue.rb:20:in `process_action'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_controller/metal/instrumentation.rb:32:in `block in process_action'
/opt/rh/cfme-gemset/gems/activesupport-5.0.7/lib/active_support/notifications.rb:164:in `block in instrument'
/opt/rh/cfme-gemset/gems/activesupport-5.0.7/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
/opt/rh/cfme-gemset/gems/activesupport-5.0.7/lib/active_support/notifications.rb:164:in `instrument'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_controller/metal/instrumentation.rb:30:in `process_action'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_controller/metal/params_wrapper.rb:248:in `process_action'
/opt/rh/cfme-gemset/gems/activerecord-5.0.7/lib/active_record/railties/controller_runtime.rb:18:in `process_action'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/abstract_controller/base.rb:126:in `process'
/opt/rh/cfme-gemset/gems/actionview-5.0.7/lib/action_view/rendering.rb:30:in `process'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_controller/metal.rb:190:in `dispatch'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_controller/metal.rb:262:in `dispatch'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_dispatch/routing/route_set.rb:50:in `dispatch'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_dispatch/routing/route_set.rb:32:in `serve'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_dispatch/journey/router.rb:39:in `block in serve'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_dispatch/journey/router.rb:26:in `each'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_dispatch/journey/router.rb:26:in `serve'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_dispatch/routing/route_set.rb:727:in `call'
/opt/rh/cfme-gemset/bundler/gems/cfme-graphql-677e637b8dd3/lib/manageiq/graphql/rest_api_proxy.rb:18:in `call'
/opt/rh/cfme-gemset/gems/secure_headers-3.0.3/lib/secure_headers/middleware.rb:10:in `call'
/var/www/miq/vmdb/lib/request_started_on_middleware.rb:12:in `call'
/opt/rh/cfme-gemset/gems/rack-2.0.5/lib/rack/etag.rb:25:in `call'
/opt/rh/cfme-gemset/gems/rack-2.0.5/lib/rack/conditional_get.rb:38:in `call'
/opt/rh/cfme-gemset/gems/rack-2.0.5/lib/rack/head.rb:12:in `call'
/opt/rh/cfme-gemset/gems/rack-2.0.5/lib/rack/session/abstract/id.rb:232:in `context'
/opt/rh/cfme-gemset/gems/rack-2.0.5/lib/rack/session/abstract/id.rb:226:in `call'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_dispatch/middleware/cookies.rb:613:in `call'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_dispatch/middleware/callbacks.rb:38:in `block in call'
/opt/rh/cfme-gemset/gems/activesupport-5.0.7/lib/active_support/callbacks.rb:97:in `__run_callbacks__'
/opt/rh/cfme-gemset/gems/activesupport-5.0.7/lib/active_support/callbacks.rb:750:in `_run_call_callbacks'
/opt/rh/cfme-gemset/gems/activesupport-5.0.7/lib/active_support/callbacks.rb:90:in `run_callbacks'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_dispatch/middleware/callbacks.rb:36:in `call'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_dispatch/middleware/remote_ip.rb:79:in `call'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_dispatch/middleware/debug_exceptions.rb:49:in `call'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_dispatch/middleware/show_exceptions.rb:31:in `call'
/opt/rh/cfme-gemset/gems/railties-5.0.7/lib/rails/rack/logger.rb:36:in `call_app'
/opt/rh/cfme-gemset/gems/railties-5.0.7/lib/rails/rack/logger.rb:26:in `call'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_dispatch/middleware/request_id.rb:24:in `call'
/opt/rh/cfme-gemset/gems/rack-2.0.5/lib/rack/method_override.rb:22:in `call'
/opt/rh/cfme-gemset/gems/rack-2.0.5/lib/rack/runtime.rb:22:in `call'
/opt/rh/cfme-gemset/gems/activesupport-5.0.7/lib/active_support/cache/strategy/local_cache_middleware.rb:28:in `call'
/opt/rh/cfme-gemset/gems/actionpack-5.0.7/lib/action_dispatch/middleware/executor.rb:12:in `call'
/opt/rh/cfme-gemset/gems/rack-2.0.5/lib/rack/sendfile.rb:111:in `call'
/opt/rh/cfme-gemset/gems/railties-5.0.7/lib/rails/engine.rb:522:in `call'
/usr/share/gems/gems/puma-3.7.1/lib/puma/configuration.rb:232:in `call'
/usr/share/gems/gems/puma-3.7.1/lib/puma/server.rb:578:in `handle_request'
/usr/share/gems/gems/puma-3.7.1/lib/puma/server.rb:415:in `process_client'
/usr/share/gems/gems/puma-3.7.1/lib/puma/server.rb:275:in `block in run'
/usr/share/gems/gems/puma-3.7.1/lib/puma/thread_pool.rb:120:in `block in spawn_thread'

Comment 3 Hilda Stastna 2018-10-24 15:33:00 UTC
fixing https://github.com/ManageIQ/manageiq-ui-classic/pull/4822

Comment 4 CFME Bot 2018-10-25 11:41:31 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/e025500ea244353815bea877619f17e292d4878a
commit e025500ea244353815bea877619f17e292d4878a
Author:     Hilda Stastna <hstastna>
AuthorDate: Wed Oct 24 11:17:31 2018 -0400
Commit:     Hilda Stastna <hstastna>
CommitDate: Wed Oct 24 11:17:31 2018 -0400

    Fix removing catalog items from Catalog Bundle resource list

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1639557

 app/controllers/catalog_controller.rb | 1 +
 1 file changed, 1 insertion(+)

Comment 5 CFME Bot 2018-10-25 17:46:48 UTC
New commit detected on ManageIQ/manageiq-ui-classic/hammer:

https://github.com/ManageIQ/manageiq-ui-classic/commit/f6a73d98f4dde493c7b3cac8fec931624c263714
commit f6a73d98f4dde493c7b3cac8fec931624c263714
Author:     Milan Zázrivec <mzazrivec>
AuthorDate: Thu Oct 25 07:40:19 2018 -0400
Commit:     Milan Zázrivec <mzazrivec>
CommitDate: Thu Oct 25 07:40:19 2018 -0400

    Merge pull request #4822 from hstastna/Unable_remove_catalog_items_Catalog_Bundle

    Fix removing catalog items from Catalog Bundle resource list

    (cherry picked from commit 34daad85cb744ac933c33a49af10ee9e1d394a5e)

    https://bugzilla.redhat.com/show_bug.cgi?id=1639557

 app/controllers/catalog_controller.rb | 1 +
 spec/controllers/catalog_controller_spec.rb | 18 +
 2 files changed, 19 insertions(+)

Comment 6 Niyaz Akhtar Ansari 2018-11-01 05:04:04 UTC
Verified in Version 5.10.0.22.20181030184024_26956a0


Note You need to log in before you can comment on or make changes to this bug.