Bug 1639988

Description of problem:

Starting with Red Hat Satellite 6.3.4 adding Host Parameters to an existing host is failing. Somehow the application logic seems to duplicate the Host Parameter added and then complains that the name is already taken.

Foreman production log looks as following.

2018-10-17 01:35:47 5d37ca92 [app] [I] Started PATCH "/hosts/1" for 10.36.116.118 at 2018-10-17 01:35:47 -0400
2018-10-17 01:35:47 5d37ca92 [app] [I] Processing by HostsController#update as */*
2018-10-17 01:35:47 5d37ca92 [app] [I]   Parameters: {"utf8"=>"✓", "authenticity_token"=>"<removed>", "host"=>{"name"=>"test001", "hostgroup_id"=>"1", "content_facet_attributes"=>{"lifecycle_environment_id"=>"1", "content_view_id"=>"1", "content_source_id"=>"1"}, "environment_id"=>"1", "puppet_proxy_id"=>"1", "puppet_ca_proxy_id"=>"1", "openscap_proxy_id"=>"", "puppetclass_ids"=>[""], "managed"=>"true", "progress_report_id"=>"[FILTERED]", "interfaces_attributes"=>{"0"=>{"_destroy"=>"0", "mac"=>"00:00:00:00:00:00", "identifier"=>"", "name"=>"test001", "domain_id"=>"1", "ip"=>"", "ip6"=>"", "managed"=>"1", "primary"=>"1", "provision"=>"1", "execution"=>"1", "tag"=>"", "attached_to"=>"", "id"=>"1"}}, "architecture_id"=>"1", "operatingsystem_id"=>"1", "ptable_id"=>"92", "pxe_loader"=>"PXELinux BIOS", "disk"=>"", "host_parameters_attributes"=>{"1539754531336"=>{"name"=>"FIREWALL", "value"=>"[FILTERED]", "hidden_value"=>"[FILTERED]", "_destroy"=>"false"}}, "is_owned_by"=>"3-Users", "enabled"=>"1", "model_id"=>"", "comment"=>"", "overwrite"=>"false"}, "bare_metal_capabilities"=>"build", "id"=>"1"}
2018-10-17 01:35:47 5d37ca92 [app] [I] Current user: admin (administrator)
2018-10-17 01:35:47 5d37ca92 [app] [D] Setting current user thread-local variable to admin
2018-10-17 01:35:47 5d37ca92 [app] [I] Expire fragment views/tabs_and_title_records-3 (0.1ms)
2018-10-17 01:35:47 5d37ca92 [app] [D] Setting current location thread-local variable to none
2018-10-17 01:35:47 5d37ca92 [app] [D] Setting current organization thread-local variable to none
2018-10-17 01:35:47 5d37ca92 [app] [D] Setting current organization thread-local variable to none
2018-10-17 01:35:47 5d37ca92 [app] [D] Setting current location thread-local variable to none
2018-10-17 01:35:47 5d37ca92 [app] [D] Unpermitted parameters: utf8, _method, authenticity_token, bare_metal_capabilities, id, locale
2018-10-17 01:35:47 5d37ca92 [app] [I] Failed to save: Host parameters Please ensure the following parameters name are unique
2018-10-17 01:35:47 5d37ca92 [app] [D] Deface: 1 overrides found for 'hosts/_form'
2018-10-17 01:35:47 5d37ca92 [app] [D] Deface: 'add_execution_interface_js' matched 1 times with 'div#primary'
2018-10-17 01:35:47 5d37ca92 [app] [I] Deface: [WARNING] No :original defined for 'add_execution_interface_js', you should change its definition to include:
 |  :original => '6771be87072b3f2a046d4a6ab34d5432aa443ec6' 

Using `hammer` instead is not possible because of https://bugzilla.redhat.com/show_bug.cgi?id=1554774.

It also seems that this issue was found in Red Hat Satellite 6.4 BETA and was fixed in there https://bugzilla.redhat.com/show_bug.cgi?id=1609764

But since Red Hat Satellite 6.4 was just released we can not expect the customer to update right away and thus require a fix for the issue in Red Hat Satellite 6.3.4

Version-Release number of selected component (if applicable):

 - satellite-6.3.4-2.el7sat.noarch

How reproducible:

 - Always

Steps to Reproduce:
1. Navigate to Hosts > All Hosts > *select* > Edit > Parameters
2. Button Add Parameter
3. Fill any values to Name and Value
4. Submit

Actual results:
All entered Host Parameters are shown twice and there is an error message saying "Name has already been taken" 

Expected results:
Host Parameter is added

Additional info:
This was working on Red Hat Satellite 6.3.3 and is therefore considered a regression