Bug 1640497 - [3.11]ASB gets installed during upgrade even though ansible_service_broker_install is set to false.
Summary: [3.11]ASB gets installed during upgrade even though ansible_service_broker_in...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Cluster Version Operator
Version: 3.11.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 3.11.z
Assignee: Jeremiah Stuever
QA Contact: Weihua Meng
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-10-18 08:44 UTC by Weihua Meng
Modified: 2018-12-12 14:16 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1632397
Environment:
Last Closed: 2018-12-12 14:15:51 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:3743 0 None None None 2018-12-12 14:16:01 UTC

Description Weihua Meng 2018-10-18 08:44:50 UTC
3.11 has this issue too
openshift-ansible-3.11.23-1.git.0.19cbe21.el7.noarch

+++ This bug was initially created as a clone of Bug #1632397 +++

Description of problem:

 ASB gets installed during upgrade even though ansible_service_broker_install is set to true. 


Version-Release number of selected component (if applicable):
3.10

How reproducible:
100%

Steps to Reproduce:
1. Install 3.9 cluster with ansible_service_broker_install=false
2. Upgrade to 3.10 with ansible_service_broker_install=false

Actual results:
ASB gets installed 


Expected results:
Skip installing ASB


Additional info:
For upgrades the conditional is used openshift_enable_service_catalog=true, when deciding to install the ASB 

```
   https://github.com/openshift/openshift-ansible/blob/master/playbooks/common/openshift-cluster/upgrades/upgrade_components.yml#L7-L21

  - import_role:
      name: ansible_service_broker
      tasks_from: install.yml
    when:
    - openshift_enable_service_catalog | default(true) | bool
```

For installs the conditional is used looking for ansible_service_broker_install=true.

https://github.com/openshift/openshift-ansible/blob/master/roles/ansible_service_broker/tasks/main.yml

  - include_tasks: install.yml
    when: ansible_service_broker_install | bool

--- Additional comment from Aleks Lazic on 2018-10-10 04:45:25 EDT ---

We face the same problem at the update from 3.9 -> 3.9.

`ansible_service_broker_install=false` is in the hosts file but the following command want do uodate ansible broker

ansible-playbook -i /tmp/ose-hosts /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_9/upgrade_control_plane.yml

Looks like there is a pull request which fixes this bug.

https://github.com/openshift/openshift-ansible/pull/9770

Any Idea when this fix will be available on 3.9 rpms?

Comment 1 Jeremiah Stuever 2018-11-21 16:11:39 UTC
https://github.com/openshift/openshift-ansible/pull/10683

Comment 5 Weihua Meng 2018-12-04 06:17:40 UTC
Fixed.

openshift-ansible-3.11.51-1.git.0.51c90a3.el7.noarch

Kernel Version: 3.10.0-957.el7.x86_64
Operating System: Red Hat Enterprise Linux Server 7.6 (Maipo)

Comment 7 errata-xmlrpc 2018-12-12 14:15:51 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3743


Note You need to log in before you can comment on or make changes to this bug.