Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1640498

Summary: [3.9]ASB gets installed during upgrade even though ansible_service_broker_install is set to false.
Product: OpenShift Container Platform Reporter: Weihua Meng <wmeng>
Component: Cluster Version OperatorAssignee: Jeremiah Stuever <jstuever>
Status: CLOSED ERRATA QA Contact: Weihua Meng <wmeng>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.9.0CC: aleks, aos-bugs, jiajliu, jokerman, jstuever, mmccomas, rhowe, rjh, sdodson
Target Milestone: ---Keywords: Triaged
Target Release: 3.9.z   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1632397 Environment:
Last Closed: 2018-12-13 19:27:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Weihua Meng 2018-10-18 08:47:06 UTC 
3.9 has this issue too
openshift-ansible-3.9.47-1.git.0.8180c87.el7.noarch

+++ This bug was initially created as a clone of Bug #1632397 +++

Description of problem:

 ASB gets installed during upgrade even though ansible_service_broker_install is set to true. 


Version-Release number of selected component (if applicable):
3.10

How reproducible:
100%

Steps to Reproduce:
1. Install 3.9 cluster with ansible_service_broker_install=false
2. Upgrade to 3.10 with ansible_service_broker_install=false

Actual results:
ASB gets installed 


Expected results:
Skip installing ASB


Additional info:
For upgrades the conditional is used openshift_enable_service_catalog=true, when deciding to install the ASB 

```
   https://github.com/openshift/openshift-ansible/blob/master/playbooks/common/openshift-cluster/upgrades/upgrade_components.yml#L7-L21

  - import_role:
      name: ansible_service_broker
      tasks_from: install.yml
    when:
    - openshift_enable_service_catalog | default(true) | bool
```

For installs the conditional is used looking for ansible_service_broker_install=true.

https://github.com/openshift/openshift-ansible/blob/master/roles/ansible_service_broker/tasks/main.yml

  - include_tasks: install.yml
    when: ansible_service_broker_install | bool

--- Additional comment from Aleks Lazic on 2018-10-10 04:45:25 EDT ---

We face the same problem at the update from 3.9 -> 3.9.

`ansible_service_broker_install=false` is in the hosts file but the following command want do uodate ansible broker

ansible-playbook -i /tmp/ose-hosts /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_9/upgrade_control_plane.yml

Looks like there is a pull request which fixes this bug.

https://github.com/openshift/openshift-ansible/pull/9770

Any Idea when this fix will be available on 3.9 rpms?
Comment 1 Rune Henriksen 2018-10-25 16:34:36 UTC 
This also happens for minor upgrades within 3.10. It's super annoying because ASB occasionally breaks the Ansible playbook run...
Comment 2 Jeremiah Stuever 2018-11-21 16:27:25 UTC 
https://github.com/openshift/openshift-ansible/pull/10744
Comment 3 Weihua Meng 2018-11-26 06:08:30 UTC 
Fixed.

openshift-ansible-3.9.54-1.git.0.8a67eb1.el7.noarch

Kernel Version: 3.10.0-957.el7.x86_64
Operating System: Red Hat Enterprise Linux Server 7.6 (Maipo)
Comment 6 errata-xmlrpc 2018-12-13 19:27:05 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3748