Bug 1642286 - Server dvd: anaconda warns about being installing a prerelease
Summary: Server dvd: anaconda warns about being installing a prerelease
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 29
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Anaconda Maintenance Team
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: F29FinalBlocker
TreeView+ depends on / blocked
Reported: 2018-10-24 06:38 UTC by Julen Landa Alustiza
Modified: 2018-10-24 12:33 UTC (History)
14 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2018-10-24 12:33:32 UTC
Type: Bug

Attachments (Terms of Use)
Screenshot (107.53 KB, image/png)
2018-10-24 06:38 UTC, Julen Landa Alustiza
no flags Details

Description Julen Landa Alustiza 2018-10-24 06:38:56 UTC
Created attachment 1496910 [details]

Description of problem:

While installing from Fedora-Server-dvd-x86_64-29-20181022.n.1.iso anaconda continues warning me about being installing a prerelease

Version-Release number of selected component (if applicable): 20181022 compose server dvd

How reproducible:

Boot from https://dl.fedoraproject.org/pub/fedora/linux/development/29/Server/x86_64/iso/Fedora-Server-dvd-x86_64-29-20181022.n.1.iso , start installation process

Actual results: Anaconda warns about being installing a prerelease version

Expected results: No disclaimer about prereleases

Comment 1 Fedora Blocker Bugs Application 2018-10-24 06:41:18 UTC
Proposed as a Blocker for 29-final by Fedora user jlanda using the blocker tracking app because:

 server dvd continues warning about prerelease.

Pre-release notices criteria: No notices or alerts about pre-release status may be shown as part of installation or critical path actions on release-blocking desktops.

Comment 2 Julen Landa Alustiza 2018-10-24 06:45:52 UTC
server netinst is affected too

Comment 3 Julen Landa Alustiza 2018-10-24 07:18:07 UTC
Affected isos so far:

server-dvd, server-netinstall, everything-netinstall, wks-netinstall

Unaffected ones:

Affected isos are affected by https://bugzilla.redhat.com/show_bug.cgi?id=1642089 too, so I suspect that actually it's the same bug.

Comment 4 Kalev Lember 2018-10-24 07:23:29 UTC
I believe this is just the nightlies compose configuration and RC configuration that releng uses for spinning RCs disables the prerelease warning.

Comment 5 Kamil Páral 2018-10-24 08:22:13 UTC
I guess you're right Kalev. However, I can confirm that Workstation Live 20181022 doesn't contain the warning while other images do. Also, Workstation Live 20181014 does contain the warning! So something fishing is going on here. I believe releng (and possibly) need to look into this.

CC Mohan.

+1 blocker technically, whether it means a code change or just a releng configuration change

Comment 6 Lukas Ruzicka 2018-10-24 09:08:40 UTC
I would rather believe that the RC candidate should have this warning switched off, as nightly builds are technically still Beta, ergo a pre-release. 

I am +1 blocker to make sure this gets a proper treatment.

Comment 7 Kamil Páral 2018-10-24 09:25:13 UTC
From #fedora-releng:

<kparal> is here anyone who knows how the pre-release warning in anaconda is configured? is it a releng config file?
<lsedlar> kparal, it's mostly automatic: when an RC compose is done, Pungi knows it's RC based on the compose label, and calls lorax with --isfinal option; which causes .buildstamp in the boot media to contain IsFinal=True and anaconda looks at that (I think)
<kparal> lsedlar: thanks. so how can we explain this? https://bugzilla.redhat.com/show_bug.cgi?id=1642286#c5
<lsedlar> kparal, I can't, I think even the workstation live should have it; maybe try asking someone from anaconda
<kparal> ok, thanks
<lsedlar> the .buildstamp in workstation initrd.img has IsFinal=False

Comment 8 Martin Kolman 2018-10-24 10:49:44 UTC
On closer look this might not actually be a bug, rather confusion about the pre-release vs release/RC compose process for the DVD/netinst images.

According to my discussion with Fedora QA the difference between a pre-release and RC compose is:
- isFinal=True in .buildstamp
- the updates testing repo file in the fedora repos package has enabled=0

Also, as I've been told no such RC compose has yet been run.

Therefore the behavior the description talks about is apparently correct, as no RC compose has yet been done and any currently existing netinst/DVD image will be pre-release.

On the other hand, there seems to be an actual bug with the Live image, where Anaconda *does* behave as on a RC, even if it should not (as there is no RC yet).

Comment 9 Vendula Poncova 2018-10-24 11:59:57 UTC
Workstation Live is not related to this bug, because live images don't have the .buildstamp file. Anaconda uses workarounds to detect information about the release.

In case of the isFinal flag, Anaconda runs this piece of code:

RELEASE=$(rpm -q --qf '%{Release}' --whatprovides system-release)

if [ "${RELEASE:0:2}" = "0." ]; then
    export ANACONDA_ISFINAL="false"
    export ANACONDA_ISFINAL="true"

These are results from Fedora-Workstation-Live-x86_64-29-20181022.n.1.iso:

$ rpm -q --whatprovides system-release

$ rpm -q --qf '%{Release}' --whatprovides system-release

$ echo "${RELEASE:0:2}"

The release is considered to be final.

Comment 10 Kamil Páral 2018-10-24 12:33:32 UTC
Or in other words, once fedora-release has the release tag "-1" or greater, it's considered final, otherwise it's not, and that affects the pre-release warning on Live. I'm closing this as a NOTABUG, because this behavior has been with us for a long time (we just didn't notice before, I guess, or the timing with fedora-release was different). Anyway, shouldn't negatively affect the RC composes. We can talk about improving the anaconda+releng synchronization for the next releases.

Note You need to log in before you can comment on or make changes to this bug.