Bug 1642469 - Grammar and spelling bugs in Admin Portal
Summary: Grammar and spelling bugs in Admin Portal
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: ---
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ovirt-4.4.1
: ---
Assignee: Steve Goodman
QA Contact: Pavel Novotny
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-10-24 13:19 UTC by Steve Goodman
Modified: 2020-08-05 06:24 UTC (History)
3 users (show)

Fixed In Version: rhv-4.4.1-10
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-05 06:24:47 UTC
oVirt Team: Virt
Embargoed:
pm-rhel: ovirt-4.4+


Attachments (Terms of Use)
Screenshot showing the bug described here. (62.83 KB, image/png)
2018-10-24 13:19 UTC, Steve Goodman
no flags Details
host / Kernel tab text fixed (60.29 KB, image/png)
2020-07-14 13:24 UTC, Pavel Novotny
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 107827 0 master MERGED webadmin: Fix text in Kernel boot parameters 2020-08-17 12:37:29 UTC

Description Steve Goodman 2018-10-24 13:19:05 UTC
Created attachment 1497029 [details]
Screenshot showing the bug described here.

Description of problem:

In Admin portal go to Compute > Hosts > Edit > Kernel tab


It says:

Modifying kernel boot parameters settings can lead to a host boot failure. Please consult the documentation before doing any changes.

Kernel boot parameters changes require host deploy and restart. The host needs to be REINSTALLED suceesfully and then to be REBOOTED for kernel boot parameters to be applied!


Do you mean update the host, redeploy it or reinstall it? Don't use "redeploy" in one sentence and "reinstall" in another to mean to the same thing. When I see "REINSTALL" here, it sounds like I need to reinstall the entire host OS on my bare metal machine. Does this mean update the host OS? Does this mean something else?


As far as grammar and spelling, this is better, and I changed "REINSTALL" to "REDPLOYMENT":

Modifying kernel boot parameter settings can lead to a host boot failure. Please consult the documentation before changing any host boot parameters.

After changing kernel boot parameters, you must redeploy and restart the host. Kernel boot parameters are applied only after a successful REDEPLOYMENT and REBOOT!

Comment 1 Ryan Barry 2018-10-25 10:53:11 UTC
Under the host actions in RHVM, you'll see "Reinstall" as an option. In this context, "Reinstall" is not confusing.

Probably we should change the instance of "changes require host deploy" to "changes require the host to be reinstalled" to keep it consistent.

Comment 2 Ryan Barry 2019-01-21 14:53:52 UTC
Re-targeting to 4.3.1 since it is missing a patch, an acked blocker flag, or both

Comment 4 Steve Goodman 2020-03-23 06:18:14 UTC
I think this is low-hanging fruit and I'd like to try to fix it myself. I'm marking it as low instead of medium, since it was low enough priority to close it with WILLNOTFIX.

Comment 5 Steve Goodman 2020-03-23 07:24:46 UTC
Ryan,

I created a new patch in Gerrit for this. I added you as a reviewer. Who else should be reviewer?

Comment 6 Steve Goodman 2020-03-23 07:25:29 UTC
Change 107827
Change-Id: I38634f8d6e05a94f9539322b002c5a6ecb655fbc

Comment 7 Steve Goodman 2020-07-02 13:07:21 UTC
Lukas,

Please take a look at the change.

Comment 8 Pavel Novotny 2020-07-14 13:23:27 UTC
Verified in
ovirt-engine-4.4.1.8-0.7.el8ev.noarch

The text in the host -> Kernel dialog tab now says:

"""
Modifying kernel boot parameter settings can lead to a host boot failure. Please consult the documentation before changing any host boot parameters.
"""

"""
After changing kernel boot parameters, you must reinstall and reboot the host. Kernel boot parameters take effect only after successfully REINSTALLING and REBOOTING the host!
"""

Comment 9 Pavel Novotny 2020-07-14 13:24:09 UTC
Created attachment 1701026 [details]
host / Kernel tab text fixed

Comment 10 Sandro Bonazzola 2020-08-05 06:24:47 UTC
This bugzilla is included in oVirt 4.4.1 release, published on July 8th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.