Bug 164259 - local variable used before set
local variable used before set
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: subversion (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Joe Orton
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2005-07-26 08:57 EDT by David Binderman
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-07-26 09:05:19 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description David Binderman 2005-07-26 08:57:40 EDT
Description of problem:

I just tried to compile Redhat Fedora package
subversion-1.2.1-3 with the Intel C compiler version 8.1

The compiler said

subversion/libsvn_fs_base/lock.c(391): remark #592: variable "err" is used
before its value is set

The source code is

  svn_error_t *err;

  SVN_ERR (svn_fs_base__check_fs (fs));

  args.path = svn_fs_base__canonicalize_abspath (path, pool);
  args.lock_p = lock;
  return svn_fs_base__retry_txn (fs, txn_body_get_lock, &args, pool);
  return err;
}

Suggest initialise local variable "err" before first use.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Joe Orton 2005-07-26 09:05:19 EDT
The "return err" line is unreachable so there's no real bug here.  The unused
var and the unreachable line are fixed upstream already.

Note You need to log in before you can comment on or make changes to this bug.