Spec URL: https://jjames.fedorapeople.org/sirocco/sirocco.spec SRPM URL: https://jjames.fedorapeople.org/sirocco/sirocco-2.0-1.fc30.src.rpm Fedora Account System Username: jjames Description: This is a library for computing homotopy continuation of a given root of one dimensional sections of bivariate complex polynomials. The output is a piecewise linear approximation of the path followed by the root, with the property that there is a tubular neighborhood, with square transversal section, that contains the actual path, and there is a three times thicker tubular neighborhood guaranteed to contain no other root of the polynomial. This second property ensures that the piecewise linear approximation computed from all roots of a polynomial form a topologically correct deformation of the actual braid, since the inner tubular neighborhoods cannot intersect. This is a new dependency of sagemath 8.4.
- License is GPLv3 License: GPLv3 Package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "Unknown or generated". 25 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/sirocco/review-sirocco/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in sirocco- devel , sirocco-debuginfo , sirocco-debugsource [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: sirocco-2.0-1.fc30.x86_64.rpm sirocco-devel-2.0-1.fc30.x86_64.rpm sirocco-debuginfo-2.0-1.fc30.x86_64.rpm sirocco-debugsource-2.0-1.fc30.x86_64.rpm sirocco-2.0-1.fc30.src.rpm sirocco.x86_64: W: spelling-error Summary(en_US) ROot -> Root, Rot, Oort sirocco.x86_64: W: spelling-error %description -l en_US homotopy -> photocopy sirocco.x86_64: W: spelling-error %description -l en_US bivariate -> bi variate, bi-variate, variate sirocco.x86_64: W: spelling-error %description -l en_US piecewise -> piece wise, piece-wise, piecework sirocco.x86_64: W: spelling-error %description -l en_US transversal -> transverse, traversal, Transvaal sirocco-devel.x86_64: W: no-documentation sirocco.src: W: spelling-error Summary(en_US) ROot -> Root, Rot, Oort sirocco.src: W: spelling-error %description -l en_US homotopy -> photocopy sirocco.src: W: spelling-error %description -l en_US bivariate -> bi variate, bi-variate, variate sirocco.src: W: spelling-error %description -l en_US piecewise -> piece wise, piece-wise, piecework sirocco.src: W: spelling-error %description -l en_US transversal -> transverse, traversal, Transvaal 5 packages and 0 specfiles checked; 0 errors, 11 warnings.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/sirocco
Thanks for the review! (In reply to Robert-André Mauchin from comment #1) > - License is GPLv3 That's not clear. The package does contain a LICENSE file that contains the text of GPL v3, that is true. However, that alone is not sufficient to determine the license; search for "GPL+" here: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing The only statement of the license that I can find outside of the LICENSE file is in ZVK.py, which clearly states that that file, at least, is GPLv2+. Since the intersection of GPL+ and GPLv2+ is GPLv2+, I concluded that that is the correct license for this package. I will ask upstream to clarify.
Built in Rawhide.