Description of problem: The #merged_uri method in FileDepot was added by a previous PR but it was missing its parameters, causing an exception when a derived class other than FileDepotSwift is invoked. Trying to DB dump to NFS, for instance, causes this issue. Version-Release number of selected component (if applicable): How reproducible: 100% Steps to Reproduce: 1. Schedule a DB Backup to an NFS FileDepot 2. 3. Actual results: Exception Expected results: Successful backup Additional info:
Fix the parent FileDepot class, adding two arguments for the URI and the port. Tests should also be added to avoid this issue in the future.
https://github.com/ManageIQ/manageiq/pull/18131
https://github.com/ManageIQ/manageiq/pull/18131 fixes this issue. Waiting for review.
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/5bca88151c1f9783f28bbb64cfaeedcecaaa12c4 commit 5bca88151c1f9783f28bbb64cfaeedcecaaa12c4 Author: Jerry Keselman <jkeselma> AuthorDate: Thu Oct 25 09:40:37 2018 -0400 Commit: Jerry Keselman <jkeselma> CommitDate: Thu Oct 25 09:40:37 2018 -0400 Fix #merged_uri parameters in FileDepot parent class The #merged_uri method in FileDepot was added by a previous PR but it was missing its parameters, causing an exception when a derived class other than FileDepotSwift is invoked. Fix the parent FileDepot class, and add tests in two derived classes - FileDepotNfs (which previously had no tests) and FileDepotFtp. It is already tested in FileDepotSwift. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1643106 app/models/file_depot.rb | 2 +- spec/models/file_depot_ftp_spec.rb | 9 +- spec/models/file_depot_nfs_spec.rb | 14 + 3 files changed, 23 insertions(+), 2 deletions(-)
New commit detected on ManageIQ/manageiq/hammer: https://github.com/ManageIQ/manageiq/commit/5d09d80b3a12c7a093d68389f79eed1a8940b314 commit 5d09d80b3a12c7a093d68389f79eed1a8940b314 Author: Nick Carboni <ncarboni> AuthorDate: Thu Oct 25 18:04:03 2018 -0400 Commit: Nick Carboni <ncarboni> CommitDate: Thu Oct 25 18:04:03 2018 -0400 Merge pull request #18131 from jerryk55/fix_merged_uri Fix Exception due to missing #merged_uri parameters in FileDepot parent class (cherry picked from commit 23574133410fac78ef8c7aa95e06decbac3517ee) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1643106 app/models/file_depot.rb | 2 +- spec/models/file_depot_ftp_spec.rb | 13 +- spec/models/file_depot_nfs_spec.rb | 23 + 3 files changed, 36 insertions(+), 2 deletions(-)
If this is about just making the db backup to NFS (I do not know where the FileDepot is used), then I have tested it today (5.10.1.2) and it worked fine and we can move this to VERIFIED
Yes that is all.
I am now not sure whether the exception was causing the backup to not get created. As this has high severity, I guess it was the case. I don't think we would have a high severity BZ just for some exception in the log. Therefore I think I can mark one of our tests as it is covering this bug. The test is not checking an error message but checks whether some backup file is created.