Bug 1643691 - Review Request: python-repomd - Library for reading dnf/yum repositories
Summary: Review Request: python-repomd - Library for reading dnf/yum repositories
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-10-27 13:00 UTC by Carl George
Modified: 2018-11-05 20:07 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-11-05 19:59:18 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Carl George 2018-10-27 13:00:49 UTC
Spec URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/python-repomd/fedora-rawhide-x86_64/00816114-python-repomd/python-repomd.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/python-repomd/fedora-rawhide-x86_64/00816114-python-repomd/python-repomd-0.1.0-1.fc30.src.rpm

Description:
This library provides an object-oriented interface to get information out of
dnf/yum repositories.

Fedora Account System Username: carlwgeorge

Comment 1 Neal Gompa 2018-10-27 22:06:15 UTC
Taking this review.

Comment 2 Neal Gompa 2018-11-04 03:25:03 UTC
Review notes:

[x]: Package is named according to package naming guidelines
[x]: Package complies with Fedora Packaging Guidelines
[x]: Package complies with Fedora Python Packaging Guidelines
[x]: Package builds and installs correctly
[x]: Package includes documentation and license content per guidelines

PACKAGE APPROVED.

Comment 3 Neal Gompa 2018-11-04 03:26:32 UTC
Some additional advice, if you want to simplify this a bit further, you can remove runtime requires from the spec if you add the following to the top of your spec:

%{?python_enable_dependency_generator}

You can see an example of its use in the kiwi and pagure packages. :)

Comment 4 Gwyn Ciesla 2018-11-05 16:15:42 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-repomd

Comment 6 Carl George 2018-11-05 20:07:29 UTC
Thanks for the suggestion Neal, I'll look into that.


Note You need to log in before you can comment on or make changes to this bug.