Bug 1643742 - Review Request: golang-etcd-bbolt - An embedded key/value database for Go
Summary: Review Request: golang-etcd-bbolt - An embedded key/value database for Go
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Elliott Sales de Andrade
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2018-10-28 08:17 UTC by Robert-André Mauchin 🐧
Modified: 2019-03-29 19:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2019-03-25 06:04:46 UTC
Type: ---
quantum.analyst: fedora-review+

Attachments (Terms of Use)

Description Robert-André Mauchin 🐧 2018-10-28 08:17:52 UTC
Spec URL: https://eclipseo.fedorapeople.org/golang-etcd-bbolt.spec
SRPM URL: https://eclipseo.fedorapeople.org/golang-etcd-bbolt-1.3.1-0.4.etcd.8.20181005git7ee3ded.fc30.src.rpm

An embedded key/value database for Go.

Fedora Account System Username: eclipseo

This is a rename of golang-github-coreos-bbolt with a new primary import path.

Comment 1 Elliott Sales de Andrade 2019-03-06 04:40:09 UTC
Update to 1.3.2 and you can drop the commit hash and 0 release.

How much memory does %gochecks use? Maybe that can be reported upstream, or
maybe it's fixed already. Also, I think builders have a ridiculous amount of
RAM... I tried uncommenting it and it uses max ~2.6 G; this should be fine,
except maybe 32-bit. Might want to try a scratch build to be sure.

Can remove the %license tag re-definition.

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Expat License", "Unknown or generated". 43 files have unknown
     license. Detailed output of licensecheck in
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/gocode/src,
     /usr/share/gocode, /usr/share/gocode/src/github.com
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
     etcd-bbolt-devel , compat-golang-github-coreos-bbolt-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.

Checking: golang-etcd-bbolt-devel-1.3.1-0.4.etcd.8.20181005git7ee3ded.fc30.x86_64.rpm
golang-etcd-bbolt-devel.x86_64: W: hidden-file-or-dir /usr/share/gocode/src/go.etcd.io/bbolt/.goipath
compat-golang-github-coreos-bbolt-devel.noarch: W: no-documentation
compat-golang-github-coreos-bbolt-devel.noarch: W: dangling-symlink /usr/share/gocode/src/github.com/coreos/bbolt /usr/share/gocode/src/go.etcd.io/bbolt
golang-etcd-bbolt.src: W: no-%build-section
3 packages and 0 specfiles checked; 0 errors, 4 warnings.

Rpmlint (installed packages)
Cannot parse rpmlint output:

compat-golang-github-coreos-bbolt-devel (rpmlib, GLIBC filtered):

golang-etcd-bbolt-devel (rpmlib, GLIBC filtered):



Source checksums
https://github.com/etcd-io/bbolt/archive/7ee3ded59d4835e10f3e7d0f7603c42aa5e83820/bbolt-7ee3ded59d4835e10f3e7d0f7603c42aa5e83820.tar.gz :
  CHECKSUM(SHA256) this package     : 7e0fb20ed8c3fd5fefb862e4a806907ade6a16655b8c168aa80939ea2c69f188
  CHECKSUM(SHA256) upstream package : 7e0fb20ed8c3fd5fefb862e4a806907ade6a16655b8c168aa80939ea2c69f188

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1643742
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP

Comment 2 Robert-André Mauchin 🐧 2019-03-06 14:54:28 UTC
Thanks for the review.

Testing: go.etcd.io/bbolt
Testing: "/builddir/build/BUILD/bbolt-1.3.2/_build/src/go.etcd.io/bbolt"
+ GOPATH=/builddir/build/BUILD/bbolt-1.3.2/_build:/usr/share/gocode
+ go test -buildmode pie -compiler gc -ldflags '-extldflags '\''-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '\'''
seed: -67168
quick settings: count=5, items=1000, ksize=1024, vsize=1024
runtime: out of memory: cannot allocate 2147483648-byte block (683245568 in use)
fatal error: out of memory

Seems it tries to allocate an enormous amount of memory at the start of testing.

Spec URL: https://eclipseo.fedorapeople.org/golang-etcd-bbolt.spec
SRPM URL: https://eclipseo.fedorapeople.org/golang-etcd-bbolt-1.3.2-1.fc31.src.rpm

Comment 3 Elliott Sales de Andrade 2019-03-06 23:57:06 UTC
That's not too large for the builders, I don't think. Just the 32-bit ones might not work due to single-process address space limitations. I thought maybe https://github.com/etcd-io/bbolt/pull/26 might help with that, but it seems to be included in this version already. I think you should be able to enable the full tests on the builders (at least x86_64 anyway).

But approved, otherwise.

Comment 4 Gwyn Ciesla 2019-03-07 15:21:22 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-etcd-bbolt

Comment 5 Fedora Update System 2019-03-07 20:32:37 UTC
golang-etcd-bbolt-1.3.2-2.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8ae4c94e3b

Comment 6 Fedora Update System 2019-03-07 20:56:43 UTC
golang-etcd-bbolt-1.3.2-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-9495d9893b

Comment 7 Fedora Update System 2019-03-08 19:45:21 UTC
golang-etcd-bbolt-1.3.2-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8ae4c94e3b

Comment 8 Fedora Update System 2019-03-08 22:40:44 UTC
golang-etcd-bbolt-1.3.2-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-9495d9893b

Comment 9 Fedora Update System 2019-03-25 06:04:46 UTC
golang-etcd-bbolt-1.3.2-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2019-03-29 19:11:01 UTC
golang-etcd-bbolt-1.3.2-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.