Created attachment 1498612 [details] log_depots Description of problem: In CFME version 5.10 there are log depots "AWS S3" and "OpenStack Swift" available, see the screenshot. However, there's no description of these features (no RFEs, no PRs). Version-Release number of selected component (if applicable): 5.10.0.21.20181023151612_4c11b0d How reproducible: Always Steps to Reproduce: 1. Go to Configuration -> Diagnostics -> Log Collection 2. Open the dropdown for Depot Type Actual results: "AWS S3" and "OpenStack Swift" are there Expected results: "AWS S3" and "OpenStack Swift" are not there or there're RFEs for these features Additional info: Most likely, this was introduced by the following PRs: https://github.com/ManageIQ/manageiq-ui-classic/pull/4300 https://github.com/ManageIQ/manageiq-ui-classic/pull/4684 I didn't find any RFEs for these features as well.
The FileDepot types for S3 and Swift were indeed added as part of the the PRs for Database Backup. I've never even looked at the "Log Collection" functionality in the UI. If the Log Collection code simply uses all available FileDepot types then unless someone hard-codes exclusions of these two storage types they would show up. I will look further into the code to validate my theory...
anything that confirms the assumption that this got introduced without an RFE?
The answer is yes, these changes to the UI were introduced without an RFE. However, since no model changes were made in support of what you are seeing in the UI, this doesn't actually work. My suggestion is a BZ should be added to remove this stuff from the UI since it doesn't work and wasn't added by anyone purposely.
The list of log collection types is currently built by pulling in all valid FileDepot types. Unfortunately, while AWS S3 and OpenStack Swift were added as FileDepots for Database backups, no work was done for Log Collection via these depots. When the list of valid types is built in the UI therefore, these two need to be removed. https://github.com/ManageIQ/manageiq-ui-classic/pull/4926 addresses this problem.
New commit detected on ManageIQ/manageiq-ui-classic/hammer: https://github.com/ManageIQ/manageiq-ui-classic/commit/46724276cb8b4416a5f484602c104b2442aab1aa commit 46724276cb8b4416a5f484602c104b2442aab1aa Author: Harpreet Kataria <hkataria> AuthorDate: Wed Nov 14 16:32:20 2018 -0500 Commit: Harpreet Kataria <hkataria> CommitDate: Wed Nov 14 16:32:20 2018 -0500 Merge pull request #4926 from jerryk55/fix_log_collection_type_list Remove S3 and Swift From List of Log Collection Types (cherry picked from commit 9043ee043ae0eda96ebcea41acbd0c31c9b9075b) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1643966 app/controllers/ops_controller/diagnostics.rb | 5 +- 1 file changed, 4 insertions(+), 1 deletion(-)
Fixed and verified in 5.10.0.25.20181120211723_d2fd659