Spec URL: https://eclipseo.fedorapeople.org/cadvisor/golang-github-pierrec-lz4.spec SRPM URL: https://eclipseo.fedorapeople.org/cadvisor/golang-github-pierrec-lz4-2.0.7-1.fc30.src.rpm Description: Package lz4 implements reading and writing lz4 compressed data (a frame), as specified in http://fastcompression.blogspot.fr/2013/04/lz4-streaming-format-final.html. This package is compatible with the LZ4 frame format although the block level compression and decompression functions are exposed and are fully compatible with the lz4 block format definition, they are low level and should not be used directly. Fedora Account System Username: eclipseo
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30545712
Is there any use to building the lz4c binary here? Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD 3-clause "New" or "Revised" License", "Unknown or generated". 520 files have unknown license. Detailed output of licensecheck in 1644010-golang-github-pierrec-lz4/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/share/gocode [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gocode/src/github.com(golang-github-inconshreveable- mousetrap-devel, golang-github-davecgh-go-spew-devel, golang, golang- github-pelletier-go-toml-devel, golang-github-hashicorp-hcl-devel, golang-github-magiconair-properties-devel, golang-github-stretchr- testify-devel, golang-github-BurntSushi-toml-devel, golang-gopkg-yaml- devel-v2, golang-github-spf13-pflag-devel, golang-github-urfave-cli- devel, golang-github-mitchellh-go-homedir-devel, golang-github-kr-fs- devel, golang-github-kr-pretty-devel, golang-github-kr-pty-devel, golang-github-spf13-cobra-devel, golang-github-peterh-liner-devel, golang-github-mattn-go-runewidth-devel, golang-github-pmezard-go- difflib-devel, golang-github-spf13-cast-devel, golang-github-kr-text- devel, golang-github-pkg-errors-devel, golang-github-blang-semver- devel, golang-github-pelletier-go-buffruneio-devel, golang-github- spf13-viper-devel, golang-github-olekukonko-ts-devel, golang-github- cpuguy83-go-md2man-devel, golang-github-mitchellh-mapstructure-devel, golang-github-cheggaaa-pb-devel, golang-github-pkg-sftp-devel) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-pierrec-lz4-devel-2.0.7-1.fc30.noarch.rpm golang-github-pierrec-lz4-2.0.7-1.fc30.src.rpm golang-github-pierrec-lz4-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/pierrec/lz4/.goipath golang-github-pierrec-lz4.src: W: no-%build-section 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- golang-github-pierrec-lz4-devel (rpmlib, GLIBC filtered): golang(github.com/pkg/profile) Provides -------- golang-github-pierrec-lz4-devel: golang(github.com/pierrec/lz4) golang(github.com/pierrec/lz4/fuzz) golang(github.com/pierrec/lz4/internal/xxh32) golang-github-pierrec-lz4-devel golang-ipath(github.com/pierrec/lz4) Source checksums ---------------- https://github.com/pierrec/lz4/archive/v2.0.7.tar.gz#/lz4-2.0.7.tar.gz : CHECKSUM(SHA256) this package : a3e93a97911bb1a7a6a6db58cbc567eae03f7e74c3e1d7709701e3c8f6b6bfe7 CHECKSUM(SHA256) upstream package : a3e93a97911bb1a7a6a6db58cbc567eae03f7e74c3e1d7709701e3c8f6b6bfe7 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1644010 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Note, the binary would conflict with lz4, so I guess it would be mostly a compile check. I *think* there'd be no need to install it.
Sorry, what's missing to get this approved? You want be to build the binary for check?
Mostly because we're hitting https://pagure.io/golist/issue/7 and no tests are run, it'd be nice to see that at least a final compile works.
Ran again with patched golist and tests pass, so approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-pierrec-lz4
golang-github-pierrec-lz4-2.1.0-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-95f122d39e
golang-github-pierrec-lz4-2.1.0-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-d0b7fda363
golang-github-pierrec-lz4-2.1.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-95f122d39e
golang-github-pierrec-lz4-2.1.0-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-d0b7fda363
golang-github-pierrec-lz4-2.1.0-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-pierrec-lz4-2.1.0-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.