Bug 1644250 - Documentation help redirection settings are half ignored on ssui
Summary: Documentation help redirection settings are half ignored on ssui
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - Service
Version: 5.9.4
Hardware: All
OS: All
high
medium
Target Milestone: GA
: 5.10.0
Assignee: Oleg Barenboim
QA Contact: Niyaz Akhtar Ansari
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On:
Blocks: 1622587 1655769
TreeView+ depends on / blocked
 
Reported: 2018-10-30 10:05 UTC by Felix Dewaleyne
Modified: 2022-03-13 15:54 UTC (History)
13 users (show)

Fixed In Version: 5.10.0.28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1655769 (view as bug list)
Environment:
Last Closed: 2019-02-12 16:51:53 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Felix Dewaleyne 2018-10-30 10:05:41 UTC
Description of problem:
Documentation help redirection settings are half ignored on ssui : the window opening setting seems to be taken into account but the link to use is ignored.

Version-Release number of selected component (if applicable):
5.9.4.7

How reproducible:
all the time

Steps to Reproduce:
1.set up under configuration > region a different link for Documentation to open in a new window (such as www.redhat.com)
2.save and reload the interface
3.test it under classic ui
4. log out and then into your self_service ui
5. test it again

Actual results:
in a new window, a link to the documentation pages from the classic ui is opened instead of a page to www.redhat.com (as suggested in the test)

Expected results:
same behaviour between classic ui and self service

Additional info:

Comment 4 Chris Hale 2018-11-08 20:08:57 UTC
I took a look into this and I was unable to find anywhere in the API responses we get any custom help links like those that exist in Classic UI.  I am going to ask someone from the API team to let us know if such info is exposed in the API somewhere.  Looking at our codebase, this parity between classic UI and service ui for this link has never existed.  I think this should be treated as more of an enhancement than a bug.

Comment 9 Joe Vlcek 2018-11-19 15:18:58 UTC
(In reply to Chris Hale from comment #4)
> I took a look into this and I was unable to find anywhere in the API
> responses we get any custom help links like those that exist in Classic UI. 
> I am going to ask someone from the API team to let us know if such info is
> exposed in the API somewhere.  Looking at our codebase, this parity between
> classic UI and service ui for this link has never existed.  I think this
> should be treated as more of an enhancement than a bug.

Hey Chris.

The help_menu links are found in the API under settings.

I'll PM you a live curl example.

Moving back to SUI as the required information is currently available from the API.

JoeV

Comment 12 Joe Vlcek 2018-11-19 15:26:32 UTC
Chris

With the example provided do you have everything you need to address this?

e.g.:
curl -k --user admin:<pw> https://<test_server>/api/settings/help_menu/documentation

JoeV

Comment 16 Chris Hale 2018-11-28 20:32:55 UTC
GH PR - https://github.com/ManageIQ/manageiq-ui-service/pull/1505

Comment 18 Allen W 2018-11-29 19:42:38 UTC
Pr was merged!

Comment 20 CFME Bot 2018-12-03 15:22:09 UTC
New commit detected on ManageIQ/manageiq-ui-service/hammer:

https://github.com/ManageIQ/manageiq-ui-service/commit/cb45ab6751447e5be57f9c06fffa0be716779d22
commit cb45ab6751447e5be57f9c06fffa0be716779d22
Author:     Allen Wight <allen.b.wight>
AuthorDate: Thu Nov 29 11:11:17 2018 -0500
Commit:     Allen Wight <allen.b.wight>
CommitDate: Thu Nov 29 11:11:17 2018 -0500

    Merge pull request #1505 from chalettu/documentation

    BZ#1644250 - Added ability for documentation to be dynamically configured

    (cherry picked from commit 224193fdd8463573b3f8b3061dafda6437b38d90)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1644250

 client/app/core/navigation/navigation-controller.js | 9 +
 client/app/layouts/application.html | 2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

Comment 22 Niyaz Akhtar Ansari 2018-12-12 09:32:08 UTC
Verified in Version 5.10.0.29.20181211195209_fd990a9


Note You need to log in before you can comment on or make changes to this bug.