Description of problem: Vm_reconfigure disk_remove fails sometimes. I have seen this fail in two cases. The disk_remove will sometimes ignore the request and quota requested will be incorrect because the disk_name doesn't match. In the other case, it fails on the match and aborts.
Version-Release number of selected component (if applicable):
How reproducible: Depends on the disk_name being removed. Try a RHV instance, this will fail.
Steps to Reproduce:
1. Add disk(s) to a vm instance
2. Turn quota on
3. Try to remove the disk(s)
Request will fail (<AEMethod requested> NoMethodError: undefined method `match' for nil:NilClass) or not match on disk_name. If there is no match on disk_name, then the size of the disk will not be included for quota.
Request should be successful and size of disk(s) should be included in quota requested.
Sample message of successful disk_remove : <AEMethod requested> VM Reconfigure storage change: -28311552 Bytes
New commit detected on ManageIQ/manageiq-content/hammer:
Author: Madhu Kanoor <firstname.lastname@example.org>
AuthorDate: Wed Nov 14 14:29:12 2018 -0500
Commit: Madhu Kanoor <email@example.com>
CommitDate: Wed Nov 14 14:29:12 2018 -0500
Merge pull request #461 from billfitzgerald0120/quota_vm_reconfig_disk_remove
Modified requested method for reconfigure disk_remove.
(cherry picked from commit c88a344807a704f4e3f1c0c0a53a80245f7ee08b)
content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/requested.rb | 16 +-
spec/automation/unit/method_validation/requested_spec.rb | 13 +-
2 files changed, 20 insertions(+), 9 deletions(-)
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.