Bug 1644569 - Missing grafana storage related parameters for installation
Summary: Missing grafana storage related parameters for installation
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Monitoring
Version: 3.11.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: Frederic Branczyk
QA Contact: Junqi Zhao
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-10-31 07:48 UTC by Kenjiro Nakayama
Modified: 2021-12-10 18:06 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-05 13:33:59 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1629716 0 unspecified CLOSED Remove deprecated prometheus install from openshift-ansible installer 2021-02-22 00:41:40 UTC
Red Hat Knowledge Base (Solution) 3701121 0 None None None 2018-11-19 05:16:40 UTC

Internal Links: 1629716

Description Kenjiro Nakayama 2018-10-31 07:48:02 UTC
Until 3.10, there are "openshift_grafana_storage_*" parameters to specify grafana storage. But it looks like the installation method was changed by [1] and no alternative parameters for grafana storage.

The docs[2] did not mention any grafana storage parameters.

[1] https://github.com/openshift/openshift-ansible/pull/10107/commits/24b68f364607da00bc4f8e214d916569a39929a2
[2] https://docs.openshift.com/container-platform/3.11/install_config/prometheus_cluster_monitoring.html#prometheus-cluster-monitoring

Comment 2 Frederic Branczyk 2018-11-01 08:08:48 UTC
This is not a bug. The monitoring stack introduced in 3.11 is a managed stack, it is automatically updated and therefore exposes a minimal amount of customization, in order for us to be able to ensure sane upgrade paths.

Comment 3 Kenjiro Nakayama 2018-11-01 08:16:45 UTC
You mean that you will not allow grafana to specify storage settings during the installation, but we need to change it after the installation manually?
Many users expect one operation for the installation, though.

Comment 4 Frederic Branczyk 2018-11-01 08:21:49 UTC
Neither, the stack is shipped and configured as is. Any configuration parameter is a feature request, but adding storage to this Grafana should not be necessary as it's automatically provisioned at startup with all the information it needs. It hints that the customer wants to do something that the stack is not intended to be used for (monitor exactly the components that are pre-configured with the pre-configured dashboards, more is a feature request). For example we do have feature requests for the ability to add additional dashboards, but that doesn't mean the Grafana server must be configured to have storage.

Comment 5 Kenjiro Nakayama 2018-11-01 09:30:23 UTC
OK, let me rephrase the question. When you installed cluster with grafana, what volume (PV/PVC) is attached to "/var/lib/grafana/" in your grafana pod? We observed emptyDir is always used for "/var/lib/grafana/" and cannot change it.

Until 3.10, we could configure the persistent volume for "/var/lib/grafana/" by using "openshift_grafana_storage_*" parameters.

Comment 6 Frederic Branczyk 2018-11-01 17:04:08 UTC
We always use an emptyDir because Grafana is statically provisioned from configuration files.

The Grafana role still, exists so you can still create new Grafana servers outside of the cluster monitoring stack should you want to be able to create additional dashboards.

Comment 7 Kenjiro Nakayama 2018-11-02 03:01:43 UTC
It looks like you assumed that users use only the default dashboard, which the grafana image provides by default. Some users want to customize dashboard or import plugins. These info added by users will be gone without persistent volumes.

Comment 8 Christian Heidenreich 2018-11-02 09:46:59 UTC
Hi Kenjiro.

The decision to make the Grafana, which is being shipped with the new cluster monitoring stack, not editable was a very conscious decision that actually spans across all components of the monitoring stack. Let me highlight the core why's:

- Any arbitrary configurations could break the entire monitoring stack during, for example, installation, not just a single component.
- Our vision for an automated over-the-air update for OpenShift very much depends on how much we know about a system. As soon as we give away all control, customers will completely loose over-the-air updates. That could have impact on their ability to receive critical security patches, for example. Obviously, there are more reasons why over-the-air updates is critical for Red Hat's next stage.

Nevertheless, we understand the demand and we have that on our roadmap. Please understand that we need to do some investigations first to ensure we don't mess around with the points above.

Quick question. How did you use Grafana before? I neither see any supported option nor documentation for that in previous versions. Where did you connect Grafana to to get data?

Comment 9 Kenjiro Nakayama 2018-11-04 09:39:55 UTC
Hi Christian,

> - Our vision for an automated over-the-air update for OpenShift very much depends on how much we know about a system. As soon as we give away all control, customers will completely loose over-the-air updates. That could have impact on their ability to receive critical security patches, for example. Obviously, there are more reasons why over-the-air updates is critical for Red Hat's next stage.

I understand and it makes sense. But it is very controversial especially above point. Actually the customer who reported this request (=add openshift_grafana_storage_* parameters), they did workaround by manually adding PV to the grafana by themselves after the installation. Do you mean that it may cause a problem when they will receive patches?

> Quick question. How did you use Grafana before? I neither see any supported option nor documentation for that in previous versions. Where did you connect Grafana to to get data?

Sure, you can refer to following docs:

  OpenShift Grafana Playbooks
  https://github.com/openshift/openshift-ansible/tree/release-3.10/roles/openshift_grafana

It is shipped via the package:

  # rpm -qf /usr/share/ansible/openshift-ansible/roles/openshift_grafana/
  openshift-ansible-roles-3.10.41-1.git.0.fd15dd7.el7.noarch

(We know 3.10's grafana was not supported.)

Comment 10 Christian Heidenreich 2018-11-05 11:09:26 UTC
> Do you mean that it may cause a problem when they will receive patches?

You are saying that they configured the Grafana instance inside the openshift-monitoring namespace?

Comment 11 Kenjiro Nakayama 2018-11-05 13:33:27 UTC
> You are saying that they configured the Grafana instance inside the openshift-monitoring namespace?

That is good question. I have not confirmed it with the customer, but I just heard that they changed it manually. I guess that if we changed Grafana in openshift-monitoring namespace "somehow", it may cause some problem. While if it was not managed by prometheus-operator then it should be alright. Correct?

Comment 12 Christian Heidenreich 2018-11-05 13:42:25 UTC
I asked since the cluster monitoring operator refreshes the state on the deployed objects every x minutes to it's expected state. Means, they can change but the change will be gone with the next refresh cycle. :)

I am currently confirming why the Grafana playbook/role has been removed. Although it's an unsupported role, maybe its still enough for you ands your customer until we figured out how we enable these things without screwing around with the update process.

Comment 13 Christian Heidenreich 2019-02-05 13:33:59 UTC
Let's close this issue as won't fix since it is not intended to extend/modify the cluster-monitoring stack including Grafana. We have an RFE open to provide a more flexible Grafana environment in the future. Please see here: https://bugzilla.redhat.com/show_bug.cgi?id=1668441


Note You need to log in before you can comment on or make changes to this bug.