Description of problem: bug 1643651 - lvm can overwrite extents beyond metadata area affects RHV basic flows of volumes allocation procedures (add/delete/resize of disks and snapshots). Version-Release number of selected component (if applicable): vdsm-4.20.43-1.el7ev.x86_64 How reproducible:
Created attachment 1499363 [details] move disk Occurs also for move disk: 2018-10-30 22:05:33,026+0200 DEBUG (tasks/4) [storage.ResourceManager] No one is waiting for resource '01_img_30dec212-d5c0-40fd-aeae-be5e0e55de76.8e8689d9-ed28-4de4-b674-19e44be706c9', Clearing records. (resour ceManager:599) 2018-10-30 22:05:33,026+0200 ERROR (tasks/4) [storage.TaskManager.Task] (Task='ce33bafd-4e9c-4038-bdcc-94c38c039bab') Unexpected error (task:875) Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/vdsm/storage/task.py", line 882, in _run return fn(*args, **kargs) File "/usr/lib/python2.7/site-packages/vdsm/storage/task.py", line 336, in run return self.cmd(*self.argslist, **self.argsdict) File "/usr/lib/python2.7/site-packages/vdsm/storage/securable.py", line 79, in wrapper return method(self, *args, **kwargs) File "/usr/lib/python2.7/site-packages/vdsm/storage/sp.py", line 1733, in cloneImageStructure img.cloneStructure(sdUUID, imgUUID, dstSdUUID) File "/usr/lib/python2.7/site-packages/vdsm/storage/image.py", line 637, in cloneStructure self._createTargetImage(sdCache.produce(dstSdUUID), sdUUID, imgUUID) File "/usr/lib/python2.7/site-packages/vdsm/storage/image.py", line 403, in _createTargetImage srcVolUUID=volParams['parent']) File "/usr/lib/python2.7/site-packages/vdsm/storage/sd.py", line 820, in createVolume initialSize=initialSize) File "/usr/lib/python2.7/site-packages/vdsm/storage/volume.py", line 1206, in create initialSize=initialSize) File "/usr/lib/python2.7/site-packages/vdsm/storage/blockVolume.py", line 505, in _create initialTags=(sc.TAG_VOL_UNINIT,)) File "/usr/lib/python2.7/site-packages/vdsm/storage/lvm.py", line 1161, in createLV raise se.CannotCreateLogicalVolume(vgName, lvName, err) CannotCreateLogicalVolume: Cannot create Logical Volume: 'vgname=6e839657-e029-467e-8003-34f1b30cd88f lvname=8c8f8039-8222-4f95-a222-4fc3edd31477 err=[\' Volume group "6e839657-e029-467e-8003-34f1b30cd88f" has insufficient free space (6 extents): 8 required.\']'
This bug has not been marked as blocker for oVirt 4.3.0. Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1.
I believe this is also a non-critical bug that can be retargeted to 4.3.6/7. Tal, please retarget accordingly.
I already posted a fix, just need to verify it. Also, this fix doesn't require any verification except regressions that covered with the regular tiers.
(In reply to Elad from comment #1) > Created attachment 1499363 [details] > move disk > > Occurs also for move disk: ... > raise se.CannotCreateLogicalVolume(vgName, lvName, err) > CannotCreateLogicalVolume: Cannot create Logical Volume: > 'vgname=6e839657-e029-467e-8003-34f1b30cd88f > lvname=8c8f8039-8222-4f95-a222-4fc3edd31477 err=[\' Volume group > "6e839657-e029-467e-8003-34f1b30cd88f" has > insufficient free space (6 extents): 8 required.\']' This issue is not related, this is an expected failure when trying to create a volume when a VG does not have enough space. It is likely that the code doing this was filling the VG before this call, or not waiting until all volumes are deleted. We may need another bug for this issue to investigate why there was not enough space. May be engine bug in managing available space. Bug 1643651 does not affect RHV.
(In reply to Nir Soffer from comment #6) > (In reply to Elad from comment #1) > > Created attachment 1499363 [details] > > move disk > > > > Occurs also for move disk: > ... > > raise se.CannotCreateLogicalVolume(vgName, lvName, err) > > CannotCreateLogicalVolume: Cannot create Logical Volume: > > 'vgname=6e839657-e029-467e-8003-34f1b30cd88f > > lvname=8c8f8039-8222-4f95-a222-4fc3edd31477 err=[\' Volume group > > "6e839657-e029-467e-8003-34f1b30cd88f" has > > insufficient free space (6 extents): 8 required.\']' > > This issue is not related, this is an expected failure when trying to create > a volume when a VG does not have enough space. It is likely that the code > doing > this was filling the VG before this call, or not waiting until all volumes > are deleted. > > We may need another bug for this issue to investigate why there was not > enough > space. May be engine bug in managing available space. > > Bug 1643651 does not affect RHV. So the AI is to open a new bug on this issue? Another Q for you and Eyal: Currently, this patch takes care of RHEL7.6 but 4.3.5 goes is supported only on RHEL7.7 we need also a patch for that. Please add it.
The patch requires a specific lvm version, this version is not unique for rhel 7.6, it will be available also on other versions. Same as, for example: Requires: selinux-policy-targeted >= 3.13.1-166.el7_4.3
Since this issue does not effect vdsm I don't think vdsm should require the specific lvm version.
(In reply to Nir Soffer from comment #9) > Since this issue does not effect vdsm I don't think vdsm should require the > specific lvm version. Closing based on Nir's comment