Bug 1644719 - Review Request: gsignond-plugin-mail - E-Mail plugin for gsignond
Summary: Review Request: gsignond-plugin-mail - E-Mail plugin for gsignond
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Luis Segundo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PantheonDesktopPackageReviews 1649555
TreeView+ depends on / blocked
 
Reported: 2018-10-31 13:21 UTC by Fabio Valentini
Modified: 2018-11-15 10:43 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-11-15 10:43:27 UTC
Type: ---
Embargoed:
luis: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2018-10-31 13:21:13 UTC
Spec URL: https://decathorpe.fedorapeople.org/packages/gsignond-plugin-mail.spec
SRPM URL: https://decathorpe.fedorapeople.org/packages/gsignond-plugin-mail-0.3.0-1.fc29.src.rpm

Description:
This plugin for the Accounts-SSO gSignOn daemon handles the E-Mail credentials.

Fedora Account System Username: decathorpe

The package builds successfully locally, but for mock builds, "--enablerepo=local" will probably be necessary until the next rawhide compose, since I just built gsignond 1.2.0 a few minutes ago.

Comment 1 Luis Segundo 2018-11-01 18:35:50 UTC
Hello Fabio it looks good, but when the dependency "gsignond 1.2.0" is stable it will be approved.

Comment 2 Zbigniew Jędrzejewski-Szmek 2018-11-05 21:54:02 UTC
Luis, there is no need to wait for all dependencies to be stable, just to pass review. This package has R:gsignond>=1.2.0 so it will not be installable before, but that is OK. Users can test it using updates-testing and such.

Comment 3 Fabio Valentini 2018-11-06 16:49:51 UTC
I'm not in a hurry, so I didn't want to push for finishing the review. Either way, there was a successful compose a few hours ago, so that point is now moot anyway :)

Comment 4 Fabio Valentini 2018-11-14 15:40:34 UTC
Ping?

Comment 5 Luis Bazan 2018-11-14 16:31:51 UTC
Hi Luis --

I think you can approve this package.

gsignond 1.2.0
https://koji.fedoraproject.org/koji/buildinfo?buildID=1157626

the spec look good.

Cheers,

Comment 6 Luis Segundo 2018-11-14 16:36:48 UTC
Nice, Package approved.

Comment 7 Gwyn Ciesla 2018-11-14 21:31:37 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/gsignond-plugin-mail

Comment 8 Fabio Valentini 2018-11-15 10:43:27 UTC
Imported and built for rawhide. Thanks everybody!

https://koji.fedoraproject.org/koji/taskinfo?taskID=30897426


Note You need to log in before you can comment on or make changes to this bug.