Bug 1645042 - Suspend / Resume alters GPIO mapping
Summary: Suspend / Resume alters GPIO mapping
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: kernel
Version: 30
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Kernel Maintainer List
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-11-01 09:58 UTC by vivien.frasca
Modified: 2020-05-26 18:41 UTC (History)
17 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-05-26 17:35:14 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
BEFORE suspend : cat /sys/kernel/debug/pinctrl/*/pins (9.92 KB, text/plain)
2018-11-01 10:00 UTC, vivien.frasca
no flags Details
AFTER suspend : cat /sys/kernel/debug/pinctrl/*/pins (9.92 KB, text/plain)
2018-11-01 10:01 UTC, vivien.frasca
no flags Details
diff of pinctrl (1.66 KB, patch)
2018-11-01 10:02 UTC, vivien.frasca
no flags Details | Diff
pinctl-asked-procedure (2.09 KB, application/x-xz)
2019-04-05 07:39 UTC, vivien.frasca
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Linux Kernel 203995 0 None None None 2019-09-18 08:00:28 UTC
Red Hat Bugzilla 1543769 0 unspecified CLOSED Elan1200 touchpad not well managed by hid_multitouch module 2022-01-24 09:49:40 UTC

Description vivien.frasca 2018-11-01 09:58:37 UTC
On an ASUS FX503VD, doing a suspend / resume standard procedure seems to alter the GPIO configuration.

Consequences: the i2c touchpad don't work correctly after the resume step.

Please find attached the pinctrl list before and after the suspend / resume cycle.

Please also find attached the diff of these two files that highlight the pins that has been changed after the resume step.

Comment 1 vivien.frasca 2018-11-01 10:00:39 UTC
Created attachment 1499898 [details]
BEFORE suspend : cat /sys/kernel/debug/pinctrl/*/pins

Comment 2 vivien.frasca 2018-11-01 10:01:12 UTC
Created attachment 1499899 [details]
AFTER suspend : cat /sys/kernel/debug/pinctrl/*/pins

Comment 3 vivien.frasca 2018-11-01 10:02:17 UTC
Created attachment 1499900 [details]
diff of pinctrl

Comment 4 Justin M. Forbes 2019-01-29 16:25:48 UTC
*********** MASS BUG UPDATE **************

We apologize for the inconvenience.  There are a large number of bugs to go through and several of them have gone stale.  Due to this, we are doing a mass bug update across all of the Fedora 28 kernel bugs.

Fedora 28 has now been rebased to 4.20.5-100.fc28.  Please test this kernel update (or newer) and let us know if you issue has been resolved or if it is still present with the newer kernel.

If you have moved on to Fedora 29, and are still experiencing this issue, please change the version to Fedora 29.

If you experience different issues, please open a new bug report for those.

Comment 5 vivien.frasca 2019-01-30 11:13:42 UTC
This bug is still present after upgrade to kernel 4.20.4-200.fc29.x86_64.

Comment 6 vivien.frasca 2019-02-15 20:49:09 UTC
Hello,

Do you need any additional informations to start any debug things ?

I must disable the suspend on laptop lid closed to avoid probing again the i2c_hid module after the resume step (see the related bug for more detail).

Comment 7 Andy Shevchenko 2019-04-01 10:24:08 UTC
I would like to have the following differences (no need to dump everything) (in all cases, please, don't touch touchpad):
1/ boot Linux with *disabled* touchpad driver, i.e. I2C HID, gather the following: a) the pins statuses listed in your attached diff here, b) gather entire pins list and do suspend-resume cycle and gather the difference if any (I hope to see the file from a) and difference from b) items)
2/ boot with driver enabled and without any additional patch applied, do as in 1.

Comment 8 vivien.frasca 2019-04-05 07:39:28 UTC
Created attachment 1552302 [details]
pinctl-asked-procedure

Andy, please find the pinctl statuses

for step 1/, I've added 'blacklist i2c_hid > /etc/modprobe.d/blacklist.conf'  then rebooted without touching the touchpad.

1_A_pinctl : pins after boot
1_B_pinctl : pins after suspend - resume

for step 2/ I've removed the blacklist

2_A_pinctl : pins after boot
2_B_pinctl : pins after suspend - resume

If you need any other informations, feel free to ask me.

Comment 9 Ben Cotton 2019-05-02 19:43:08 UTC
This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 10 Justin M. Forbes 2019-08-20 17:39:43 UTC
*********** MASS BUG UPDATE **************

We apologize for the inconvenience.  There are a large number of bugs to go through and several of them have gone stale.  Due to this, we are doing a mass bug update across all of the Fedora 30 kernel bugs.

Fedora 30 has now been rebased to 5.2.9-200.fc30.  Please test this kernel update (or newer) and let us know if you issue has been resolved or if it is still present with the newer kernel.

If you have moved on to Fedora 31, and are still experiencing this issue, please change the version to Fedora 31.

If you experience different issues, please open a new bug report for those.

Comment 11 Justin M. Forbes 2019-09-17 20:12:16 UTC
*********** MASS BUG UPDATE **************
This bug is being closed with INSUFFICIENT_DATA as there has not been a response in 3 weeks. If you are still experiencing this issue, please reopen and attach the relevant data from the latest kernel you are running and any data that might have been requested previously.

Comment 12 vivien.frasca 2019-10-22 07:15:00 UTC
This bug is still present, I've sent all asked informations (in comment #8 https://bugzilla.redhat.com/show_bug.cgi?id=1645042#c8)

Comment 14 vivien.frasca 2019-10-22 19:06:18 UTC
Thanks @Andy,

How can I compile only this module (pinctrl-intel) with the patch without upgrading the whole kernel sources ? Actually, I've got only the source of kernel-4.20.13 (yes, that's old !)

Am I forced to update my sources to the 5.3.6 to be able to build this module only ?

Comment 15 Ben Cotton 2020-04-30 20:54:13 UTC
This message is a reminder that Fedora 30 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 30 on 2020-05-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '30'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 30 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 16 Ben Cotton 2020-05-26 17:35:14 UTC
Fedora 30 changed to end-of-life (EOL) status on 2020-05-26. Fedora 30 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 17 Andy Shevchenko 2020-05-26 18:41:58 UTC
(In reply to vivien.frasca from comment #14)
> Thanks @Andy,
> 
> How can I compile only this module (pinctrl-intel) with the patch without
> upgrading the whole kernel sources ? Actually, I've got only the source of
> kernel-4.20.13 (yes, that's old !)
> 
> Am I forced to update my sources to the 5.3.6 to be able to build this
> module only ?

Vivien, sorry for late reply, I think it's kinda 'yes' because there were a lot of changes in that driver somewhere in v5.x kernels. 
Do you have a chance to test on most recent you can try? (v5.6.y would be ideal, of course)


Note You need to log in before you can comment on or make changes to this bug.