Bug 1645111 - Container Review Request: origin-template-service-broker - origin-template-service-broker
Summary: Container Review Request: origin-template-service-broker - origin-template-se...
Keywords:
Status: MODIFIED
Alias: None
Product: Fedora Container Images
Classification: Fedora
Component: Container Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tomas Tomecek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-11-01 12:24 UTC by Jakub Čajka
Modified: 2018-11-26 12:18 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:
ttomecek: fedora-review+


Attachments (Terms of Use)

Description Jakub Čajka 2018-11-01 12:24:08 UTC
Container Build Info URL: https://pagure.io/origin-dockerfiles/blob/master/f/3.11/template-service-broker/Dockerfile
Description: template-service-broker container image for OpenShift Origin
Fedora Account System Username: jcajka

Comment 1 Tomas Tomecek 2018-11-01 12:54:53 UTC
The dockerfile builds successfully. Unfortunately, it doesn't run on its own.

Would it possible to update usage and say that people should not invoke this on their own?

```
$ docker run a59498ed5a3a                                                                                                                                                                   
Error: missing config: specify --config
```

Comment 2 Jakub Čajka 2018-11-21 14:04:32 UTC
(In reply to Tomas Tomecek from comment #1)
> The dockerfile builds successfully. Unfortunately, it doesn't run on its own.
> 
> Would it possible to update usage and say that people should not invoke this
> on their own?
> 
> ```
> $ docker run a59498ed5a3a                                                   
> 
> Error: missing config: specify --config
> ```

Not sure that it shoudn't be run on its own. All of the images are part of the origin and do follow the upstream docs. I think the current usage is clear about it.

Comment 3 Tomas Tomecek 2018-11-21 14:45:03 UTC
> usage="This is the OpenShift Origin template service broke image." 

Well, not clear to me. It doesn't tell me that I shouldn't run this on my own.

But still, this is your image and if you are okay with this, I am willing to give you review+, just a headsup that you may get some confused users in the future.


Note You need to log in before you can comment on or make changes to this bug.