Container Build Info URL: https://pagure.io/origin-dockerfiles/blob/master/f/3.11/tests/Dockerfile Description: This is the official OpenShift test image. It can be used to verify an installation of OpenShift completed successfully. Fedora Account System Username: jcajka
``` # FROM registry.fedoraproject.org/f29/origin-cli FROM origin-cli ``` Shouldn't this be set to the line which is commented out? Or did we finally got rid of the $FGC prefix? Actually, the same question, are we still doing FGC? `name="$FGC/$NAME" \`? Otherwise LGTM.
(In reply to Tomas Tomecek from comment #1) > ``` > # FROM registry.fedoraproject.org/f29/origin-cli > FROM origin-cli > ``` > > Shouldn't this be set to the line which is commented out? Or did we finally > got rid of the $FGC prefix? > > Actually, the same question, are we still doing FGC? `name="$FGC/$NAME" \`? > > > Otherwise LGTM. Yes, it will be the commented when the cli image will be in Fedora. You can build the whole stack using the build.sh script, although it might fail on some as they are waiting for latest origin package to hit stable in F29.
LGTM, approving
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/container/origin-tests