Bug 1645368 - Empty trash bin icon does not appear on desktop.
Summary: Empty trash bin icon does not appear on desktop.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-colors-icon-theme
Version: 31
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-11-02 04:12 UTC by halginsberg1963
Modified: 2020-06-19 01:05 UTC (History)
2 users (show)

Fixed In Version: gnome-colors-icon-theme-5.5.1-18.fc32 gnome-colors-icon-theme-5.5.1-18.fc31
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-06-19 01:02:12 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Screenshot showing no trash icon. (822.55 KB, image/png)
2018-11-02 04:12 UTC, halginsberg1963
no flags Details
Table comparing icons in different themes (6.21 KB, application/zip)
2018-11-02 14:30 UTC, halginsberg1963
no flags Details
Screenshot showing empty trash icons folder (137.64 KB, image/png)
2018-11-05 15:41 UTC, halginsberg1963
no flags Details

Description halginsberg1963 2018-11-02 04:12:22 UTC
Created attachment 1500354 [details]
Screenshot showing no trash icon.

After upgrade to Fedora 29, empty trash bin does not appear on desktop when using gnome-colors-icon-theme, although word Trash is seen below where Trash icon should be. When an item is deleted, non-empty trash bin displays above word Trash. When trash bin is emptied, no icon is visible, although the name Trash is shown on desktop. This problem does not occur when other desktop themes are used.


Version-Release number of selected component (if applicable): This problem occurred in versions 5.5.1-14 and after a downgrade to 5.5.1-10. This problem occurred on both a Lenovo T61 Laptop and Dell Vostro 420 Desktop.


How reproducible: Select any gnome-colors-theme in Appearance Preferences>Theme>Customize>Icons.


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Miro Hrončok 2018-11-02 09:22:15 UTC
> This problem occurred in versions 5.5.1-14 and after a downgrade to 5.5.1-10.

So the problem was already there. Something must have changed on the GNOME side.
I'll ask for help on the devel mailing list, because I have no knowledge about GNOME.

Comment 2 Miro Hrončok 2018-11-02 09:24:55 UTC
Looking at the screenshot, what Desktop Environment is this?

Comment 3 halginsberg1963 2018-11-02 11:27:07 UTC
Mate. Sorry I neglected to specify in original bug report.

Comment 4 Miro Hrončok 2018-11-02 11:33:19 UTC
OK. Let's see if there is something different betwwen gnome-colors-icon.theme and others.

I see:

$ rpm -ql gnome-colors-icon-theme | grep -i trash
/usr/share/icons/gnome-colors-common/16x16/places/emptytrash.png
/usr/share/icons/gnome-colors-common/16x16/places/gnome-fs-trash-empty.png
/usr/share/icons/gnome-colors-common/16x16/places/gnome-stock-trash.png
/usr/share/icons/gnome-colors-common/16x16/places/trashcan_empty.png
/usr/share/icons/gnome-colors-common/16x16/places/user-trash.png
/usr/share/icons/gnome-colors-common/16x16/places/xfce-trash_empty.png
/usr/share/icons/gnome-colors-common/16x16/status/edittrash.png
/usr/share/icons/gnome-colors-common/16x16/status/gnome-fs-trash-full.png
/usr/share/icons/gnome-colors-common/16x16/status/gnome-stock-trash-full.png
/usr/share/icons/gnome-colors-common/16x16/status/stock_trash_full.png
/usr/share/icons/gnome-colors-common/16x16/status/trashcan_full.png
/usr/share/icons/gnome-colors-common/16x16/status/user-trash-full.png
/usr/share/icons/gnome-colors-common/16x16/status/xfce-trash_full.png
/usr/share/icons/gnome-colors-common/22x22/places/emptytrash.png
/usr/share/icons/gnome-colors-common/22x22/places/gnome-fs-trash-empty.png
/usr/share/icons/gnome-colors-common/22x22/places/gnome-stock-trash.png
/usr/share/icons/gnome-colors-common/22x22/places/trashcan_empty.png
/usr/share/icons/gnome-colors-common/22x22/places/user-trash.png
/usr/share/icons/gnome-colors-common/22x22/places/xfce-trash_empty.png
/usr/share/icons/gnome-colors-common/22x22/status/edittrash.png
/usr/share/icons/gnome-colors-common/22x22/status/gnome-fs-trash-full.png
/usr/share/icons/gnome-colors-common/22x22/status/gnome-stock-trash-full.png
/usr/share/icons/gnome-colors-common/22x22/status/stock_trash_full.png
/usr/share/icons/gnome-colors-common/22x22/status/trashcan_full.png
/usr/share/icons/gnome-colors-common/22x22/status/user-trash-full.png
/usr/share/icons/gnome-colors-common/22x22/status/xfce-trash_full.png
/usr/share/icons/gnome-colors-common/24x24/places/emptytrash.png
/usr/share/icons/gnome-colors-common/24x24/places/gnome-fs-trash-empty.png
/usr/share/icons/gnome-colors-common/24x24/places/gnome-stock-trash.png
/usr/share/icons/gnome-colors-common/24x24/places/trashcan_empty.png
/usr/share/icons/gnome-colors-common/24x24/places/user-trash.png
/usr/share/icons/gnome-colors-common/24x24/places/xfce-trash_empty.png
/usr/share/icons/gnome-colors-common/24x24/status/edittrash.png
/usr/share/icons/gnome-colors-common/24x24/status/gnome-fs-trash-full.png
/usr/share/icons/gnome-colors-common/24x24/status/gnome-stock-trash-full.png
/usr/share/icons/gnome-colors-common/24x24/status/stock_trash_full.png
/usr/share/icons/gnome-colors-common/24x24/status/trashcan_full.png
/usr/share/icons/gnome-colors-common/24x24/status/user-trash-full.png
/usr/share/icons/gnome-colors-common/24x24/status/xfce-trash_full.png
/usr/share/icons/gnome-colors-common/32x32/places/emptytrash.png
/usr/share/icons/gnome-colors-common/32x32/places/gnome-fs-trash-empty.png
/usr/share/icons/gnome-colors-common/32x32/places/gnome-stock-trash.png
/usr/share/icons/gnome-colors-common/32x32/places/trashcan_empty.png
/usr/share/icons/gnome-colors-common/32x32/places/user-trash.png
/usr/share/icons/gnome-colors-common/32x32/places/xfce-trash_empty.png
/usr/share/icons/gnome-colors-common/32x32/status/edittrash.png
/usr/share/icons/gnome-colors-common/32x32/status/gnome-fs-trash-full.png
/usr/share/icons/gnome-colors-common/32x32/status/gnome-stock-trash-full.png
/usr/share/icons/gnome-colors-common/32x32/status/stock_trash_full.png
/usr/share/icons/gnome-colors-common/32x32/status/trashcan_full.png
/usr/share/icons/gnome-colors-common/32x32/status/user-trash-full.png
/usr/share/icons/gnome-colors-common/32x32/status/xfce-trash_full.png
/usr/share/icons/gnome-colors-common/scalable/places/emptytrash.svg
/usr/share/icons/gnome-colors-common/scalable/places/gnome-fs-trash-empty.svg
/usr/share/icons/gnome-colors-common/scalable/places/gnome-stock-trash.svg
/usr/share/icons/gnome-colors-common/scalable/places/trashcan_empty.svg
/usr/share/icons/gnome-colors-common/scalable/places/user-trash.svg
/usr/share/icons/gnome-colors-common/scalable/places/xfce-trash_empty.svg
/usr/share/icons/gnome-colors-common/scalable/status/edittrash.svg
/usr/share/icons/gnome-colors-common/scalable/status/gnome-fs-trash-full.svg
/usr/share/icons/gnome-colors-common/scalable/status/gnome-stock-trash-full.svg
/usr/share/icons/gnome-colors-common/scalable/status/stock_trash_full.svg
/usr/share/icons/gnome-colors-common/scalable/status/trashcan_full.svg
/usr/share/icons/gnome-colors-common/scalable/status/user-trash-full.svg
/usr/share/icons/gnome-colors-common/scalable/status/xfce-trash_full.svg

What do other (working) icon theme packages have?

Comment 5 halginsberg1963 2018-11-02 14:30:16 UTC
Created attachment 1500592 [details]
Table comparing icons in different themes

Comment 6 halginsberg1963 2018-11-02 14:31:56 UTC
Your comment suggested that the problem is in one of the gnome-colors-common theme folders. Sure enough when I rename gnome-colors-common/scalable to "scalable.old," a very small empty trash icon does appear on the desktop and does work correctly, i.e., it shows non-empty when I delete an item. But I can't find what the problem is beyond that. I uploaded a side by side comparison of the trash icons in gnome-colors-common where there is a problem and Mate where there is not. I did copy all icons that were in mate but not in gnome-colors-common into the respective folders in gnome-colors-common. But this did not solve the problem. Only changing name/deleting scalable brought a working Trash icon to the desktop while using gnome-colors theme. But that icon was disproportionatey snmall.

Comment 7 halginsberg1963 2018-11-02 19:20:44 UTC
I believe I have discovered the problem. The "emptytrash.svg" icon in the the gnome-colors-icon-theme package at gnome-colors-common/scalable/places does not link to an icon. Thus, it displays as a blank. I cannot fix this problem obviously except on my home PCs if I can find the appropriate emptytrash.svg to link to.

Comment 8 halginsberg1963 2018-11-03 00:29:42 UTC
There is no comparable user-trash or emptytrash.svg. Plus there are complications involving linked files. The developer will need to repair this.

Comment 9 Miro Hrončok 2018-11-04 18:31:00 UTC
What happens if you delete the file?


The developer?

Comment 10 halginsberg1963 2018-11-04 18:34:27 UTC
If I delete all files file in the visible trash bin, the trashbin disappears. When I say developer needs to fix, I mean I can figure out a workaround on my end.

Comment 11 Miro Hrončok 2018-11-04 19:48:02 UTC
/usr/share/icons/gnome-colors-common/scalable/places/emptytrash.svg is a symbolic link to user-trash.svg

What happens if you delete /usr/share/icons/gnome-colors-common/scalable/places/emptytrash.svg and **copy** /usr/share/icons/gnome-colors-common/scalable/places/user-trash.svg to /usr/share/icons/gnome-colors-common/scalable/places/emptytrash.svg ?

Comment 12 halginsberg1963 2018-11-04 20:06:35 UTC
No change. The "user-trash.svg" a link to a blank icon as well.

Comment 13 Miro Hrončok 2018-11-04 20:29:09 UTC
My user-trash.svg is not a link:

$ ls -l /usr/share/icons/gnome-colors-common/scalable/places/user-trash.svg
.rw-r--r--@ 37k root 31 Aug 17:19 /usr/share/icons/gnome-colors-common/scalable/places/user-trash.svg
$ file /usr/share/icons/gnome-colors-common/scalable/places/user-trash.svg
/usr/share/icons/gnome-colors-common/scalable/places/user-trash.svg: SVG Scalable Vector Graphics image

Comment 14 halginsberg1963 2018-11-04 20:37:44 UTC
Neither is mine actually. But it still shows no image/icon in the directory.

Comment 15 halginsberg1963 2018-11-05 15:41:42 UTC
Created attachment 1501991 [details]
Screenshot showing empty trash icons folder

Comment 16 Miro Hrončok 2019-01-09 09:36:08 UTC
I'm so sorry but I lack the ability to fix this :(

Whoever is able, please assign yourselves. I've asked on devel for help but got nobody.

Comment 17 Ben Cotton 2019-10-31 20:12:22 UTC
This message is a reminder that Fedora 29 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '29'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 29 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 18 halginsberg1963 2019-10-31 21:02:21 UTC
This bug remains a problem in Fedora 31 Mate - at least when updated via the commandline.

Comment 19 Lionel Putz 2020-03-10 05:29:01 UTC
The problem occurs because on line 701 of /usr/share/icons/gnome-colors-common/scalable/places/user-trash.svg there is a reference to filter:url(#filter3625), which doesn't exist in this svg file. Delete that filter reference to fix the problem. 

Further info: the filter does exist in status/user-trash-full.svg, which is why the trashcan appears when you put something in it. The filter is a result of setting the blend mode to "Multiply" in Inkscape. But it doesn't do anything because it is applied to a single group, on a single layer and there are no other objects to blend with. You can edit the file in Inkscape and in the object properties change the blend mode to Normal and the issue goes away.

It seems GTK gets confused about the missing filter, rather than just continuing to display the objects from the file.

Comment 20 Miro Hrončok 2020-03-10 09:25:51 UTC
Wow. Thanks!

Comment 21 Fedora Update System 2020-06-07 21:06:09 UTC
FEDORA-2020-52a6400a4e has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-52a6400a4e

Comment 22 Fedora Update System 2020-06-07 21:06:10 UTC
FEDORA-2020-8fc56aa2aa has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-8fc56aa2aa

Comment 23 Fedora Update System 2020-06-11 19:20:31 UTC
gnome-colors-icon-theme-5.5.1-18.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-8fc56aa2aa

Comment 24 Fedora Update System 2020-06-11 19:23:27 UTC
gnome-colors-icon-theme-5.5.1-18.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-52a6400a4e

Comment 25 Fedora Update System 2020-06-19 01:02:12 UTC
FEDORA-2020-8fc56aa2aa has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 26 Fedora Update System 2020-06-19 01:05:34 UTC
FEDORA-2020-52a6400a4e has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.