Bug 1645681 - Review Request: golang-x-arch - Machine architecture information used by the Go toolchain
Summary: Review Request: golang-x-arch - Machine architecture information used by the ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jakub Čajka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1645294 1654879
TreeView+ depends on / blocked
 
Reported: 2018-11-02 20:11 UTC by Robert-André Mauchin 🐧
Modified: 2018-12-12 03:07 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1654879 (view as bug list)
Environment:
Last Closed: 2018-12-12 01:44:43 UTC
Type: ---
Embargoed:
jcajka: fedora-review+


Attachments (Terms of Use)

Description Robert-André Mauchin 🐧 2018-11-02 20:11:50 UTC
Spec URL: https://eclipseo.fedorapeople.org/golang-x-arch.spec
SRPM URL: https://eclipseo.fedorapeople.org/golang-x-arch-0-0.1.20181102gitb19384d.fc30.src.rpm

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30613234

Description:
This package holds machine architecture information used by the Go
toolchain.

Fedora Account System Username: eclipseo

Comment 1 Jakub Čajka 2018-11-08 13:02:13 UTC
It seems that the package contains files under different licenses so all should be listed under the license tag i.e. License:  BSD and MIT and ASL 2.0 
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios

Breakdown(should be mentioned in the comments):
BSD all except
MIT x86/x86asm/testdata/libmach8db.c
ASL 2.0 x86/x86avxgen/testdata/xedpath/*.txt

Otherwise everything looks good to me.

Comment 2 Robert-André Mauchin 🐧 2018-11-09 19:34:03 UTC
Spec URL: https://eclipseo.fedorapeople.org/golang-x-arch.spec
SRPM URL: https://eclipseo.fedorapeople.org/golang-x-arch-0-0.1.20181109gitb19384d.fc30.src.rpm

Fixed the license as you said.

Comment 3 Robert-André Mauchin 🐧 2018-11-21 17:31:33 UTC
Ping jcajka?

Comment 4 Jakub Čajka 2018-11-22 11:12:46 UTC
Sorry, missed you respin.

Looks good to me now.

Comment 5 Gwyn Ciesla 2018-11-26 16:08:38 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-x-arch

Comment 6 Fedora Update System 2018-11-26 21:53:11 UTC
golang-x-arch-0-0.1.20181126gitb19384d.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-4dabe194d3

Comment 7 Fedora Update System 2018-11-26 23:52:21 UTC
golang-x-arch-0-0.1.20181126gitb19384d.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-32706954fe

Comment 8 Fedora Update System 2018-11-27 04:28:18 UTC
golang-x-arch-0-0.1.20181126gitb19384d.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-32706954fe

Comment 9 Fedora Update System 2018-11-27 05:14:57 UTC
golang-x-arch-0-0.1.20181126gitb19384d.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-4dabe194d3

Comment 10 Derek Parker 2018-11-27 21:28:08 UTC
I'm trying to install this package locally (and tried building on copr) in order to rebuild my srpm for the Delve package, however I get the following error: 

DEBUG util.py:490:  BUILDSTDERR: Error: 
DEBUG util.py:490:  BUILDSTDERR:  Problem: conflicting requests
DEBUG util.py:490:  BUILDSTDERR:   - nothing provides golang(rsc.io/pdf) needed by golang-x-arch-devel-0-0.1.20181126gitb19384d.fc30.noarch

Comment 11 Robert-André Mauchin 🐧 2018-11-28 16:15:38 UTC
A missing Requires that didn't appear during packaging. It needs to be packaged too. I'm away from my computer right now, perhaps you could try packaging it.

Comment 12 Derek Parker 2018-11-29 23:01:15 UTC
Created: https://bugzilla.redhat.com/show_bug.cgi?id=1654881

Comment 13 Fedora Update System 2018-12-12 01:44:43 UTC
golang-x-arch-0-0.1.20181126gitb19384d.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2018-12-12 03:07:45 UTC
golang-x-arch-0-0.1.20181126gitb19384d.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.