Bug 1645826 - sa-update.timer
Summary: sa-update.timer
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: spamassassin
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-11-04 04:10 UTC by Brad
Modified: 2020-04-25 18:09 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-04-22 16:43:53 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1218999 0 unspecified CLOSED sa-update.timer not enabled 2021-02-22 00:41:40 UTC

Description Brad 2018-11-04 04:10:05 UTC
Description of problem:

sa-update.timer contains "WantedBy=spamassassin.service".  That is incorrect, because the update timer is independent of spamd, which is but one of the services that might use the spamassasin data files, another, for example, is amavisd-new.  In fact, spamassassin can be used by directly invoking it, without using any service at all.

Instead, sa-update.timer should be "WantedBy=timers.target"

It should preset enabled, so that it is enabled when spamassassin is installed.  Out of the box, the data files, once installed, should be kept up to date.

It is not properly PartOf spamd or WantedBy spamassassin.service.

Version-Release number of selected component (if applicable):
spamassassin-3.4.2-2.fc28.x86_64


Additional info:

Workaround:

Manually correct and enable sa-update after installing spamassassin:

# sed -e 's/WantedBy=spamassassin.service/WantedBy=timers.target/' < /usr/lib/systemd/system/sa-update.timer > /etc/systemd/system/sa-update.timer
# systemctl enable --now sa-update.timer

Comment 1 Kevin Fenzi 2018-11-11 19:15:42 UTC
I have no objection to this... would you, or one of my co-maintainers like to submit a PR here?

Comment 2 Brad 2018-11-11 21:56:04 UTC
(In reply to Kevin Fenzi from comment #1)
> I have no objection to this... would you, or one of my co-maintainers like
> to submit a PR here?

(If I can help, I'm happy to; I'd just need a pointer to instructions, since I'm new here and not familiar with your process).

Comment 3 Kevin Fenzi 2018-11-18 16:59:06 UTC
Yeah, this is a bit of a complex one... 

In order to have the default preset enabled, we have to file a request (which I have now done): 
https://bugzilla.redhat.com/show_bug.cgi?id=1651002

Once thats in, we can change the timer and be done. :)

Comment 4 Ben Cotton 2019-05-02 20:17:34 UTC
This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Ben Cotton 2019-05-28 23:19:05 UTC
Fedora 28 changed to end-of-life (EOL) status on 2019-05-28. Fedora 28 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 6 Brad 2020-04-16 00:09:53 UTC
I'm reopening this against Fedora 31, where it is still broken:

Kevin Fenzi has filed the preset request here: https://bugzilla.redhat.com/show_bug.cgi?id=1651002

This request is for a one line change to /usr/lib/systemd/system/sa-update.timer

--- /usr/lib/systemd/system/sa-update.timer	2020-02-03 17:43:49.000000000 +0000
+++ sa-update.timer	2020-04-15 21:12:24.630017019 +0000

@@ -13,4 +17,4 @@
 OnCalendar=daily
 
 [Install]
-WantedBy=spamassassin.service
+WantedBy=timers.target

Comment 7 Kevin Fenzi 2020-04-22 16:43:53 UTC
I poked the preset request... it was missed somehow.

And I have pushed this finally to rawhide. 

Is that sufficent for now? Or did you want stable releases updated too? If so, we will have to get the preset changed there which might take a while... let me know what you think...

Comment 8 Brad 2020-04-22 19:06:57 UTC
Thanks Kevin; If you agree the risk is low (I think it is), then lets drop in the request to fix stable also.

Comment 9 Kevin Fenzi 2020-04-25 18:09:13 UTC
Requested in the preset bug.


Note You need to log in before you can comment on or make changes to this bug.