Fedora Account System
Red Hat Associate
Red Hat Customer
SPEC: http://v3.sk/~lkundrak/SPECS/lumail.spec SRPM: http://v3.sk/~lkundrak/SRPMS/lumail-3.1-1.fc29.src.rpm Description: Lumail is a modern console-based email-client, with fully integrated scripting, implemented in the Lua programming language. --- Note that this depends on perl(Net::Client::IMAP) that is being reviewed in bug #1646579
- Duplicate line: BuildRequires: file-devel BuildRequires: file-devel - Group: is not used in Fedora - Could use %autosetup -p1 instead of: %setup -q %patch0 -p1 %patch1 -p1 - %{_prefix}/lib/lumail Suspicious, shouldn't this be in %{_libdir}? You should overwrite LUMAIL_LIBS?=$(DESTDIR)$(PREFIX)/lib/lumail
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2)", "Expat License", "Unknown or generated", "*No copyright* BSD (unspecified)". 57 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/lumail/review- lumail/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 7 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in lumail- debuginfo , lumail-debugsource [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: lumail-3.1-1.fc30.x86_64.rpm lumail-debuginfo-3.1-1.fc30.x86_64.rpm lumail-debugsource-3.1-1.fc30.x86_64.rpm lumail-3.1-1.fc30.src.rpm lumail.x86_64: W: no-manual-page-for-binary lumail2 lumail.src:47: E: hardcoded-library-path in %{_prefix}/lib/lumail 4 packages and 0 specfiles checked; 1 errors, 1 warnings.
(In reply to Robert-André Mauchin from comment #1) Thanks for your review. perl-Net-IMAP-Client is now in BR override so this now builds in Koji successfully. > - Duplicate line: > > BuildRequires: file-devel > BuildRequires: file-devel Good catch, will fix. > - Group: is not used in Fedora Yeah, but... It's not a "MUST NOT" and certain tools (rpm -qi) still print it. I'd prefer to have it correct than to have is missing unless the rest of the tooling really really gets rid of it. > - Could use %autosetup -p1 instead of: > > %setup -q > %patch0 -p1 > %patch1 -p1 Yes. Both forms look equally good to me; and I guess the guidelines allow both. I'm more used to this one and I guess there's no harm in keeping things working on versions that predate %autosetup. > - %{_prefix}/lib/lumail > > Suspicious, shouldn't this be in %{_libdir}? You should overwrite > LUMAIL_LIBS?=$(DESTDIR)$(PREFIX)/lib/lumail It is correct. We're not installing arch-dependent files, but lua libraries. Cheers Lubo
Ok package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/lumail
Imported and built. Thank you.