Description of problem: Try to create a nic or disk, and click "x" which means cancel. A nic or disk is created without configurations. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: A nic or disk is created without configuration after click "x" Expected results: The nic/disk should not be showing there. Additional info:
It does not actually mean to cancel the creation but to cancel the configuration so I'd say it is correct. @Liz: any comment?
If it is meaning to cancel the configuration, then I think it need to document what the button means. Because it causes confusion.
I completely understand the confusion that Guohua has. I felt the same way and added this as review comments, but after talking with the devs I understood more as to why it is working this way. I do wonder if it's worth allowing this to work differently in the case of creating a new item in the list, though. I do also think that if you haven't filled out any of the fields yet (or made any changes) that it would be more expected for this row to simply disappear on "Cancel". In the case of editing an item that already exists, I would expect it to work the same way it does today. Thoughts from anyone else playing with this??
@Filip can you please take a look ?
I would prefer for our UI to be consistent, so all the buttons have the same behaviour all the time. even if we did that just for the first time it would behave differently for the second time with the exact same content in the row. Plus we need a way to cancel the editing and this behaviour is alligned with patternfly react.[1] I think consistency vs little bit of newcomer's confusion is a good trade off. [1] http://patternfly-react.surge.sh/patternfly-3/index.html?knob-Edit%20whole%20table=true&selectedKind=patternfly-react%2FContent%20Views%2FTable%20View&selectedStory=Table%20With%20Inline%20Edit%20Cells&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybooks%2Fstorybook-addon-knobs
for me the most important argument is that it is aligned with patternfly-react. Im inclined to close this as wont-fix. @Liz: agree?
That's fine for now from my point of view.
as per comment 6, closing
If I do the same thing on VM disk/network page, not on the wizard, create a nic/disk and then click "x", it does not leave something there. It seems there are inconsistent behaviors.
*** Bug 1673423 has been marked as a duplicate of this bug. ***
Plus one to the comment #9, it's inconsistent behavior of the same button on different screens. I request a fix please.
ok, reopening to get this back to the radar
Liz: it seems more ppl find this incorrect. What do you think?
Yes, I believe it's incorrect too. Although the proposal is inconsistent as noted above, there is a good reason. Here are the two use cases: 1) I am a user who is coming in to edit a NIC that exists and I realize mid-way that I wish to cancel my edits. Result is that NIC should go back to it's previous state unchanged. 2) I am a user who is coming in to create a NIC that doesn't exist yet. I click create and then realize that I actually do not wish to create it. The result SHOULD BE that is goes back to as if I never created this NIC in which case it should be deleted. I hope this helps make sense of where we should go and that we should push a change for this action to delete the new NIC or disk row rather than keep it.
https://github.com/kubevirt/web-ui-components/pull/430
https://github.com/kubevirt/web-ui-components/pull/443
Verified that the current behaviour of adding nics/discs is consistent on VM/template detail pages and the VM/template wizard. Version: 2.0.0-14.5
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2019:1850