Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1646956

Summary: Empty string on ovirtmgmt's label instead of null as should be
Product: [oVirt] ovirt-engine Reporter: Michael Burman <mburman>
Component: BLL.NetworkAssignee: Eli Mesika <emesika>
Status: CLOSED CURRENTRELEASE QA Contact: Michael Burman <mburman>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 4.3.0CC: bugs, emesika, mburman, mperina
Target Milestone: ovirt-4.3.0Keywords: AutomationBlocker, Regression
Target Release: ---Flags: rule-engine: ovirt-4.3+
rule-engine: blocker+
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: ovirt-engine-4.3.0_rc Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-02-13 07:45:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screenshots none

Description Michael Burman 2018-11-06 11:43:57 UTC 
Description of problem:
Empty string on ovirtmgmt's label instead of null as should be 

This is seems to be very much similar to issue we saw already in the past - 
BZ 1560684

Looks like every new/fresh engine 4.3 deploy sets an empty string instead of null. And under labels the ovirtmgmt is labeled with empty string which is wrong and might effect HE deployment like we had with BZ 1560684

Also, an empty label is an option in the drop down labels list and that is bad. There should be no empty string labels in the drop down list. 

Version-Release number of selected component (if applicable):
4.3.0-0.0.master.20181101091940.git61310aa.el7

How reproducible:
Seems to be 100% for fresh 4.3 ovirt deploy

Steps to Reproduce:
1. Deploy new/clean 4.3 master engine

Actual results:
ovirtmgmt is labeled with empty string instead of null('-')

Expected results:
ovirtmgmt has null in label by default and not an empty string.
Comment 1 Michael Burman 2018-11-06 11:49:08 UTC 
Created attachment 1502415 [details]
screenshots
Comment 2 Dan Kenigsberg 2018-11-12 09:52:41 UTC 
Eli, isn't it deja vu all over again?
Comment 3 Eli Mesika 2018-11-12 13:43:44 UTC 
(In reply to Dan Kenigsberg from comment #2)
> Eli, isn't it deja vu all over again?

Taking the BZ , have to reproduce and look at it
Comment 4 Michael Burman 2018-12-02 11:45:10 UTC 
This bug affecting our automation tests, such as DNS.
If trying to update ovirtmgmt's DNS via REST we blocked by this bug. I believe this affecting also other major scenarios. 

Failed to update element NOT as expected:
	Status: 400
	Reason: Bad Request
	Detail: [Network label must be formed only from: English letters, numbers, hyphen or underscore., Attribute: network.label]
Comment 5 Red Hat Bugzilla Rules Engine 2018-12-07 07:34:34 UTC 
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.
Comment 6 Michael Burman 2018-12-12 06:26:52 UTC 
The bug is failed QA. Reproduced on clean installation of 4.3.0-0.6.alpha2.el7
Comment 7 Eli Mesika 2018-12-12 08:31:23 UTC 
Can not reproduce , this is done after clean 4,3 install :


engine_master=# select * from network where label is NULL;
-[ RECORD 1 ]-----------------+-------------------------------------
id                            | 00000000-0000-0000-0000-000000000009
name                          | ovirtmgmt
description                   | Management Network
type                          | 
addr                          | 
subnet                        | 
gateway                       | 
vlan_id                       | 
stp                           | f
storage_pool_id               | cce3a020-fde7-11e8-a6ba-54ee7521e149
mtu                           | 
vm_network                    | t
provider_network_provider_id  | 
provider_network_external_id  | 
free_text_comment             | 
label                         | 
qos_id                        | 
dns_resolver_configuration_id | 
vdsm_name                     | ovirtmgmt
provider_physical_network_id  | 

engine_master=# select * from network where label='';
(0 rows)




Please attach your data on the above queries
Comment 8 Michael Burman 2018-12-12 08:36:22 UTC 
Will provide the clean details env in private.
Comment 9 Martin Perina 2018-12-12 08:51:14 UTC 
Moving back to MODIFIED, the fix is not included in 4.3.0-0.6.alpha2.el7, we need to wait for newer build
Comment 10 Michael Burman 2019-01-20 12:32:01 UTC 
Verified on - 4.3.0-0.8.rc2.el7
Comment 11 Sandro Bonazzola 2019-02-13 07:45:02 UTC 
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.